- 10 Mar, 2011 3 commits
-
-
Dan Bornstein authored
Give the UTF-8 parsing/validation code and the debug info decoder their own files in libdex. Also, moved the random utility dexRoundUpPower2() so it wasn't in the middle of unrelated stuff (though maybe it doesn't want to stay in DexFile.c at all). Change-Id: I115447e49904e2440dd538b1df90616ea95707a9
-
Dan Bornstein authored
-
Dan Bornstein authored
I made a combined class name / type descriptor validator in libdex extracted from the original type descriptor validator, made the original validator use that, and added another public function to do class name validation. The two not-quite-validators in CheckJNI.c and InternalNative.c now do proper checking. Change-Id: I0f25e3efb439da065d92596197d219792d5a46b1
-
- 09 Mar, 2011 6 commits
-
-
Dan Bornstein authored
-
Dan Bornstein authored
Class.forName() will now do a better job of checking the validity of the names passed to it. Also, cleared out the TODO on dvmThrowClassNotFoundException(), having determined that it would have been a bad idea. Change-Id: Ia5b8c613ef8f49a313ad825dc4c72cc5ff428e69
-
Andy McFadden authored
As reported in external bug 15349, we were being a bit sloppy in our handling of sub-32-bit types, assuming they could be treated as 32 bit values. Bug 4080070 Change-Id: I3d2e014342d7ff4e1544e37666680eb05aba37e6
-
Carl Shapiro authored
This change removes support for direct references. Change-Id: I2af043ecfc5811c16a7d02a5bbb6c071ec6f0a82
-
Carl Shapiro authored
-
Carl Shapiro authored
Change-Id: I6644bd3cbd60024db60a46f9ead4d50a3112f751
-
- 08 Mar, 2011 13 commits
-
-
Andy McFadden authored
-
Andy McFadden authored
When calling a JNI method we have to push a variable number of arguments onto the stack. This confuses the stack unwinders in gdb and debuggerd. It turns out that the unroll tables consulted by debuggerd let you specify a frame pointer register. If we set that up, we can get a full debuggerd trace. gdb is still confused though. We now need to preserve fp on entry, but we no longer need to save off sp, and as a result of some additional register shuffling we also no longer need to save r4 and r5. Bug 3466808 Change-Id: I5fda1deae330e698553657dc233bd06476b25ce2
-
Andy McFadden authored
Moved a couple of things out of MethodTraceState so they don't get zeroed after being initialized. Also, rearranged the native method invocation path slightly so the common case runs uninterrupted. Change-Id: I0dad007a7f344d93f30444156e67f20bed6606a4
-
Carl Shapiro authored
-
Carl Shapiro authored
-
Carl Shapiro authored
The card from address computation checks that the argument is a valid card. However, the limit points just past the end of the last card so it is often invalid. This fixes a crash in asserts-enabled builds. Change-Id: I5d7f0a4753703f82b2e1be520e6108d1b61b22d3
-
Carl Shapiro authored
This change eliminates all compilation errors and warnings when the indirect reference feature is enabled, adds support for the indirect reference table to the root visitor, and adds a new implementation of jni weak global references integrated with the garbage collector. Change-Id: Ieb4a0eb6c352b1a7dc095b0be1b5df2ad133fb64
-
buzbee authored
Change-Id: I29ffeacb0f4bfb740011c449a3693edd61ade4db
-
buzbee authored
Change-Id: I3c4d6895209ccba61ec3a14c24274939a7fc65e8
-
Jesse Wilson authored
-
Jesse Wilson authored
Previously it would build a .jar file containing a classes.dex that itself contained no classes. Change-Id: I9c36a5dcdd17d2821be15f87656d72ef0048c113
-
Jesse Wilson authored
-
Jesse Wilson authored
Change-Id: I21b8537518718350def2f847e9c76ae4154bd4d6 http://b/4026001
-
- 07 Mar, 2011 2 commits
-
-
Dan Bornstein authored
Make the messages that consist of a series of values consistently use semicolons between the values, and make the call order for exception throws that take both "info about a thing" as well as "info about a use of that thing" take the "info about a thing" argument first. Practical upshot: Adding a second semicolon in the message for StringIndexOutOfBoundsException being thrown for a region, and switching the order of arguments of dvmThrowArrayIndexOutOfBoundsException(). Bug: 3500987 Change-Id: I97eb0046ab8997a68e2d6dfde5dbf3d02290c1f7
-
Dan Bornstein authored
I pulled out all the initialization code that I could find that was merely looking up class and member names during early VM initialization, putting them all in a new file, InitRefs.c. I didn't do any real restructuring of the code, though. That will come in a follow-up. This was instigated by discussion surrounding bug #3500987, but it's not directly related to it. Change-Id: I59e93e552d29a5518f2cc4e1e30c4a8d51750d7b
-
- 06 Mar, 2011 1 commit
-
-
buzbee authored
Fix some failures w/ the new Dalvik JUMBO opcodes on the x86 and portable interpreters. These showed up on dalvik/test/089-jumbo-opcodes when running with: run-test --host 089 # x86 host-mode run-test --portable --host 089 # portable host-mode run-test --portable 089 # on device, portable Change-Id: I520c8d2e001db95aa7525e4ffde7a81e2e786d38
-
- 05 Mar, 2011 1 commit
-
-
David Turner authored
-
- 04 Mar, 2011 7 commits
-
-
Dan Bornstein authored
Since the there is no longer a "ByClass" vs. not distinction, remove all the "ByClass"es. Bug: 3500987 Change-Id: I6bdaf5a31e8166b47c333dbbb394dc811f321c5d
-
Dan Bornstein authored
We hereby wish a fond farewell to the throw functions that took a string name for the exception. Bug: 3500987 Change-Id: I869ddc2b4e45d3122859249d4010e452d790fa1f
-
Dan Bornstein authored
-
Andy McFadden authored
-
Dan Bornstein authored
I believe this change gets rid of the remaining throw calls that used quoted strings for the excpetion type argument. Bug: 3500987 Change-Id: Id4f905883c1a4e4e5608a2c59986cbd602d416cc
-
Andy McFadden authored
We want to be able to load classes from a DEX file in memory, rather than insisting that they always be loaded from disk. This provides the underpinnings. The code was previously using the "are we in dexopt" flag to decide if it needed to mprotect(RW) DEX data before altering it. We now have an explicit flag. Also, scraped off some "opt header flags" checks that never did much. Bug 1338213 Change-Id: If7128bf246992156662e089a2a87cebf475a6f2a
-
Dan Bornstein authored
This includes banishing dvmThrowExceptionWithClassMessage(), in favor of the "ByClass" version, as well as making the verification error throwing code use class objects. Bug: 3500987 Change-Id: I1d63cec0ffaf3a0ad17e9304ba6a21fe51072fc7
-
- 03 Mar, 2011 7 commits
-
-
Dan Bornstein authored
-
Dan Bornstein authored
I'm starting to scrape the bottom of the barrel. Bug: 3500987 Change-Id: If9c0f922506a94e78c504ea8c58176effe5fe00c
-
jeffhao authored
-
jeffhao authored
Change-Id: Iad2bde29a3e0898b564b8e2c695dd45d3a6e927f
-
Dan Bornstein authored
Bug: 2557227 Change-Id: I8ca2479cbc76de6bf3bd746bad8ceb99b732d8c5
-
Dan Bornstein authored
-
Dan Bornstein authored
This time I *didn't* modify all the call sites, as they're not all straightforward. However, I will do so in a separate follow-up. Bug: 3500987 Change-Id: I7c8b4fe960704dc37e192d645be9da9d97159627
-