GitLab

To reduce lock contention when predexing in process in parallel.

Test: existing.
Change-Id: Ia929bc10f57b1d2d4c62cffff4fc0f09cbf9e445

Test: manual.
Change-Id: I14289dbd2e507372d82dd5cc64b4fac761026a5e

Test: Manual.
Change-Id: I306d61e3fe49353b64ebee24413a83062365968d

This commit fixes the parameters passed to MainDexListBuilder when the annotation workaround switch is not used. To test this, run a build on Windows that invokes the mainDexClasses.bat script for building the list of the classes for the main dex file.

Test: run a build of any Android app on Windows, and make sure the build invokes the build invokes the mainDexClasses.bat script without the annotation workaround switch.
Change-Id: Ifb0efc7d23773b16a4cb1b2c37bf99b8d0827881

Rationale:
Comparing expected length with actual length should reject
both too long and too short, as both directions are vulnerable
(before we were trying too hard to be nice).

Bug: 34469397
Test: dexdump
Change-Id: Ie221071d557905c51963fd667f451d612a42db96

Remove static state, clear biggest caches after running.

Test: TBD.

Change-Id: Ib41a61687b48bfb46f7e104c41d784cad61f306a

am: cfe8c963

Change-Id: I2aa3a483326ca60c089323b5faa892c940da7682

am: f075a676

Change-Id: I5134fbb25d4fa5de6b07046eabf97b00d61b7bdf

am: e2eee30d

Change-Id: I0122c66ccf6131da3fb3d62a42bdf7ef7a4cc417

This reverts commit 455443f4.

Bug: 32432143
Bug: 25998400
Change-Id: I6625c9519341d6903a009da0aeebbe8fc1be9035

This reverts commit f1967263.

Bug: 32432143
Change-Id: I3b90f1e65b34eea9c78e690a99f36d8596d05c6b

This reverts commit e3b89304.

Bug: 32432143
Change-Id: I39c7ee84f97e0d7d086bf57a36b558c5ba091cbe

am: 90aa7797

Change-Id: I4c088b5888f203303e90d3f884d4419ed421e51a

Bug: 30188076
Test: make checkbuild
Change-Id: I1c7b9508a81d73e81906b9b1a2c27a5acf5eccd4

am: c12eb576

Change-Id: I53687124aa1c16d7cdd0590d637799ed97713621

am: d5c56fdb

Change-Id: Icee32624919d549296d2a6f4c8b2fcb168be0236

Ran the tests individually and most passed, a couple did not.
They were 115-merge and 119-merge-conflict. They both failed
with "unsupported class file version 52.0" failures so nothing
to do with this change.

Bug: 30188076
Test: ran them with ./run-test.
Change-Id: I21f9ea34e27972c5195e6feaa96763a960d04d4e

Since it is empty and immutable, let's consider it sorted.
Also do not sort if it is already sorted.

Test: manual
Bug: 32432143
Bug: 33108650
Change-Id: I61541955681a1502db2f7d7bac74c68655073de0

am: af28c471

Change-Id: If641d6973d6846c766bbafd63e57420f4f330081

Test: /dalvik/dx/tests/run-all-tests (Still not all passing)
Change-Id: Ie5df1fc0a9fd6c7e92e83bda608c942ccb010441

am: f4da03e8

Change-Id: I1b1dbcedc6f3a8026ae2a783e25e5134ae987df0

To retrieve the local variable info that corresponds to a register from the
pc, the LocalVariableList must be sorted by pc.
This is because we match variables using the end pc and not the start pc
anymore (which is unreliable, see 455443f4),
so for a given index we need to try the LV info with the lower pc first.

Test: manual
Bug: 32432143
Change-Id: I6289f9a2103b99d8362cf6870e45d3fb342d32ca

am: 1e2aa00f

Change-Id: I28d549b8c4fde87ec59b6ff6b076fc7308ce976e

As a consequence of the CL that relaxes the conditions to retrieve LV
debug info (455443f4), there may be a
SimException because of a "local variable type mismatch".
Some local variable slots may be used for different local variables
with different types, but only one has debug info.
So we need to check if the types match, and ignore the local variable
info if it doesn't.

Bug: 32432143
Test: manual
Change-Id: I0a12ac6476f612c0d8e597c9690587826ac41841

am: f79a0917

Change-Id: I8b7bfceab58d80439b2a3964174e800cdf037638