Commits · ad49b3b71508aff4a371d4e487b90971d9799721 · scorpio / external_skia

02 Feb, 2015 4 commits

qiankun.miao authored 10 years ago

Backport optimization from https://codereview.chromium.org/874863002/.
Microbenchmarks data compared to previous SSE2 implementation:
bitmap_BGRA_8888_A_source_stripes_three 7.52us -> 8.67us 1.15x
bitmap_BGRA_8888_A_source_stripes_two 7.48us -> 8.56us 1.15x
bitmap_BGRA_8888_update_scale_rotate_bilerp 63.4us -> 64us 1.01x
bitmap_BGRA_8888_update_volatile 3.31us -> 3.33us 1.01x
bitmap_BGRA_8888_scale 11.1us -> 11.2us 1x
bitmap_BGRA_8888_scale_bilerp 35.8us -> 35.9us 1x
bitmap_BGRA_8888 3.33us -> 3.33us 1x
bitmap_BGRA_8888_A_scale_rotate_bicubic 66.7us -> 66.5us 1x
bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 65.1us -> 64us 0.98x
bitmap_BGRA_8888_scale_rotate_bilerp 65.1us -> 64us 0.98x
bitmap_BGRA_8888_A_scale_bicubic 30.6us -> 29.9us 0.98x
bitmap_BGRA_8888_A_scale_bilerp 42.7us -> 41.4us 0.97x
bitmap_BGRA_8888_A_scale_rotate_bilerp 71us -> 67.7us 0.95x
bitmap_BGRA_8888_A 7.44us -> 5.7us 0.77x
bitmap_BGRA_8888_A_source_opaque 7.46us -> 3.72us 0.5x
bitmap_BGRA_8888_A_source_transparent 7.46us -> 1.96us 0.26x

BUG=skia:

Review URL: https://codereview.chromium.org/886403002

ad49b3b7

Disable LCD text when rasterizing SkPictureShader tiles. · 3d91aad2
fmalita authored 10 years ago
```
BUG=chromium:453299
R=reed@google.com

Review URL: https://codereview.chromium.org/884163003
```
3d91aad2

Update SKP version · c927918c

skia.buildbots authored 10 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/890293003

c927918c

allow GMs to animate · d9adfe6a

reed authored 10 years ago

BUG=skia:

Review URL: https://codereview.chromium.org/888283002

d9adfe6a

01 Feb, 2015 4 commits

Update SKP version · 47471cf1

skia.buildbots authored 10 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/888343002

47471cf1

Revert of Move npot resizing out of GrContext and simplify GrContext texture... · e137db85

bsalomon authored 10 years ago

Revert of Move npot resizing out of GrContext and simplify GrContext texture functions. (patchset #10 id:200001 of https://codereview.chromium.org/882223003/)

Reason for revert:
perf fix didn't fix the cr webgl conformance tests

Original issue's description:
> Move npot resizing out of GrContext and simplify GrContext texture functions.
>
> Committed: https://skia.googlesource.com/skia/+/8a8100349105c8c6de39fcb34e47679da7a67f54
>
> Committed: https://skia.googlesource.com/skia/+/6c96672491b04cb782bce8fee778124df66524a0

TBR=robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/887303002

e137db85

SVG backend in DM · 8a4527e9

mtklein authored 10 years ago

Not enabled by default, but this should get you SKPs, GMs etc for free to play with.

$ out/Debug/dm -w svgs --src gm skp --config svg

BUG=skia:

Review URL: https://codereview.chromium.org/892693002

8a4527e9

Move npot resizing out of GrContext and simplify GrContext texture functions. · 6c966724

bsalomon authored 10 years ago

Committed: https://skia.googlesource.com/skia/+/8a8100349105c8c6de39fcb34e47679da7a67f54

Review URL: https://codereview.chromium.org/882223003

6c966724

31 Jan, 2015 5 commits

Remove extraneous newline. · 0b737c52

Brian Salomon authored 10 years ago

TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/878333004

0b737c52

Add standard way to indicate GM is GPU-only. · b62da80c

bsalomon authored 10 years ago

TBR=egdaniel@google.com,mtklein@google.com

Review URL: https://codereview.chromium.org/869393007

b62da80c

Revert of Move npot resizing out of GrContext and simplify GrContext texture... · 6bfef2df

fmalita authored 10 years ago

Revert of Move npot resizing out of GrContext and simplify GrContext texture functions. (patchset #9 id:160001 of https://codereview.chromium.org/882223003/)

Reason for revert:
webGL conformance failures:

WebglConformance.conformance_textures_tex_image_and_sub_image_2d_with_video
WebglConformance.conformance_textures_texture_npot_video

https://codereview.chromium.org/892773003/
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/29272

Original issue's description:
> Move npot resizing out of GrContext and simplify GrContext texture functions.
>
> Committed: https://skia.googlesource.com/skia/+/8a8100349105c8c6de39fcb34e47679da7a67f54

TBR=robertphillips@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/868233005

6bfef2df

Update SKP version · 6726e78c

skia.buildbots authored 10 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/875243006

6726e78c

Update dump code in FontConfigParser test. · a44e9b98

bungeman authored 10 years ago

This code is still quite useful for debugging, but has bit rotted.
Update to match current structure of code.

Review URL: https://codereview.chromium.org/890073002

a44e9b98

30 Jan, 2015 24 commits

Convert FamilyData to Skia style field names. · b6bed17e

bungeman authored 10 years ago

The Skia convention is to prefix field names with 'f'.
This change is mostly mechanical.

Review URL: https://codereview.chromium.org/892733002

b6bed17e

Do not leak FamilyData in Android SkFontMgr. · 7a3527d7

bungeman authored 10 years ago

Currently, it appears one FamilyData is leaking per scanned file.
This also cleans up the hanging currentFamily memory management.

Review URL: https://codereview.chromium.org/889943005

7a3527d7

export SkImageInfo · 41814925

reed authored 10 years ago

BUG=skia:

Review URL: https://codereview.chromium.org/893603005

41814925

Do not add indirection to XML_Parser. · 3af41fab

bungeman authored 10 years ago

The expat type XML_Parser is already a pointer, so pass it by value
instead of by indirection.

Review URL: https://codereview.chromium.org/880783003

3af41fab

Revert of Add device space "nudge" to gpu draws (patchset #6 id:90001 of... · 7f14c9bb

robertphillips authored 10 years ago

Revert of Add device space "nudge" to gpu draws (patchset #6 id:90001 of https://codereview.chromium.org/877473005/)

Reason for revert:
Blink layout tests this time :(

Original issue's description:
> Add device space "nudge" to gpu draws
>
> This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
>
> BUG=423834
>
> Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78
>
> Committed: https://skia.googlesource.com/skia/+/b9329991426d0b77ea194a380d72d73fb855308a

TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=423834

Review URL: https://codereview.chromium.org/886153002

7f14c9bb

Suggestions and merge in the other CL. · edc93bc7

mtklein authored 10 years ago

I had some suggestions on the subset CL, and took the opportunity to rebase it
against head and merge in the other color type CL.

BUG=skia:

Review URL: https://codereview.chromium.org/893703002

edc93bc7

Reland "remove unused SkAvoidXfermode" · e7ea40f4

scroggo authored 10 years ago

(patchset #2 id:20001 of https://codereview.chromium.org/860583002/)

SkAvoidXfermode has been moved into Android, so it is safe to remove.

Review URL: https://codereview.chromium.org/890893003

e7ea40f4

Disable the noisiest /analyze warning in Chrome. ~3,700/12,000 · aea85dc3

brucedawson authored 10 years ago

Decades ago Intel decided that the bsr (Bit Scan Reverse) instruction
should have undefined results if its argument is zero. This probably
makes the instruction harder to implement and it definitely makes it
more difficult to use.

In SkCLZ_portable it requires a check for a zero argument, but despite
that check /analyze still warns that _BitScanReverse might fail
(because it doesn't know what can cause failures). Because this warning
occurs in a frequently included header file it ends up being very noisy,
accounting for ~30% of all warnings (before deduplication).

Suppressing this useless warning will make the raw results easier to
look through.

Review URL: https://codereview.chromium.org/872673007

aea85dc3

Move npot resizing out of GrContext and simplify GrContext texture functions. · 8a810034
bsalomon authored 10 years ago
```
Review URL: https://codereview.chromium.org/882223003
```
8a810034

First cut at cleaning up Sergio's example code and moving some common code to SkWindow. · c8fcafb3

caryclark authored 10 years ago

Eventually, this will be moved to be a peer of SampleApp so it is compiled by the bots to avoid future bit rot.

Also ignore XCode auto-generated flag in CommandLineFlags, and remove the unused multiple-example part.

Review URL: https://codereview.chromium.org/890873003

c8fcafb3

DM: paths as implict strings too. · 8d17a13a
mtklein authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/891823002
```
8d17a13a

Add device space "nudge" to gpu draws · b9329991

robertphillips authored 10 years ago

This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.

BUG=423834

Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78

Review URL: https://codereview.chromium.org/877473005

b9329991

DM::NullSink · 022afb83

halcanary authored 10 years ago

Motivation:  The null sink can act as a control for experiments.

Review URL: https://codereview.chromium.org/873723007

022afb83

dm: allow multiple --images flags, allow single files · 23b03c3c
halcanary authored 10 years ago
```
Review URL: https://codereview.chromium.org/872993005
```
23b03c3c

Initial SVG backend stubbing · 93957f4e

fmalita authored 10 years ago

This adds SkSVGDevice and a small utility for converting SKP files to SVG (skp2svg).

R=reed@google.com,jcgregorio@google.com
BUG=skia:3368

Review URL: https://codereview.chromium.org/892533002

93957f4e

Remove unused globalRef/globalUnref. · 1872ad0f
scroggo authored 10 years ago
```
BUG=skia:1482

Review URL: https://codereview.chromium.org/887993003
```
1872ad0f
dm: allow multiple --skp flags, allow single files · fc37ad16
halcanary authored 10 years ago
```
Review URL: https://codereview.chromium.org/885353002
```
fc37ad16

Remove unused hasLocalMatrix. · 5d2fd446

scroggo authored 10 years ago

This method is not called anywhere on Android or Chrome, and it
has a FIXME that it may not be correct.

A client can still getLocalMatrix().isIdentity() if they need this
information. (It has the same FIXME, and perhaps we should revisit
it. In the meantime, this convenience method is not needed.)

Review URL: https://codereview.chromium.org/882443007

5d2fd446

documentation: Writing Unit and Rendering Tests · c3879663
halcanary authored 10 years ago
```
Review URL: https://codereview.chromium.org/885133002
```
c3879663
Define SK_OVERRIDE when building for Android framework. · 803a49df
scroggo authored 10 years ago
```
Review URL: https://codereview.chromium.org/868243003
```
803a49df

Update SKP version · f4ee92ee

skia.buildbots authored 10 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/893513002

f4ee92ee

Start SampleApp documentation · e4e01b86
herb authored 10 years ago
```
BUG=skia:359

Review URL: https://codereview.chromium.org/883203003
```
e4e01b86
Remove always true if statement and commented out code in GrBitmapTextContext · 06fb35fe
qiankun.miao authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/873473008
```
06fb35fe

Clean up commented out code in GrDistanceFieldTextContext · 16a3f175

qiankun.miao authored 10 years ago

SkCLZ isn't used any more. Just remove it.

BUG=skia:

Review URL: https://codereview.chromium.org/888533004

16a3f175

29 Jan, 2015 3 commits

Update comment for SkMallocPixelRef::NewWithProc. · 527b2873

scroggo authored 10 years ago

Add a comment about using a NULL ReleaseProc.

BUG=skia:2185

Review URL: https://codereview.chromium.org/885573005

527b2873

share code between arcTo and addArc, update dox · c778904a
reed authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/863123005
```
c778904a

Conservative blob bounds cleanup · f9a40723

fmalita authored 10 years ago

* drop SK_SUPPORT_LEGACY_BLOB_BOUNDS
* remove horizontal & fully position tight bounds support (always using
  conservative bounds now)
* special-case horizontal run bounds logic to avoid unnecessary vertical
  min-maxing

R=reed@google.com,mtklein@google.com

Review URL: https://codereview.chromium.org/858153007

f9a40723