Commits · 4c93a126889bf71b2eab5a5fa6375d731809dcb8 · scorpio / external_skia

03 Feb, 2015 14 commits

Fix references to https://sites.google.com/site/skiadocs/. · 4c93a126

Thiago Farina authored 10 years ago

Point them to their equivalent in https://skia.org.

BUG=None
R=hcm@google.com, jcgregorio@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/856353004

4c93a126

Hairline batch · 658d55cd

joshualitt authored 10 years ago

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/6eff8701f027016fbb3147412ec2292dcec2b7f5

Review URL: https://codereview.chromium.org/876673002

658d55cd

[SkSVGDevice] Initial shader/gradient support · 532faa90

fmalita authored 10 years ago

* linear gradient support (based on shawcroft@google.com's CL)
* generic paint resources reorg
* opacity support

R=reed@google.com,mtklein@google.com,halcanary@google.com

Review URL: https://codereview.chromium.org/892973002

532faa90

Whitespace change to test new compile bots · 1ca3e01b
Ravi Mistry authored 10 years ago

1ca3e01b

Update SKP version · fef4c32b

skia.buildbots authored 10 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/897603002

fef4c32b

Add texture create/upload stats and make nanobench have explicit gpu stats flag · b12ea412
bsalomon authored 10 years ago
```
Review URL: https://codereview.chromium.org/891973002
```
b12ea412

Revert of Make the glyph array entries inline. (patchset #10 id:170001 of... · 9bf4e5bb

bsalomon authored 10 years ago

Revert of Make the glyph array entries inline. (patchset #10 id:170001 of https://codereview.chromium.org/885903002/)

Reason for revert:
I suspect this is causing the off-by-one character issues that show up in gold.skia.org as of now. All the errors I've seen are on a Win7 bot. Example:

good:
https://gold.skia.org/img/images/35396bb0d299b81c0031dc0632a019d4.png

bad:
https://gold.skia.org/img/images/484e511f9e696d95031cd25aeae59da0.png

Original issue's description:
> Make the glyph array entries inline.
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4c08f16b252a55e438a61f26e5581394ed177da1

TBR=mtklein@google.com,reed@google.com,herb@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/897463004

9bf4e5bb

patch from issue 886233004 at patchset 40001 (http://crrev.com/886233004#ps40001) · b9eb4ac0
mtklein authored 10 years ago
```
... with changes proposed in the review.

BUG=skia:

Review URL: https://codereview.chromium.org/894013002
```
b9eb4ac0

Revert of Hairline batch (patchset #16 id:300001 of https://codereview.chromium.org/876673002/) · cb3f5046

joshualitt authored 10 years ago

Reason for revert:
Regression

Original issue's description:
> Hairline batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/6eff8701f027016fbb3147412ec2292dcec2b7f5

TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/894273002

cb3f5046

Make the glyph array entries inline. · 4c08f16b
herb authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/885903002
```
4c08f16b

make getContentKey() available in GrGpuResource public interface · 563ff60b

bsalomon authored 10 years ago

TBR=robertphillips@google.com

Committed: https://skia.googlesource.com/skia/+/85ed2db092e75db41b711b9116a8d5b465fc2b0c

Review URL: https://codereview.chromium.org/886313005

563ff60b

Hairline batch · 6eff8701

joshualitt authored 10 years ago

BUG=skia:

Review URL: https://codereview.chromium.org/876673002

6eff8701

Whitespace change to test new GCE compile bot · b1b823a8
Ravi Mistry authored 10 years ago

b1b823a8
Whitespace change to test new GCE compile bot · 5711ca33
Ravi Mistry authored 10 years ago

5711ca33

02 Feb, 2015 18 commits

Whitespace change to test new GCE compile bot · f4a61f8b
Ravi Mistry authored 10 years ago

f4a61f8b

Revert of make getContentKey() available in GrGpuResource public interface... · 9b440260

stephana authored 10 years ago

Revert of make getContentKey() available in GrGpuResource public interface (patchset #2 id:20001 of https://codereview.chromium.org/886313005/)

Reason for revert:
This causes in one case the linker and in the other the compiler to segfault. On

Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/Release

Original issue's description:
> make getContentKey() available in GrGpuResource public interface
>
> TBR=robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/85ed2db092e75db41b711b9116a8d5b465fc2b0c

TBR=robertphillips@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/864343005

9b440260

make getContentKey() available in GrGpuResource public interface · 85ed2db0
bsalomon authored 10 years ago
```
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/886313005
```
85ed2db0

DM: wire up --leaks / -l again · e67164d9

mtklein authored 10 years ago

No public API changes.
TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/893043002

e67164d9

Move npot resizing out of GrContext and simplify GrContext texture functions. · 37f9a269

bsalomon authored 10 years ago

Committed: https://skia.googlesource.com/skia/+/8a8100349105c8c6de39fcb34e47679da7a67f54

Committed: https://skia.googlesource.com/skia/+/6c96672491b04cb782bce8fee778124df66524a0

Review URL: https://codereview.chromium.org/882223003

37f9a269

move HelloWorld to be a peer of SampleApp · 52edc4d0

caryclark authored 10 years ago

This is working towards making a simple example part of the buildbot compile step and removing SkExamples from the experimental directory.

This works on Mac, Windows, and Linux but isn't complete for Android, ChromeOS and iOS.

Review URL: https://codereview.chromium.org/886413004

52edc4d0

add SkAnimTimer, SPACE = pause/resume, ESP = stop · 76113a9b
reed authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/894083003
```
76113a9b

Atomics overhaul. · a669bc7a

mtklein authored 10 years ago

This merges and refactors SkAtomics.h and SkBarriers.h into SkAtomics.h and
some ports/ implementations. The major new feature is that we can express
memory orders explicitly rather than only through comments.

The porting layer is reduced to four template functions:
  - sk_atomic_load
  - sk_atomic_store
  - sk_atomic_fetch_add
  - sk_atomic_compare_exchange
From those four we can reconstruct all our previous sk_atomic_foo.

There are three ports:
  - SkAtomics_std:    uses C++11 <atomic>,             used with MSVC
  - SkAtomics_atomic: uses newer GCC/Clang intrinsics, used on not-MSVC where possible
  - SkAtomics_sync:   uses older GCC/Clang intrinsics, used where SkAtomics_atomic not supported

No public API changes.
TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/896553002

a669bc7a

Add missing SK_OVERRIDE · 465206af

rmistry authored 10 years ago

Tested by running on clang head + ubuntu 14.04:
GYP_DEFINES=”skia_gpu=0 skia_warnings_as_errors=1" tools/xsan_build thread dm BUILDTYPE=Release
out/Release/dm -v

BUG=skia:3386

Review URL: https://codereview.chromium.org/894833002

465206af

add missing SK_OVERRIDE · 004a166a
mtklein authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/894153002
```
004a166a

Don't read unecessary font files on Android. · efbad371

bungeman authored 10 years ago

With a new style fonts.xml (version >= 21) fallback fonts are specified
as font families without a name. The current code reads these, but then
also reads in the old fallback and vendor xml files. With this change,
when a new style xml file is encoutered, no further files will be read.
This both lowers memory use and speeds font lookup. Locally, this
change reduces the number of font families loaded on my 'L' device from
148 to 80. All of the families removed are duplicates.

Review URL: https://codereview.chromium.org/888923003

efbad371

Revert of Revert of SSE4 opaque blend using intrinsics instead of assembly.... · 4bf1ce27

stephana authored 10 years ago

Revert of Revert of SSE4 opaque blend using intrinsics instead of assembly. (patchset #1 id:1 of https://codereview.chromium.org/873553003/)

Reason for revert:
Reverted the wrong CL.

Original issue's description:
> Revert of SSE4 opaque blend using intrinsics instead of assembly. (patchset #16 id:300001 of https://codereview.chromium.org/874863002/)
>
> Reason for revert:
> This causes a bug on the 'hittestpath' GM on MacMini 4,1
>
> See:
>
> https://gold.skia.org/#/triage/hittestpath?head=0
>
> for details.
>
> Original issue's description:
> > SSE4 opaque blend using intrinsics instead of assembly.
> >
> > Since we had such a hard time with the assembly versions of this blit (to the
> > point that we have them completely disabled everywhere), I thought I'd take
> > a shot at writing a version of the blit using intrinsics.
> >
> > The key feature of SSE4 we're exploiting is that we can use ptest (_mm_test*)
> > to skip the blend when the 16 src pixels we consider each loop are all opaque
> > or all transparent.  _mm_shuffle_epi8 from SSSE3 also lends a hand to extract
> > all those alphas.
> >
> > It's worth looking to see if we can backport this type of logic to SSE2 using
> > _mm_movemask_epi8, or up to 32 pixels at a time using AVX.
> >
> > My local performance testing doesn't show this to be an unambiguous win
> > (there are probably microbenchmarks and SKPs where we'd be better off just
> > powering through the blend rather than looking at alphas), but the potential
> > does seem tantalizing enough to let skiaperf vet it on the bots.  (< 1.0x is a win.)
> >
> > DM says it draws pixel perfect compare to the old code.
> >
> > Microbenchmarks:
> >                bitmap_RGBA_8888_A_source_stripes_two	  14us -> 14.4us	1.03x
> >              bitmap_RGBA_8888_A_source_stripes_three	14.3us -> 14.5us	1.01x
> >                        bitmap_RGBA_8888_scale_bilerp	61.9us -> 62.2us	1.01x
> > bitmap_RGBA_8888_update_volatile_scale_rotate_bilerp	 102us ->  101us	0.99x
> >                 bitmap_RGBA_8888_scale_rotate_bilerp	 103us ->  101us	0.99x
> >                               bitmap_RGBA_8888_scale	18.4us -> 18.2us	0.99x
> >              bitmap_RGBA_8888_A_scale_rotate_bicubic	  71us ->   70us	0.99x
> >          bitmap_RGBA_8888_update_scale_rotate_bilerp	 103us ->  101us	0.99x
> >               bitmap_RGBA_8888_A_scale_rotate_bilerp	 112us ->  109us	0.98x
> >                     bitmap_RGBA_8888_update_volatile	5.72us -> 5.58us	0.98x
> >                                     bitmap_RGBA_8888	5.73us -> 5.58us	0.97x
> >                              bitmap_RGBA_8888_update	5.78us ->  5.6us	0.97x
> >                      bitmap_RGBA_8888_A_scale_bilerp	70.7us ->   68us	0.96x
> >                     bitmap_RGBA_8888_A_scale_bicubic	23.7us -> 21.8us	0.92x
> >                                   bitmap_RGBA_8888_A	13.9us -> 10.9us	0.78x
> >                     bitmap_RGBA_8888_A_source_opaque	  14us -> 6.29us	0.45x
> >                bitmap_RGBA_8888_A_source_transparent	  14us -> 3.65us	0.26x
> >
> > Running over our ~70 SKP web page captures, this looks like we spend 0.7x
> > the time in S32A_Opaque_BlitRow compared to the SSE2 version, which should
> > be a decent predictor of real-world impact.
> >
> > BUG=chromium:399842
> >
> > Committed: https://skia.googlesource.com/skia/+/04bc91b972417038fecfa87c484771eac2b9b785
> >
> > CQ_EXTRA_TRYBOTS=client.skia:Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release-Trybot
> >
> > Committed: https://skia.googlesource.com/skia/+/6dbfb21a6c88af6d94e8c823c3ad559f1a41b493
>
> TBR=henrik.smiding@intel.com,mtklein@google.com,herb@google.com,reed@google.com,thakis@chromium.org,mtklein@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:399842
>
> Committed: https://skia.googlesource.com/skia/+/4988891a1173cd405bf1c1dd3a3668c451f45e4c

TBR=henrik.smiding@intel.com,mtklein@google.com,herb@google.com,reed@google.com,thakis@chromium.org,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:399842

Review URL: https://codereview.chromium.org/894083002

4bf1ce27

Revert of SSE4 opaque blend using intrinsics instead of assembly. (patchset... · 4988891a

stephana authored 10 years ago

Revert of SSE4 opaque blend using intrinsics instead of assembly. (patchset #16 id:300001 of https://codereview.chromium.org/874863002/)

Reason for revert:
This causes a bug on the 'hittestpath' GM on MacMini 4,1

See:

https://gold.skia.org/#/triage/hittestpath?head=0

for details.

Original issue's description:
> SSE4 opaque blend using intrinsics instead of assembly.
>
> Since we had such a hard time with the assembly versions of this blit (to the
> point that we have them completely disabled everywhere), I thought I'd take
> a shot at writing a version of the blit using intrinsics.
>
> The key feature of SSE4 we're exploiting is that we can use ptest (_mm_test*)
> to skip the blend when the 16 src pixels we consider each loop are all opaque
> or all transparent.  _mm_shuffle_epi8 from SSSE3 also lends a hand to extract
> all those alphas.
>
> It's worth looking to see if we can backport this type of logic to SSE2 using
> _mm_movemask_epi8, or up to 32 pixels at a time using AVX.
>
> My local performance testing doesn't show this to be an unambiguous win
> (there are probably microbenchmarks and SKPs where we'd be better off just
> powering through the blend rather than looking at alphas), but the potential
> does seem tantalizing enough to let skiaperf vet it on the bots.  (< 1.0x is a win.)
>
> DM says it draws pixel perfect compare to the old code.
>
> Microbenchmarks:
>                bitmap_RGBA_8888_A_source_stripes_two	  14us -> 14.4us	1.03x
>              bitmap_RGBA_8888_A_source_stripes_three	14.3us -> 14.5us	1.01x
>                        bitmap_RGBA_8888_scale_bilerp	61.9us -> 62.2us	1.01x
> bitmap_RGBA_8888_update_volatile_scale_rotate_bilerp	 102us ->  101us	0.99x
>                 bitmap_RGBA_8888_scale_rotate_bilerp	 103us ->  101us	0.99x
>                               bitmap_RGBA_8888_scale	18.4us -> 18.2us	0.99x
>              bitmap_RGBA_8888_A_scale_rotate_bicubic	  71us ->   70us	0.99x
>          bitmap_RGBA_8888_update_scale_rotate_bilerp	 103us ->  101us	0.99x
>               bitmap_RGBA_8888_A_scale_rotate_bilerp	 112us ->  109us	0.98x
>                     bitmap_RGBA_8888_update_volatile	5.72us -> 5.58us	0.98x
>                                     bitmap_RGBA_8888	5.73us -> 5.58us	0.97x
>                              bitmap_RGBA_8888_update	5.78us ->  5.6us	0.97x
>                      bitmap_RGBA_8888_A_scale_bilerp	70.7us ->   68us	0.96x
>                     bitmap_RGBA_8888_A_scale_bicubic	23.7us -> 21.8us	0.92x
>                                   bitmap_RGBA_8888_A	13.9us -> 10.9us	0.78x
>                     bitmap_RGBA_8888_A_source_opaque	  14us -> 6.29us	0.45x
>                bitmap_RGBA_8888_A_source_transparent	  14us -> 3.65us	0.26x
>
> Running over our ~70 SKP web page captures, this looks like we spend 0.7x
> the time in S32A_Opaque_BlitRow compared to the SSE2 version, which should
> be a decent predictor of real-world impact.
>
> BUG=chromium:399842
>
> Committed: https://skia.googlesource.com/skia/+/04bc91b972417038fecfa87c484771eac2b9b785
>
> CQ_EXTRA_TRYBOTS=client.skia:Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/6dbfb21a6c88af6d94e8c823c3ad559f1a41b493

TBR=henrik.smiding@intel.com,mtklein@google.com,herb@google.com,reed@google.com,thakis@chromium.org,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:399842

Review URL: https://codereview.chromium.org/873553003

4988891a

Add resourcePath to running dm on Android doc. · db204e30

bungeman authored 10 years ago

Without specifying the resource path a number of tests and gms do not
work properly. The example given in the docs should specify the
resource path so that the example run is exemplary.

Review URL: https://codereview.chromium.org/898453003

db204e30

Optimize SSE2 opaque blend · ad49b3b7

qiankun.miao authored 10 years ago

Backport optimization from https://codereview.chromium.org/874863002/.
Microbenchmarks data compared to previous SSE2 implementation:
bitmap_BGRA_8888_A_source_stripes_three 7.52us -> 8.67us 1.15x
bitmap_BGRA_8888_A_source_stripes_two 7.48us -> 8.56us 1.15x
bitmap_BGRA_8888_update_scale_rotate_bilerp 63.4us -> 64us 1.01x
bitmap_BGRA_8888_update_volatile 3.31us -> 3.33us 1.01x
bitmap_BGRA_8888_scale 11.1us -> 11.2us 1x
bitmap_BGRA_8888_scale_bilerp 35.8us -> 35.9us 1x
bitmap_BGRA_8888 3.33us -> 3.33us 1x
bitmap_BGRA_8888_A_scale_rotate_bicubic 66.7us -> 66.5us 1x
bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 65.1us -> 64us 0.98x
bitmap_BGRA_8888_scale_rotate_bilerp 65.1us -> 64us 0.98x
bitmap_BGRA_8888_A_scale_bicubic 30.6us -> 29.9us 0.98x
bitmap_BGRA_8888_A_scale_bilerp 42.7us -> 41.4us 0.97x
bitmap_BGRA_8888_A_scale_rotate_bilerp 71us -> 67.7us 0.95x
bitmap_BGRA_8888_A 7.44us -> 5.7us 0.77x
bitmap_BGRA_8888_A_source_opaque 7.46us -> 3.72us 0.5x
bitmap_BGRA_8888_A_source_transparent 7.46us -> 1.96us 0.26x

BUG=skia:

Review URL: https://codereview.chromium.org/886403002

ad49b3b7

Disable LCD text when rasterizing SkPictureShader tiles. · 3d91aad2
fmalita authored 10 years ago
```
BUG=chromium:453299
R=reed@google.com

Review URL: https://codereview.chromium.org/884163003
```
3d91aad2

Update SKP version · c927918c

skia.buildbots authored 10 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/890293003

c927918c

allow GMs to animate · d9adfe6a

reed authored 10 years ago

BUG=skia:

Review URL: https://codereview.chromium.org/888283002

d9adfe6a

01 Feb, 2015 4 commits

Update SKP version · 47471cf1

skia.buildbots authored 10 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/888343002

47471cf1

Revert of Move npot resizing out of GrContext and simplify GrContext texture... · e137db85

bsalomon authored 10 years ago

Revert of Move npot resizing out of GrContext and simplify GrContext texture functions. (patchset #10 id:200001 of https://codereview.chromium.org/882223003/)

Reason for revert:
perf fix didn't fix the cr webgl conformance tests

Original issue's description:
> Move npot resizing out of GrContext and simplify GrContext texture functions.
>
> Committed: https://skia.googlesource.com/skia/+/8a8100349105c8c6de39fcb34e47679da7a67f54
>
> Committed: https://skia.googlesource.com/skia/+/6c96672491b04cb782bce8fee778124df66524a0

TBR=robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/887303002

e137db85

SVG backend in DM · 8a4527e9

mtklein authored 10 years ago

Not enabled by default, but this should get you SKPs, GMs etc for free to play with.

$ out/Debug/dm -w svgs --src gm skp --config svg

BUG=skia:

Review URL: https://codereview.chromium.org/892693002

8a4527e9

Move npot resizing out of GrContext and simplify GrContext texture functions. · 6c966724

bsalomon authored 10 years ago

Committed: https://skia.googlesource.com/skia/+/8a8100349105c8c6de39fcb34e47679da7a67f54

Review URL: https://codereview.chromium.org/882223003

6c966724

31 Jan, 2015 4 commits

Remove extraneous newline. · 0b737c52

Brian Salomon authored 10 years ago

TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/878333004

0b737c52

Add standard way to indicate GM is GPU-only. · b62da80c

bsalomon authored 10 years ago

TBR=egdaniel@google.com,mtklein@google.com

Review URL: https://codereview.chromium.org/869393007

b62da80c

Revert of Move npot resizing out of GrContext and simplify GrContext texture... · 6bfef2df

fmalita authored 10 years ago

Revert of Move npot resizing out of GrContext and simplify GrContext texture functions. (patchset #9 id:160001 of https://codereview.chromium.org/882223003/)

Reason for revert:
webGL conformance failures:

WebglConformance.conformance_textures_tex_image_and_sub_image_2d_with_video
WebglConformance.conformance_textures_texture_npot_video

https://codereview.chromium.org/892773003/
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/29272

Original issue's description:
> Move npot resizing out of GrContext and simplify GrContext texture functions.
>
> Committed: https://skia.googlesource.com/skia/+/8a8100349105c8c6de39fcb34e47679da7a67f54

TBR=robertphillips@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/868233005

6bfef2df

Update SKP version · 6726e78c

skia.buildbots authored 10 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/875243006

6726e78c