• robertphillips's avatar
    Fix layer hoisting image filter corner cases · 478dd723
    robertphillips authored
    This CL fixes 5 bugs related to hoisting image filters:
    
    For image filters the src layer (the one prior to filtering) often needs to be
    smaller then the final layer. This requires the saveLayer's optional bounds
    to be stored (in SkLayerInfo.h and SkRecordDraw.cpp) and then used in
    compute_source_rect and carried around in GrCachedLayer.
    
    The image filters can add an extra offset to the final draw operation.
    This is now computed in GrLayerHoister::FilterLayer and  carried around in
    GrCachedLayer.
    
    Filtered layers must use exact matches. This is now done in GrLayerCache::lock.
    
    The filter cache requires a valid matrix so it can compute the correct offset.
    This is now done in GrLayerHoister::FilterLayer.
    
    Filtered layers need to be drawn with drawSprite while unfiltered (and therefore
    hopefully atlased) layers can be drawn with drawBitmap. This is now done in
    draw_replacement_bitmap.
    
    Committed: https://skia.googlesource.com/skia/+/702eb9622102599d94ab6798e6227cf29f48c2d3
    
    Review URL: https://codereview.chromium.org/803183003
    478dd723
GrLayerHoister.h 5.36 KB