GitLab

memory allocated in readKeymasterBlob() was not freed.
The memory leak happens when the clientId
and appData for getKeyCharacteristics() or exportKey() is non-null.

Change-Id: Ie0340e122bf25a2385175892e5ff8535cca8710a
Signed-off-by: Bin Chen <pierr.chen@gmail.com>

Change-Id: I25427aba88baa1ae3cf9b99813a7f9fb8c70b052
Signed-off-by: Bin Chen <pierr.chen@gmail.com>

The open/write/close/rename pattern can result in
zero-length files on some file systems if crash or power
loss occurs. Prefer open/write/fsync/close/rename.

BUG: https://code.google.com/p/android/issues/detail?id=207607
Change-Id: I2742c3ab967d5cf254b22cffb5164881315623d5

am: 9c6612e2

Change-Id: Ic137fde859285c3a693b3e4b7642900d2ff34ada

According to Google coding style, no VLA since
it is not part of c++ standard and could blow up
the stack.

Change-Id: Ie79b56cd9a02ecebba76d88af727c6accbcfd45c
Signed-off-by: Bin Chen <pierr.chen@gmail.com>

am: 4f987e61

Change-Id: I18dfe082b23f37795503185fd40521ea35b4d3a9

* Use const reference type for parameters, local variables,
  and for-loop index variables to avoid unnecessary copy.

Bug: 30407689
Bug: 30413223
Bug: 30413862
Change-Id: I3b9383f34e466ca6b5290bad802d535443fd0187
Test: build with WITH_TIDY=1

am: 590a1dad

Change-Id: Ie0f3f1be4ee7ba9fbe249b951b452642c505895a

Declare explicit conversion constructors.

Bug: 28341362
Change-Id: Ibd0d6b7ec63ccb8f910e9da15771ff4d0031f4c4
Test: build with clang-tidy

am: 4ca5d689

* commit '4ca5d689':
  Fix misc-macro-parentheses warnings.

Change-Id: Ib57ef065e1471cc0ed84355827f66a643c2f259f

am: 8f8ed7f3

* commit '8f8ed7f3':
  Fix misc-macro-parentheses warnings.

Change-Id: I16a1cd31d9558f5f35c3ccf34b49cd4af43f69b9

Add parentheses around macro arguments used beside binary operators.

Bug: 28705665
Change-Id: I4ea2db63c18e40dabc10d42bfa5c936a71d6c628

am: e44c3373

* commit 'e44c3373':
  Fix google-explicit-constructor warnings.

Change-Id: I4f11b3d5dd790e7dbd1aad1ffe896aff26781afa

am: e2184060

* commit 'e2184060':
  Fix google-explicit-constructor warnings.

Change-Id: Ic2ac1a5556d2fc746e1b50b11936d9a536783ae0

Bug: 28341362
Change-Id: I116d2667550eec7a080bd5fcf073a8e7206c7c53

am: 1140ef67

* commit '1140ef67':
  Move keystore to foreground cpuset.

Change-Id: I7729240d6f98e9c76e0845c272de639339ea09ce

Bug: 24949295
Change-Id: Iaade68c5216d0efabdfdec4ff2b61d778d319324

am: c5e91c2e

* commit 'c5e91c2e':
  Remove RSA_FLAG_EXT_PKEY from android_engine.cpp.

Change-Id: Ia232e2ce912486f5810bf025fff44cad8974c05a

am: 193059de

* commit '193059de':
  Remove RSA_FLAG_EXT_PKEY from android_engine.cpp.

Change-Id: Ic302ba70c7ab6e8536d5552ae35d7fe511c87c18

Change-Id: I8c3344ad03202f8ce2a8985b135dfcd53d9a6524

am: 52e5773e

* commit '52e5773e':
  Export libbinder headers from libkeystore_binder

Change-Id: I48a9827528d1c950e9497dda9e383a3804a564a6

libkeystore_binder's headers include libbinder headers and consumers
of those headers will require libbinder's include paths as well.

Bug: 27804373
Test: This compiles with a modified libbinder include path.

Change-Id: Id8aef2c91fe118d413115c204b2c81c559ad4134

am: 98c5916d

* commit '98c5916d':
  Implement key upgrade in keystore.

Change-Id: Iccddbb5b6432b9dc3618e01c91ec290f53e0c1e1

am: 814a6e72

* commit '814a6e72':
  Configure keymaster with OS version info.

Change-Id: Ib6c0cbfe1cad9616185221da613c82fcee6e6334

Change-Id: I0cf169d9366aee1de32f1cc4501af76e6e1bc505

Change-Id: Ia09591dbea04ff5d45370b47341efa5bf34604ce

RSA_FLAG_EXT_PKEY, despite the name, is only about calling the RSA_METHOD's
mod_exp hook while reusing the rest of the RSA_private_transform logic. This
code doesn't provide mod_exp and instead overrides private_transform, so the
flag is a no-op.

am: 47d26164

* commit '47d26164':
  Fix AuthTokenTable tests.

The local unit test bit-rotted.  This fixes it.

Change-Id: I37c8dbd894b69f3a48aefdd4f71339c45d571f6b

am: 0348d006

* commit '0348d006':
  keystore_cli_v2: Update AES parameters

Set padding mode to PAD_NONE for AES when using
non GCM block ciphers.

BUG=27555165

Change-Id: I11cd860a9aee01aea1699ef149bde4af5cfa746e
Signed-off-by: Sourabh Banerjee <sbanerje@codeaurora.org>