1. 16 May, 2016 2 commits
    • Lorenzo Colitti's avatar
      Make FirewallController::createChain use replaceUidChain. · a55388e3
      Lorenzo Colitti authored
      This has two benefits:
      
      1. It makes the behaviour of setting firewall chains via the
         firewallReplaceUidChain RPC match the behaviour of creating
         the chains on boot. (As a side effect, it reduces code
         duplication between the two.)
      2. It makes creating firewall chains on boot use iptables-restore,
         which is substantially faster than running iptables commands
         one at a time.
      
      This CL will allow the framework to switch to using
      firewallReplaceUidChain when the framework starts, providing
      substantial speedups over the current behaviour of running two
      iptables commands for every app that is whitelisted or idle.
      
      Bug: 26675191
      Change-Id: Ifbd15bf9143efd526570dde8f88effc79d164630
      a55388e3
    • Lorenzo Colitti's avatar
      Make firewallReplaceUidChain match the behaviour of createChain. · f157caf3
      Lorenzo Colitti authored
      The behaviour of the firewallReplaceUidChain was incorrect in
      several ways:
      
      1. It was missing the "always allow TCP RST packets" rules which
         were added in http://ag/963000 .
      2. It included a RETURN statement at the end of blacklist chains,
         which is superfluous since all user-defined chains implicitly
         return, and became incorrect when http://ag/963000 switched the
         behaviour of blacklist chains from inserting new rules at the
         beginning to appending them at the end.
      3. It was missing the rules to allow the types of ICMPv6 packets
         that are critical in maintaining connectivity.
      
      By itself, this change is a no-op since nothing currently calls
      firewallReplaceUidRule.
      
      Bug: 26675191
      Change-Id: I985e6861812908cbe7eaf0f54ca0ad39c22bbfeb
      f157caf3
  2. 26 Apr, 2016 1 commit
  3. 02 Mar, 2016 1 commit