Commit 65359032 authored by Selim Gurun's avatar Selim Gurun Committed by Android (Google) Code Review
Browse files

Merge "We are not reverting this CL since it was a temporary fix and we just...

Merge "We are not reverting this CL since it was a temporary fix and we just submitted the proper one."
parents 00a7f626 40e0c13d
......@@ -76,9 +76,7 @@ void DnsProxyListener::GetAddrInfoHandler::run() {
uint32_t rv = getaddrinfo(mHost, mService, mHints, &result);
if (rv) {
// getaddrinfo failed
// TODO This is temporary. We think there is another bug exposed when we send data here, so
// temporarily setting it to 0.
mClient->sendBinaryMsg(ResponseCode::DnsProxyOperationFailed, &rv, 0);
mClient->sendBinaryMsg(ResponseCode::DnsProxyOperationFailed, &rv, sizeof(rv));
} else {
bool success = !mClient->sendCode(ResponseCode::DnsProxyQueryResult);
struct addrinfo* ai = result;
......@@ -252,11 +250,9 @@ void DnsProxyListener::GetHostByAddrHandler::run() {
hp->h_name ? hp->h_name : "",
hp->h_name ? strlen(hp->h_name)+ 1 : 0);
} else {
// TODO This is temporary. We think there is another bug exposed when we send data here, so
// temporarily setting it to 0.
uint32_t error = h_errno;
failed = mClient->sendBinaryMsg(ResponseCode::DnsProxyOperationFailed,
&error, 0);
&error, sizeof(error));
}
if (failed) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment