Skip to content

GitLab

Switch branch/tag
  1. 02 May, 2014 1 commit
    • Mark Salyzyn's avatar
      libcutils: turn on -Werror · 12717169
      Mark Salyzyn authored 
      - Deal with some -Wunused / -Wunused-variable issues

Change-Id: I28c23fb213382a392ec30935749fb359e072d664
      12717169
  3. 03 Apr, 2014 1 commit
    • Jens Gulin's avatar
      Handle errno properly to avoid corrupt str_parms · d3c8d5b8
      Jens Gulin authored 
      A normal sequence of calls is as follows:
str_parms_create_str, str_parms_add_str, str_parms_destroy.
In some cases the destroy caused double free.

str_parms_add_str will clone the input and send it to hashmapPut
for storage. If hashmapPut did not store the strings it will raise
errno = ENOMEM and leave caller with ownership of the strings.
In any of these cases it will be safe to destroy the str_parms.

But what if it wasn't hashmapPut that said NOMEM? What if there
was a stale NOMEM already before a successful hashmapPut?
In that case the strings will be successfully added to the list
(if new), but when str_parms_add_str sees the NOMEM it will free
them anyway, leaving dangling pointers in the str_parms!!

It is the responsibility of the caller to clear errno before any
interesting call. This patch makes sure that str_parms_add_str
reacts only on errno emmitted from hashmapPut.

Change-Id: If87e4bcc482f09e1c66133d33517b152ebdac65f
      d3c8d5b8
  5. 25 Mar, 2014 1 commit
  7. 27 Jan, 2014 2 commits
  9. 05 Dec, 2013 2 commits
  11. 15 Mar, 2012 2 commits
  13. 12 Mar, 2012 2 commits
  15. 17 Jan, 2012 2 commits
  17. 04 Jan, 2012 1 commit
  19. 26 Oct, 2011 1 commit
  21. 18 Jun, 2011 1 commit
  23. 21 Apr, 2011 1 commit