Skip to content

GitLab

Switch branch/tag
  1. 11 Nov, 2015 1 commit
  3. 10 Nov, 2015 1 commit
  5. 12 Sep, 2015 2 commits
  7. 11 Sep, 2015 1 commit
  9. 10 Sep, 2015 2 commits
  11. 09 Sep, 2015 2 commits
    • Narayan Kamath's avatar
      libutils: Fix integer overflows in VectorImpl. · 419e6c3c
      Narayan Kamath authored 
      Use external/safe-iop to check for overflows on arithmetic
operations.

Also remove an unnecessary copy of Vector/SharedBuffer from
codeflinger and use the copy from libutils instead.

Note that some of the unit tests are somewhat useless due to
test-runner limitations : gtest's ability to filter on abort message
doesn't work when combined with messages formatted by android's logging
system.

bug: 22953624

(cherry picked from commit c609c31f)

Change-Id: I61644633db6b54fa230683615de9724f7fabf6fb
      419e6c3c
    • Narayan Kamath's avatar
      libutils: Fix integer overflows in VectorImpl. DO NOT MERGE · b638126e
      Narayan Kamath authored 
      Use external/safe-iop to check for overflows on arithmetic
operations.

Also remove an unnecessary copy of Vector/SharedBuffer from
codeflinger and use the copy from libutils instead.

Note that some of the unit tests are somewhat useless due to
test-runner limitations : gtest's ability to filter on abort message
doesn't work when combined with messages formatted by android's logging
system.

bug: 22953624

(cherry picked from commit c609c31f)

Change-Id: I673b7ab142bed4fcba9159a00a65cf6bca6b1f6c
      b638126e
  13. 25 Aug, 2015 3 commits
  15. 21 Aug, 2015 4 commits
  17. 20 Aug, 2015 2 commits
  19. 18 Aug, 2015 1 commit
  21. 27 May, 2015 3 commits
  23. 03 Nov, 2014 2 commits
  25. 24 Oct, 2014 2 commits
  27. 21 Oct, 2014 1 commit
  29. 20 Oct, 2014 1 commit
    • Adam Lesinski's avatar
      MingW doesn't handle __attribute__((weak)) for Windows PE · a1ac84cd
      Adam Lesinski authored 
      Windows PE format doesn't have the same support for weak symbols
as ELF does.

The symbol android_log_id_to_name was strangely omitted from the
resulting Windows executable and the callsite where it was supposed
to be called was relaced with a different symbol, which caused a crash
in AAPT on Windows.

This change works due to a careful set of #ifdefs that ensure only one
definition of android_log_id_to_name is defined, but there are other
uses of __attribute__((weak)) which should be inspected.

Change-Id: I3b58076e31d9b28c5143773a170e9ffda9fa3815
      a1ac84cd
  31. 16 Oct, 2014 3 commits
    • Xavier Ducrohet's avatar
      Merge "Fix windows specific behavior of FileMap" into lmp-dev · 1c77bf4c
      Xavier Ducrohet authored
      1c77bf4c
    • Xavier Ducrohet's avatar
      Fix windows specific behavior of FileMap · 1a55aa5e
      Xavier Ducrohet authored 
      The implementation of the FileMap destructor would
close the file, only on Windows, which did not match
the behavior on mac/linux.

This is because calling munmap does not close the file
descriptor. It must be closed separately, before or after
munmap.

On Windows, the file must also be closed manually,
before or after closing the mappingFile.

The change basically removes the closing file from
the windows-specific part of the destructor, to
make behavior more consistent on all platforms
where the caller to FileMap is responsible for closing
its own file (since FileMap receives an opened file).

Change-Id: I5e3cfffbb870d5f3595802ccac57dbc1dbf1ce6e
      1a55aa5e
    • Xavier Ducrohet's avatar
      Fix toolchain issue for windows build of libziparchive. · cd1da4e0
      Xavier Ducrohet authored 
      With mingw 4.8, the new default packed behavior is broken and makes
zip archive fails due to unexpected misalignment in
CentralDirectoryRecord.

This patch uses -mno-ms-bitfields to revert to the old packed
behavior.

Change-Id: Ic977c841e330e19451db1d31ddb22e570a525062
      cd1da4e0
  33. 15 Oct, 2014 1 commit
  35. 14 Oct, 2014 1 commit
    • Dianne Hackborn's avatar
      Maybe fix issue #17969789: Shamu FR: Runtime restart while scrolling Instagram · 2c5e7e10
      Dianne Hackborn authored 
      It looks like there were a couple problems in the code:

- It would not 0-terminate the string it read, to make sure we didn't
  see garbage at the end.
- It didn't reduce buf_len as it processes data in the buffer, so if
  we need to read more we will increase the buffer length to be longer
  than the actual available data.

Also put in some logs about every thing we kill, so we can see what
is going on when debugging.  And add a special check for us trying
to kill pid 0 for any reason, since doing so seem to be terminal to
the caller.

Change-Id: I2fe29bfef08938b8a2eb182475c0705c14d8d84f
      2c5e7e10
  37. 10 Oct, 2014 1 commit
  39. 07 Oct, 2014 4 commits
  41. 06 Oct, 2014 1 commit
  43. 02 Oct, 2014 1 commit