GitLab

Use Case:
Pair and unpair LE remote device repeatedly. The repair
intermittently fails with the error "DHKey Check Failure"

Failure:
Pairing failure is observed when pairing is performed
after unpairing, without performing a BT reset.
Further analysis of the SMP logs indicate that DUT uses the
static address of the remote device for calculation of the
MacKey value. At the time of pairing, the remote RPA should
be used (and the static address has not yet been distributed either).
The problem is caused by the previous dev record which is left in
the stack, and at the time of repair, stack picks the old device
record and reuses it.

Fix:
This change removes the entire BLE block from the device record,
after the unpairing is performed, so that a new device record
is allocated, after the repairing is done.

Bug: 27852645
Change-Id: I8d605d1bb3b1c32061a8d8a7a7fe0fe200030abc

uhid_event() returns 0 in the normal case. Commit 3a2c2d61
results in the polling thread to be exited.

Bug: 28942565
Change-Id: Id0aff2958bc7c2704ba340aa0ff7848afb8dcf80

Bug: 28614494
Change-Id: I3f4a923f9e14faef57b2d694bfc253fd10749414
(cherry picked from commit 74963722)

Fixes: 28979841
Change-Id: I520608a13224601fb9101d00c08b34cdb0f8d374

Bug: 28849621
Change-Id: I3ce1c857d0d0a2c00c59d8f71b40685ae602dc29
(cherry picked from commit 1f9eb3d6)

Add fsync() calls to force sync to disk while saving configuration
file.  It is necessary to do a sync on the temp file before rename,
and to sync again on its parent directory to ensure both the
file content and the directory are up-to-date.

Bug: 27354612

Change-Id: I3a862ad59c8ae5beb8ea2c727eb5f275a2d5823e
(cherry picked from commit 95dbe03a)

- Calculate number of SBC frames to fit into single MTU for EDR capable
  remote devices. This makes sure the maximum utilization of the
  available bandwidth, keeping the bitrate at high quality.
- This change helps to address the discrepancy seen with a few available
  2 Mbps headsets which set the AVDTP media MTU size greater than the
  2DH5 packet payload size which eventually forces AVDTP packets to get
  fragmented in the controller. This change ensures packing of the SBC
  frames in a way that AVDTP packet size fits within the 2DH5 payload
  size.
- As packet size is restricted to meet the required bit rate more than
  one AVDTP packet can be sent to the controller in a given iteration
  based on the bit rate requirement.

Bug: 24875861
Change-Id: Icae7656ad563bbbdef65ecbfa15a89b26cf9edb2

Merge "Add guest mode functionality (2/3)" into mnc-dev am: 4439d380 am: 99bbe2ff  -s ours am: 34619f8e
am: 84970d13

* commit '84970d13':
  Add guest mode functionality (2/3)

Change-Id: I8e26f8bb0fa6898427507dfc888dfb6fd743fcac

am: 34619f8e

* commit '34619f8e':
  Add guest mode functionality (2/3)

Change-Id: I00a7ad9675ba8e3f68e2066aca2fd1a5baaf06db

am: 99bbe2ff  -s ours

* commit '99bbe2ff':
  Add guest mode functionality (2/3)

Change-Id: Ie493166a8d452f2892bb96323b23527efe053dd7

am: 4439d380

* commit '4439d380':
  Add guest mode functionality (2/3)

Change-Id: Ia13560babbc18e2ee290e16f9b03fb5202894c23

Instead of crashing whole stack when trying to post task to
uninitialized queue, log error message. This can happen in two cases:
stack is not initialized yet, or we're shutting down and already cleaned
up the workqueue thread.

Bug: 28889608
Change-Id: I9b8652d27abc2489b2489997c928634b68433a3e

Bug: 28721625
Change-Id: I2214fb2576f0f0794922ed9b47d8805839d69bfd

 * Better error handling and log messages inside
   uipc_flush_ch_locked()
 * Add missing error check inside UIPC_Read()
 * Add missing OSI_NO_INTR() wrapper around poll()
   inside function btu_exec_tap_fd_read()

Bug: 28823662
Change-Id: I5f1c720861bea594d53ed6465a5ff327ba352598

Bug: 28823662
Change-Id: Ifa9950dd2277b444bedd5108beff2db029a5ed93

Increase the BTSNOOZ log buffer to 256kb and adds complete L2CAP
signaling headers as well as more data per ACL data packet. This will
allow additional RFCOMM debugging.

Fixes: 28845518
Change-Id: I19e1a4a40bb1c8d332a25283fb50635d791bc275

Added a log message inside l2c_link_hci_disc_comp() to help capture
a NULL pointer p_lcb->p_fixed_ccbs[xx] that triggers SIGSEGV crash.
Also, updated the typedef of bdstr_t and moved it to
file "btcore/include/bdaddr.h"

Bug: 28765514
Change-Id: Iacd9376cfb9e18b58e18865581da8edad9f68821

DO NOT MERGE ANYWHERE Restart failed system calls interrupted with errno of EINTR am: f9a4d9e8  -s ours
am: 529f7e35  -s ours

* commit '529f7e35':
  DO NOT MERGE ANYWHERE Restart failed system calls interrupted with errno of EINTR

Change-Id: I79ab95e5cd139dc99183f398bec5fe5ca2fbd38c

am: f9a4d9e8  -s ours

* commit 'f9a4d9e8':
  DO NOT MERGE ANYWHERE Restart failed system calls interrupted with errno of EINTR

Change-Id: I982345259966a2d7108a6a9699b3f71cb6d2e26f

In number of places we don't handle properly system calls failures
when the errno is EINTR (i.e., the system call was interrupted
by a signal). In all our use cases, the system calls should be
restarted. The handling of the following system calls (as used in the code)
has been updated/fixed:

  poll, send, recv, sendmsg, nanosleep, epoll_wait
  read - mostly (e.g., socket-like fds)
  write - mostly (e.g., socket-like fds)
  select, accept, connect

Bug: 28471477
Bug: 28658141
Change-Id: I03e6f0f67e33876780fb6d02c33eb84547ba8f95

Bug: 28769522
Change-Id: I37c2b8400619646a8711099cf0bd369c3cf8eb51

am: fae8da3f  -s ours

* commit 'fae8da3f':
  DO NOT MERGE btif: check overflow on create_pbuf size

Change-Id: I050ce836c311c54efab4f7e495f42901cd0a0d4e

am: 6f6949ff

* commit '6f6949ff':
  DO NOT MERGE btif: check overflow on create_pbuf size

Change-Id: I1ed5ea4b978e5f9b6628a5443a0acc3e61c297d7

am: d47ab963

* commit 'd47ab963':
  DO NOT MERGE btif: check overflow on create_pbuf size

Change-Id: I839427756e92067e8c54822988648a85e537cc27

am: ad31ee0f

* commit 'ad31ee0f':
  DO NOT MERGE btif: check overflow on create_pbuf size

Change-Id: I77748f8ce26e15cf87f53cf3a34a11ecc19471f5

Bug: 27354612
Change-Id: I5a7751b6f08831d43647391774501f211336e9eb

Bug: 28677905
Change-Id: I092494ab3f9e9ae4330d5d2a6f6ef010c61fe2a4

Bug: 27930580
Change-Id: Ieb1f23f9a8a937b21f7c5eca92da3b0b821400e6

The functions that parse the config file will report failure if
the config file is improperly formatted or is missing the necessary
Adapter section. Also moved sync to sync the filesystem after the
config file is saved.

Bug: 27354612
Change-Id: Ia75ff628d83bdc933c4bc16761d6c55eef19b757

Implement retry upon control socket receive error
in a2dp_ctrl_receive() if EAGAIN or EINTR.

Implement recovery from previous socket error in
a2dp_command().

Increase socket receive timeout to account for
headsets will long activation time.

Fixed state update error in start_audio_datapath()
in case the data socket is already opened.

Added missing mutex around state updated in oput_write()
and in_read()

Made read and write code symmetric.

Bug: 28727517
Change-Id: I68d7fe63f298bbd1e387ec42fdb1277b2dcdfef5

In number of places we don't handle properly system calls failures
when the errno is EINTR (i.e., the system call was interrupted
by a signal). In all our use cases, the system calls should be
restarted. The handling of the following system calls (as used in the code)
has been updated/fixed:

  poll, send, recv, sendmsg, nanosleep, epoll_wait
  read - mostly (e.g., socket-like fds)
  write - mostly (e.g., socket-like fds)
  select, accept, connect

Bug: 28471477
Bug: 28658141
Change-Id: I03e6f0f67e33876780fb6d02c33eb84547ba8f95

Bug: 27354612

Change-Id: I15f816c85d3ab1991abf076f7c1ae2914d773d54

am: 731684b2  -s ours

* commit '731684b2':
  DO NOT MERGE ANYWHERE SMP: Delay authorization complete.

Change-Id: I01ba378fc44a2e273ef2cd53787ddc6504de38b8

am: 8c519cae  -s ours

* commit '8c519cae':
  DO NOT MERGE ANYWHERE SMP: Delay authorization complete.

Change-Id: I1dbfbc0b3f5cddecd18f604f5d4d0271777ce02a

Delay authorization complete during Bond Pending state in SMP.
Instead of automatically advancing the Bond Pending state, create
a 500ms window to allow the slave to stop pairing by sending over
the Pairing Failed command during the Bond Pending state.

BUG: 28475887
Change-Id: I164e8312fdf9170d0f36caf404fc42e293ed5d79