GitLab

* Replaced usage of BTA_AV_CODEC_SBC and BTIF_AV_CODEC_SBC
  with A2D_MEDIA_CT_SBC
* Removed remaining unused BTA_AV_CODEC_* re-defines
* Removed other BTA_* constants and re-defines that are never used
* Removed unused BTIF_AV_ constants and typedefs

Change-Id: I38090acee3dfdcd1196185e0b060cdad7572003a

The p_sink_data_cback pointer should be NULL when registering
A2DP source with BTA_AvRegister()

Change-Id: I1a709c4e0d3cfe6faf0368a013b391c6e6a53a82

Currently, every task executed on bta thread needs a separate event id,
structure holding its parameters, API method, and method that will be
executed in bta thread, which must accept generic tBTA_DM_MSG.

Because of that we end up with lots of boilerplate code, and possibility
to misinterpret bytes in tBTA_DM_MSG struct.

After this patch, we can post closures onto bta thread. Thanks to it we
don't need a struct to hold parameters, and the executed method can have
a meaningful parameters.

First experiments showed over 50% reduction in code size when rewriting
advertising code to new style, not to mention much better readability.

Bug: 30622771
Change-Id: I400839b920c04c67c893899969d07a02d9c1b2e6

Change-Id: I794f07821a653f03e02cb5ad11790dfe2dfaea98

Remove the dependency on bluetooth_* flags.
Enable more warnings.

(Based on the build flags in system/bt/Android.mk)

Change-Id: I5f480f15c037955404502a0216b61aa407670163
Signed-off-by: Myles Watson <mylesgw@google.com>

Remove "/* args */" and use UNUSED_ATTR.  It's easier to find using grep.

Change-Id: Ic1a95e44b86d019647acafe982cfef5c69e1da1a
Signed-off-by: Myles Watson <mylesgw@google.com>

am: 3e0f253c

Change-Id: I4309954020a7630fa1dc4eca766fc12e982fbefc

Change-Id: I8b6f0664a96932c35a804541d54a50370d09c022

am: 7aaf7c6c

Change-Id: I2420388d1335ab2ff9edef957ed0934433e3e63e

* Renamed A2DP-related function names, types, constants and fields.
  Also, move some of those functions to a better location.
 - tAVDT_DATA_CBACK -> tAVDT_SINK_DATA_CBACK
 - tAVDT_MEDIA_CBACK -> tAVDT_SINK_MEDIA_CBACK
 - p_data_cback -> p_sink_data_cback
 - p_media_cback -> p_sink_media_cback
 - p_app_data_cback -> p_app_sink_data_cback
 - tBTA_AV_DATA_CBACK -> tBTA_AV_SINK_DATA_CBACK
 - BTA_AV_MEDIA_SINK_CFG_EVT -> BTA_AV_SINK_MEDIA_CFG_EVT
 - BTA_AV_MEDIA_DATA_EVT -> BTA_AV_SINK_MEDIA_DATA_EVT
 - bta_av_stream_data_cback() -> bta_av_sink_data_cback()
 - bte_av_media_callback() -> bte_av_sink_media_callback()
 - tBTA_AV_CODEC -> tA2D_CODEC
 - btif_a2dp_get_track_frequency() -> A2D_sbc_get_track_frequency()
 - btif_a2dp_get_track_channel_count() -> A2D_sbc_get_track_channel_count()
 - dump_codec_info() -> A2D_sbc_dump_codec_info()

* Misc. other cleanup:
  - log messages cleanup
  - normalize usage of "+=" in Android.mk files

Change-Id: Ida1528fb5d75cc322533f921daefb65be44562f1

am: a11e1c1b

Change-Id: Ie3494281cda35263f0b0a259eef045541aba3585

am: bde45bd6

Change-Id: I3e3775b77c304fa5d440fc841bb6c76efbe3ef89

Avoid duplicating header files for BT constants.

Update Android.mk to search $(BT_DIR)/include and
$(BOARD_BLUETOOTH_BDROID_BUILDCFG_INCLUDE_DIR)

Change-Id: I1403724c1cf9cda8156a5b65cf55da8178bd910f
Signed-off-by: Myles Watson <mylesgw@google.com>

Change-Id: Idf7063359600b30c007fbde89dde55ef987c0368

am: e80e75b4

Change-Id: I877e15663150975a102adf692e68e1d27cfc56b8

am: febb1515

Change-Id: Ifbaade2d4edb6792e328dc37ae21bd0ac5f24560

Renamed function dump_a2dp_ctrl_event() to
audio_a2dp_hw_dump_ctrl_event() and expose it, so it can be used
by outside code to print events.

Change-Id: Ibd9d3171c7d5256f80101ecc1563b472b7f5e92d

* Function BTA_AvEnable_Sink() - never used
  - Event BTA_AV_API_SINK_ENABLE_EVT
  - Processing function bta_av_api_sink_enable()
  - AVDT_SINK_Activate() and AVDT_SINK_Deactivate() : not used anymore

* A2DP SINK related functions that are only declared:
  - btif_queue_focus_request()
  - audio_focus_status()

* Audio-related function that is never used:
  - bta_av_sbc_cfg_for_cap()

* Video-related functions that are only declared:
  - bta_av_co_video_src_data_path()
  - bta_av_co_video_setconfig()
  - bta_av_co_video_open()
  - bta_av_co_video_close()
  - bta_av_co_video_start()
  - bta_av_co_video_report_conn()
  - bta_av_co_video_report_rr()
  - bta_av_co_video_delay()
  - bta_av_co_video_disc_res()
  - bta_av_co_video_getconfig()
  - bta_av_co_video_stop()

Change-Id: I0c0c80578ab2675d2fe23dea3f11b2a0d82283f0

am: d3e8a458

Change-Id: I0c8c22beb6c899cf97ccd87744c8fb27964d0f32

am: 2637d3cd

Change-Id: Icb7fbbe31234c26efb21166b3ed91e03b07177fd

am: 3335cf4e

Change-Id: I69e145c2e2c4afda6ab0c16c5cf3c9e097b8a8e7

Change-Id: Ic90e3ffdcaea9573b135bd26ef102a1740fb2d3d

Also, re-implement existing function time_get_os_boottime_ms()
by using the new function time_get_os_boottime_us()

Change-Id: I5c6ba3d04b04c96e0a415b2be1050ef05cb04585

am: d4f80ae7

Change-Id: I646c3271fc61d656908c5c75d609e7bd2b7c3265

This reverts commit 10986700.
Which reverted commit 1387d433.

Some minor style changes as well.

Change-Id: I83ea40b4cf96adfa58c24d0cd9109ed9974519f1

Test: TestTracker/58842/5473
Bug: 30571638
Change-Id: I3bb1a0171e220b6e59b6b739259f98519a31aa27
(cherry picked from commit 3282d12818a0e660a5f3f4295bac55aa8e8d27b4)

am: b8b761e7  -s ours

Change-Id: Ieae60a1a48dac361e5efb9acfd9f549d620ece57

This reverts commit 2ed10d442266eade44be121cd24fd473c85007d0.

Original change needs to be reverted to align with Errata
ESR04 where "Section 8.17, General Reject Page 71" of adopted
AvDTP Spec is changed to have "Invalid Signal Identifier"
in first 6 bits of Octet 1.
This change helps passing PTS case TP/SIG/SMG/ESR04/BI-28-C

Bug: 27852645
Change-Id: I9deba6821284f0cb1423d543550786cc76a61a33
(cherry picked from commit 825cd498)

am: b2bbe93c

Change-Id: I621620b800f0bec0df0ec0b07bc4beb384482de3

Change-Id: I4107b3b50345f81833c47c85c4a322a582973bb2

am: 10986700

Change-Id: I3b8264f5b4124dda166cafdce61ac0c941e18710

This reverts commit 1387d433.

Change-Id: I4af4e0d5ac5a108f3de44d186db97592a70c729e

am: 1387d433

Change-Id: I4ccdc7e14b81e2bdc7862764b49f4d2dd4044d04

Change-Id: I8d31f766722e4b4a6c6fe00e30a957ac43176cf1