GitLab

Only some vendor operations use vendor_manager_.  Move the checks into
the operations that use it.

Change-Id: I8bb23d740c94df7e2081c29b1d9e062c5c012714

Change-Id: I79ac76e64e836551cfd555a7b9786d254fcbc07a

Change-Id: I83358cbb68b10e80e4e553a6657fcb38cfcb928f
Signed-off-by: Myles Watson <mylesgw@google.com>

Change-Id: I229f2a4f93a9219a502960e6d91f514738f3b3c8
Signed-off-by: Myles Watson <mylesgw@google.com>

It should be safe to include C header files without
using extern.

Change-Id: I2b562ef3f76df9f9dac69323345ed3d3610e8bc2
Signed-off-by: Myles Watson <mylesgw@google.com>

This patch moves btm_ble_adv_raddr_timer_timeout into same file that use
it. It also moves all structures related to multi-advertising into only
source file that uses them, to make sure noone uses them externally
while they undergo further refactoring.

Bug: 30622771
Change-Id: I721d222aa8f5317620c616cc59ee04b7b28a68b3

Use AsyncManager to implement a timer tick and an event queue.

Change-Id: Iec2a0ef06f17ecce0652ecc52f5ef732fc4af026
Signed-off-by: Myles Watson <mylesgw@google.com>

Change-Id: I429ea832f32cb4c67525dda71f9e05ba60110e1e

Change-Id: Ia80cb82c833df341f832d2ab8cc71a868e2c8f5e
(cherry picked from commit a1e4dd95)

The test channel can always be enabled when using the AsyncManager.
 - Remove enabled_ and port_
 - Allow multiple connections
 - Pass file descriptors as parameters instead of private variables
 - Add a clean up function to the Test Channel
 - Add a static class in bt_vendor.cc and always EXPORT the entry point
 - Move the vendor callbacks and the global pointer to the vendor
   manager object from vendor_manager to bt_vendor

Change-Id: I3e0dee846eb89f434893603a705c2b13219272be
Signed-off-by: Myles Watson <mylesgw@google.com>
Signed-off-by: Jorge E. Moreira <jemoreira@google.com>

A typo in a conditional had us treating LEN_UUID_32 as
an unknown length in this function.

Change-Id: Iec0190fd70859d9b72295e91798af5fdc4dfae93

Bug: 29111689
Change-Id: I5b57da9e08dea372e9b236b360ffeeae4f6b49af

-> As a part of Avrcp 1.6 upgrade, added support
   for following features:
   [1] setAddressedPlayer
   [2] setBrowsedPlayer
   [3] getFolderItems scope=VFS/NowPlaying/Search
   [4] changePath
   [5] getItemAttributes
   [6] playItem
   [7] getTotalNumberOfItems
   [8] search string in current browsed path.
   [9] AddToNowPlaying
-> Defined functions and enhanced structures to
   support above mentioned features.
-> Added Dual RC support.

Bug: 19361366
Merged-In: I45ed60e337b57c686d9693e19993fee1ce3c2504
Change-Id: I45ed60e337b57c686d9693e19993fee1ce3c2504

Change-Id: I23d27a1a5c258de330f4eac23d314ef8b9200d2a
Signed-off-by: Myles Watson <mylesgw@google.com>

The class provides IsValidBtAddress(string), functions to convert
from vectors and strings, and some operators.

Change-Id: I553c47e698ec46ed0e24656f89141c23f7369380
Signed-off-by: Myles Watson <mylesgw@google.com>

Advertising is so simple, it doesn't need the BTA layer.
Values returned by BTM_VendorSpecificCommand shouldn't be handled as
success or failure, it's just to inform wether we sent the callback.

Bug: 30622771
Change-Id: I104c4fbf84d3818b76fe8c527fbde4e6c4336c3a

Up till now, we had three numbers associated with each advertising
instance: client_id, inst_id, and cbindex. We also had special structure
mapping each of those numbers to another.

From now on, when registering advertiser, we'll grab next free
advertising instance id and make advertiser_id equal to it. Thanks to
this, we can remove all the mapping and have just one number associated
with each advertising instance.

This also means we no longer need to pass *p_ref value to the BTM layer
with each request, as advertiser_id is equal to inst_id.

Bug: 30622771
Change-Id: Ied71bff36e30d6c6ce4ca3e62d46ba96320cf597

* Removed unused defines and function declarations
* Removed unused tBTA_AV_Q_INFO.vdp
* Cleanup of some of the log messages

Also:
* Added constant AVDT_TSEP_INVALID instead of using a hard-coded value

Change-Id: I9ce7b5b08dec7c9ea9699d9f6c598acb39fb105a

Those APIs can be used to check various codec-related characterictics,
and minimize the codec-specific knowledge in the rest of the code.

The added APIs are:
 - A2D_GetCodecType()
 - A2D_IsCodecSupported()
 - A2D_UsesRtpHeader()
 - A2D_IsVendorCodecSupported()
 - A2D_VendorCodecGetVendorId()
 - A2D_VendorCodecGetCodecId()
 - A2D_VendorUsesRtpHeader()

Also:
 - Added unit tests for the new API calls
 - Removed redundant definition of BTA_AV_CODEC_TYPE_IDX
 - Removed unused A2D_MEDIA_CT_* codec type defines

Bug: 30958229
Change-Id: Id9ab01fd93b0b0a9b55a0af9bfb482310ae0ade4

Bug: 30622771
Change-Id: I761f0bff09aec1047bd512915960021e4fbdc0c8

This patch is a preparation to get rid of BTA layer for advertising, and
for further refactoring required to keep this code maintainable.

Tests: SL4A/ConcurrentBleAdvertisingTest
Bug: 30622771
Change-Id: I574b57159390d090b16d264d3c1fba2f07b70d4c

* Removed field tBTIF_MEDIA_CB.av_sm_hdl, because it is never used
  after an assignment.
* Removed the corresponding function btif_av_get_sm_handle() which
  is not used/needed anymore.
* Declared btif_hf_is_call_idle() function in a new header file
  "btif_hf.h"
* Removed tBTIF_STATUS, BTIF_SUCCESS and BTIF_ERROR_SRV_* error codes
  which are never used.
* Removed duplicate conditional define of BTA_AV_CO_CP_SCMS_T
* Removed unused typedef tBTA_AV_AUDIO_CODEC_INFO, and unused
  BTA_AV_CO_* defines and enums.

Change-Id: I7bb49957fad94073d474fea6ea0d466f36df37fb

Change-Id: Iccec195d35b5a62d7b45834670229a68deeb4add

Bug: 27602473
Change-Id: I4b0f1563952be75a6dee238607e6674ce98ea623

Bug: 29601962
Change-Id: Ibcccbe20a4b7c79edcaff162e4f4a19078ffb75d
(cherry picked from commit ffdb33b5)

* Replaced usage of BTA_AV_CODEC_SBC and BTIF_AV_CODEC_SBC
  with A2D_MEDIA_CT_SBC
* Removed remaining unused BTA_AV_CODEC_* re-defines
* Removed other BTA_* constants and re-defines that are never used
* Removed unused BTIF_AV_ constants and typedefs

Change-Id: I38090acee3dfdcd1196185e0b060cdad7572003a

The p_sink_data_cback pointer should be NULL when registering
A2DP source with BTA_AvRegister()

Change-Id: I1a709c4e0d3cfe6faf0368a013b391c6e6a53a82

Currently, every task executed on bta thread needs a separate event id,
structure holding its parameters, API method, and method that will be
executed in bta thread, which must accept generic tBTA_DM_MSG.

Because of that we end up with lots of boilerplate code, and possibility
to misinterpret bytes in tBTA_DM_MSG struct.

After this patch, we can post closures onto bta thread. Thanks to it we
don't need a struct to hold parameters, and the executed method can have
a meaningful parameters.

First experiments showed over 50% reduction in code size when rewriting
advertising code to new style, not to mention much better readability.

Bug: 30622771
Change-Id: I400839b920c04c67c893899969d07a02d9c1b2e6

Change-Id: I794f07821a653f03e02cb5ad11790dfe2dfaea98

Remove the dependency on bluetooth_* flags.
Enable more warnings.

(Based on the build flags in system/bt/Android.mk)

Change-Id: I5f480f15c037955404502a0216b61aa407670163
Signed-off-by: Myles Watson <mylesgw@google.com>

Remove "/* args */" and use UNUSED_ATTR.  It's easier to find using grep.

Change-Id: Ic1a95e44b86d019647acafe982cfef5c69e1da1a
Signed-off-by: Myles Watson <mylesgw@google.com>