Skip to content

GitLab

Switch branch/tag
  1. 07 Dec, 2016 1 commit
    • Tyler Gunn's avatar
      Catch SIP exceptions which can crash Phone process on answer. · 8696a16c
      Tyler Gunn authored 
      There are two exceptions which can be raised when answering a call which
can cause the Phone process to crash on answer.
1. IllegalStateException due to answering a call with an incompatible
codec.
2. IllegalArgumentException due to answering a call with a malformed
SDP.
In both of these cases we catch the exception and reject the call to stop
it from ringing (otherwise it will keep ringing and the user will not be
able to stop it).

The existing CallStateException does not require onReject to be called as
it is thrown when the call has already been disconnected before it can be
answered.
Test: Manual (see bug)
Bug: 31752213
Change-Id: I5254fd3a27b86fdc70889ea0a2b5be3b699fd9f5

(cherry picked from commit e3b4afc616fbca63235691d81214a9f6f45c25a2)
      8696a16c
  3. 03 Nov, 2016 2 commits
  5. 22 Jul, 2016 1 commit
    • Brad Ebinger's avatar
      Make TTY broadcasts protected · c76129b0
      Brad Ebinger authored 
      Currently, any app can broadcast the intent to update the TTY mode. This
change updates the intents to protected broadcasts so that only system
can broadcast them. Otherwise, a SecurityException will be thown.

Bug: 29832693
Change-Id: Ic9a91be3d8d15043e3165b766348cff301dd5da1
      c76129b0
  7. 22 Apr, 2016 1 commit
    • Brad Ebinger's avatar
      DO NOT MERGE Use E PhoneAccount for MT ECM Call · 1e2e90f8
      Brad Ebinger authored 
      Use the correct Emergency PhoneAccount for a MT call on a phone with no
SIM that is in ECM. Also, reject incoming SIP calls that are received on
a disabled PhoneAccount instead of crashing the Phone process.

Bug: 27820226
Change-Id: I79aa1eb9d07760a6d31d97ec2e2cd3c430a43215
      1e2e90f8
  9. 27 Feb, 2016 1 commit
    • Brad Ebinger's avatar
      Fixes creation of incorrect SIP PhoneAccountHandle · d2e1ace4
      Brad Ebinger authored 
      When a new incoming call occurs in SIP, SipUtil mistakenly uses the
Uri handle instead of the profile name to create the
PhoneAccountHandle. Since this PhoneAccountHandle is not registered
with telecom, it will throw a security exception (as of b/26864502).

BUG: 26874216
Change-Id: I27611b45f0834fca328c4cc2b867edaf970f7171
      d2e1ace4
  11. 06 Nov, 2015 1 commit
  13. 02 Nov, 2015 1 commit
    • Tyler Gunn's avatar
      Ensure connection extras are propagated on start of call. · 092d26aa
      Tyler Gunn authored 
      When a new call is created in Telephony, there is a potential for the
connection extras to not be passed up through to Telecom if the RIL
does not call the onExtrasChanged callback.  If the connections were set
on the original connection but never changed, then it is conceivable that
we may never see an onExtrasChanged callback and hence never propagate
the extras up.

Bug: 24585039
Change-Id: Ic1da1998a25afb6d380fda81bba591846a02dda7
      092d26aa
  15. 28 Oct, 2015 1 commit
  17. 26 Oct, 2015 2 commits
  19. 20 Oct, 2015 1 commit
    • Santos Cordon's avatar
      Prevent DISCONNECTED unknown connections. · fff1c1dc
      Santos Cordon authored 
      1) Add an early return to disallow disconnected unknown connections.
2) Move code in run updateState() after uses of mOriginalConnection
   since it is possible for updateState() to set it to null.
3) Add logging to the bug so that we can recognize when and how this
   situation happens in the wild.

Bug: 24469962
Change-Id: Ic7c986bff98ee65677a4a2cb06beff54d79e5ab6
      fff1c1dc
  21. 19 Oct, 2015 1 commit
  23. 16 Oct, 2015 7 commits
  25. 12 Oct, 2015 1 commit
  27. 07 Oct, 2015 1 commit
  29. 06 Oct, 2015 1 commit
  31. 26 Sep, 2015 1 commit
  33. 25 Sep, 2015 3 commits
  35. 22 Sep, 2015 2 commits
  37. 18 Sep, 2015 2 commits
  39. 17 Sep, 2015 1 commit
  41. 15 Sep, 2015 1 commit
  43. 11 Sep, 2015 3 commits
  45. 10 Sep, 2015 4 commits