GitLab

Fix recalculateConferenceable() to not differentiate Connferenceables by
whether or not they are currently in the active/background, since it has
no bearing on whether or not a Conferenceable is mergeable with another
Conferenceable. This allows us to send less updates to the
InCallServices when swapping calls in IMS.

Bug: 30676004
Change-Id: I6190364e902941e2969cced7a66e52f00be57064

Change-Id: I0586f39e9ade9a93e46bf1ceea37ee3d908cc64b
Auto-generated-cl: translation import

Send a telephony-specific connection event so the InCallService can
display a message.

Bug: 30697460
Change-Id: I9df78ca49edfd41a5081a93d64301c4671f6ec09

When the SIM is removed the VVM config is no longer valid so the event
cannot be handled.

In this CL the status will directly be disabled.

Change-Id: I7ce50734435b2378779b464da3364031efff1f1f
Fixes:30678043

Change-Id: Id4d3e0df4b64be41e96a65cedf361fbf72620757
Auto-generated-cl: translation import

Bug: 30629746
Change-Id: Id3df02c2c06e02fe48b7877aafa1c55c28cebafa

Although this isn't explicitly used in Dialer at the moment, it was
something defined and forgotten to be used.

Bug: 29906222
Change-Id: I6b722a8fb0ddd82fa1600ac81526f650b8aa5466

The VVM client only supports audio messages. Most other message types
are filtered the moment the SYNC SMS is received, but some message type
such as VVM3 DSN is indistinguishable from audio message and will pass
through.

DSN (Delivery Status Notification) is the notification when sending a
email to some address has failed. VVM3 DSN triggers a SYNC SMS that is
completely identical to normal audio messages, and can only be
identified after accessing the IMAP server.

Although DSN is not supported in the VVM client, some carrier has this
feature in their voicemail telephone interface, and will send the DSN
to the client, this must be handled or a unplayable message will be
shown with no indication of errors.

In this CL, if the client is unable to find the audio data for a
voicemail, it will be deemed a an unsupported message, and its'
transcription field will be replaced by an error message. This covers
not only DSN but also any other unplayable message.

While this solution is far from ideal, it is not expected to have a lot
of users that use the DSN feature or other unknown message types.

Change-Id: I482479b746776b563ebf5694a58a8c2cf534b0f2
Fixes: 30588635

b/30513337 NPE when connection lost
ImapConnection will try to log out when the connection closes, even
when the connection is interrupted and logging out cannot be done.
Doing so will cause a NPE.

In this CL log out will only commence if the transport is still valid.

b/30514504 Don't show "Activating" if VVM has been activated before
The activating message is shown upon every boot but most of the time
the account should be already activated, activation is just for book
keeping.

After this CL the activating message will only be shown if the account
is never activated before on the device. Error message will still be
posted if activation fails.

b/30483028 getCallCapablePhoneAccounts() returns null
This is working as intended, comments updated

b/29363739 Unable to fetch voicemail from Marshmallow
PhoneAccountHandle is stored in the database to determine which account
to fetch voicemail from. Between M and N the PhoneAccountHandle value
has changed, causing the entry in M voicemails to mismatch.

In this CL if the phone account of the voicemail cannot be found, the
client will try to search it as the M format

+ Fix NPE while updating quota when the preceding operations on the
  ImapHelper has already failed.

Change-Id: Ia17e345c772892e17a005ae8f0c6c08255a0ef1f
Fixes: 29363739
Fixes: 30513337
Fixes: 30514504

In some cases TelecomManager.getCallCapablePhoneAccounts() might return
a PhoneAccountHandle with a invalid subId on boot, which will cause
a NPE when trying to convert the subId back to a PhoneAccountHandle
in SimChangeReceiver.processSubId().

SimChangeReceiver also might be triggered with a invalid subId that
is not SubscriptionManager.INVALID_SUBSCRIPTION_ID.
SubscriptionManager.isValidSubscriptionId() should be used instead of
comparing with the constant.

In this CL the subId is validated on the above events.
PhoneAccountHandleConverter.fromSubId() will also handle invalid subId
gracefully and return null. The null return value is checked in all
usages.

Change-Id: Ie703b1a2a826a2951e8cc90fccc6badd76928bd3
Fixes: 30474294

In some cases a phone account might have already written to the status
table, but the feature is later removed through changes in
CarrierConfig. Previously the VVM client will just stop handling the
account and the status will be stuck in the table. Sometimes it would
leave a error that which will be shown to the user forever.

After this CL, if the phone account has no VVM support, the status
table entry will be reset to the disabled state, which will make the
UI ignore the account.

Bug: 30314643
Change-Id: I0b67decd62d021de90d7d0ff0f5209e7f3e624ee

On Vzw when there are multiple anonymous participants, the SIP uris
returned in the CEP are different from what was expected ; eg:
sip:anonymous1@anonymous.invalid;legid=1
sip:anonymous2@anonymous.invalid;legid=2

The CEP parsing code did not handle the ; and extra parameter.
Per RFC3261, when we parse this string:
anonymous1@anonymous.invalid;legid=1
We first separate out and ; parameters (which are guaranteed to be at
the end of the address.

Bug: 30434469
Change-Id: I2f7224f434a0b01f54d6815276a8bb365bd53ac1

Makes sure that PROPERTY_IS_DOWNGRADED_CONFERENCE and
CAPABILITY_CONFERENCE_HAS_NO_CHILDREN are not erased when
updateConnectionProperties and updateConnectionCapabilities are called.

Bug: 29806833
Change-Id: Id8e3a81845df0bc144a040c68709db111f467473

If the logged in user is not the primary user, then video will be disabled
on the phone accounts registered.  This solves the problem that video calls
fail for secondary users.

Bug: 27616192
Change-Id: Ic91854cbc7d692c7c3a8319e98fbb4526781becd

This reverts commit 1e68844e.

Change-Id: I4974fa654ed53ea1038f56d958d065c1bf1c0e30

UploadTask does not have a valid subId because it is broadcasted
toward all accounts. ACTION_SYNC_VOICEMAIL is also toward all accounts
and lacks the subId.
In ag/1245021 we passed in a voicemail status editor with the invalid
subId while creating the upload task, which causes NPE.

After this CL OmtpVvmSyncService.sync() no longer accepts a null subId.
Events that targets all accounts will launch a individual task for each
account instead.

- TaskId.SUB_ID_ANY is removed. All task should have a explicit subId

Change-Id: Ib4892daf4f9cb732dbce9710f87754cd780fa535
Fixes: 30367830

Code does a sanity check to make sure ECBM mode is active before
showing notification. However checking system property for that is
not safe as the property may not have been updated. Query the phone
instead.

Bug: 30237792
Change-Id: If650121391f2effccb9461c13d34f49f5bbe70c2

VvmPhoneStateListener can be trigger with a when the PhoneAccountHanlde
no longer has a valid subId. why this can happen still needs
investigation.

This CL changed VvmPhoneStateListener to ignore invalid subIds, and
guard PhoneGlobals.clearMwiIndicator against null phone.

Bug: 30315483
Change-Id: I3d062991d8af63aaf0ebc76b3961a335dace3192

Change-Id: Ifb9b902e4f57733e69d7b4625fa1e13b3d63b073
Auto-generated-cl: translation import

Error messages generated from tasks that have retries are often short
lived and not actionable. These errors should wait until no more
retries are available before being shown.

Before this CL, All error codes are written directly to the database
when a event is triggered. After this CL, writing to the database
requires a VoicemailStatus.Editor() object to be passed in. Usually
the object will be the same direct-write object as before. But in
retrying tasks, the object passed in will have the writes deferred
until the result of the task is determined. The writes will only be
committed if the task is successful or no more retries are left.

Passing a error handling object deep down is not ideal. A better way
will be throwing a exception back up so the task can decide how to
handle it. Unfortunately, deeper codes cannot handle escaping
exceptions gracefully, and changing it involves too much risk at this
moment.

+ Subsequent activation does not show the activating message

Fixes: 30284894
Change-Id: I523e8aa2f89ff3af13016eccd2392cee302e79dc

Bug: 30283023
Change-Id: I455c0777b733fd295b80153785871216ff7698e9