GitLab

Bug: 22519119
Change-Id: I8aff294201dfd8ec46ff3d30e4ceecea1346f29b

When enforcing various storage permissions, check associated app-ops
to see if they've been revoked.  We're okay throwing outright, since
Environment already told the app that volumes are unmounted, so they
have no business poking around.

Read/write sanity checking should only be relaxed to group-level for
files living on storage devices; continue using globally readable
flags for all other files.

Refresh storage paths whenever volumes change.

Bug: 22718722
Change-Id: I8640998f490550b4cd3a9b27bb6cb1a658bd102a

The new storage layout used for runtime permissions uses the "group"
ACL for enforcing access, and the "other" ACL is usually masked off
completely.

Bug: 22525550
Change-Id: I29b48cc3425ccfc8d3ff5ec323c8dc50be104878

It ends up that MediaProvider is persisting MTP storage IDs in its
database, so we need to make sure we generate stable IDs over time,
otherwise we can end up looking into a black hole.

Bug: 22256092
Change-Id: Ia419c37f87c7c0aa59ef0de530fd219c82988f6c

We can now have primary emulated removeable storage, which causes
this code to be upset.

Bug: 19993667
Change-Id: Id806c5d41ede6e040af9a48496b9e103a9c75962

Bug: 19993667
Change-Id: I6380ac08f2eb91af81277d0ace42943e20112b2d

Bug: 19246412

Change-Id: I25c2f09ded0527ac062d9c8a57adf3aa7639ea76

Don't notify MTP.

Steps to Reproduce:
1. Connect DUT to Win7 PC via USB cable.
2. Do Factory reset, don't unplug the USB cable during the reset.
       ->DUT will reboot automatically after factory reset.
3. After DUT enters the system, transfer some files to the DUT by MTP or
take some photos by Camera.

Expected Results:
Read DUT files normally on Win7 PC.

Actual Results:
The files transferred by MTP are named as "Local Disk" on the PC.
And the photos token by Camera can not be showed.

After file is inserted into "internal.db", don't notify MTP. If notify,
PC will get no data from DUT because MtpServer will only query
file's info from "external.db" and after PC gets no data so many
times, it won't send "GetObjectPropList" request to DUT, that will
cause "Local Disk" showed on the PC side.

Change-Id: I6cb364158dbda8b267bdfbf6663d0682f7d4d6cb
Signed-off-by: xiaochao <xiaochao.huang@intel.com>
Signed-off-by: Bo Huang <bo.b.huang@intel.com>

    Because Sprout has removable storage, the framework needs to maintain
    external database for keeping multiple databases between SD cards.
    When cleaning up databases for old external storage volumes, we can't
    delete .db-shm and .db-wal because these two files always have the
    latest data and .db doesn't have. Using camera or Google+ will access
    .db-shm and .db-wal to get the latest data and will cause SQLite Disk
    I/O exception if they are deleted.

    The fix is to modify the logic of cleaning up databases (only delete
    .db file, not to delete .db-shm and .db-wal file).

    Bug 18412563

    Review: https://partner-android-review.git.corp.google.com/#/c/187072

Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Change-Id: I484bd535ddebee09824a10f12241f6b2ce086b94

Bug: 18118488
Change-Id: If1d12def4598be9cbf86b8550061f4d075be9717

Bug: 17943556
Change-Id: I1ee026fc0f6248dab2e678e478ba76e8d464dba6

vaguely related to bug 10733373

Change-Id: Icda99a66d893374de7a1ed84d24f2c97a72b90b2

Make sure we release cursor resources.

Change-Id: Ia122100b1350ae5db4804f8f0e95c49785ab645b

Change-Id: Ie2ee436d9d5aa8f189bcb5a64116d09fccc5233b

Change-Id: I2355ec73cdf82b7c51a154c7ef2269791240638b

Apps with WRITE_MEDIA_STORAGE can write to the secondary
external storage directly so there is no need to prevent
that through the MediaProvider.

Change-Id: If092fcdf0b90599afdb52a8e6ae4c7ba1090acc4

Change-Id: Ic3f9799147b3f12c71fd824da9de51e264b70488

The bucket id and display names references were off by one, resulting
in brokenness when renaming a directory via MTP
b/10835798
b/11655617

Change-Id: I9e6c510027a37deed55887393e388805f06b86b0

b/9604671
b/10345049
b/11380658

Change-Id: Ifa4db10261f39e5af5fe84902f7221075a78bad3

We should match against "/storage/foo/" instead of "/storage/foo", in case
there is a path that is a prefix of the other.

Change-Id: If6cda18768039a130dfb81dd402ac4ce7b26a2a7

b/9604671

Change-Id: I49035ed53dab71cdacb7f3cdd59c18e8bb5ba850

Now that storage volumes are FUSE-wrapped, userspace apps no longer
have access to perform the direct ioctl().

Bug: 11175082
Change-Id: I08b8367a89e4f325dd28c29789165e95c70e9944

b/9604671

Change-Id: Icc3a0b06e066c71d12634dc11ef934f3ac1c2c2b

When deleting images, videos, or audio, revoke any Uri permission
grants, which removes from getPersistedUriPermissions().

Bug: 10928851
Change-Id: Id2fedd5258f9674df1a786b06028b458dda1af17

When external storage is ejected, the _data column is updated with empty string.
Then, SQLiteConstraintException occurs because the _data column is modified to be unique.
So, to avoid SQLiteConstraintException, the _data column should be updated with NULL.

Change-Id: I2b00b5327c37f584970261789c5462626a5a4ea7

If we reported that Images, Videos, or Audio were empty, notify
when they become non-empty so RootsCache is updated and they appear
in UI.

Bug: 10745490
Change-Id: I0b10ca1b8a08ef7f5bd8bbee1eca62ca871aa4e6

ContentResolver#modeToMode() has been moved to
ParcelFileDescriptor#parseMode()

bug:10711271

Change-Id: I487bf2260475c726dd4818b433d0d32bd7a8d1a3

b/10130785

Change-Id: Ia51fa033d3a9ee8482a9828c6066b2d7d126ddab

b/10130785

Change-Id: Ia51fa033d3a9ee8482a9828c6066b2d7d126ddab

Multiple nulls don't violate the uniqueness constraint, but multiple
empty strings do.

b/10493391
https://code.google.com/p/android/issues/detail?id=59429

Change-Id: I79f7bcd1a83d3e514ba8e77b6231462d9082330d

Because of the execution sequences below,
receiving ACTION_MEDIA_EJECT intent during bulk inserting
can lead to media provider deadlock.

bulkInsert()
-> db.beginTransaction()
-> insertInternal()
-> getDatabaseForUri()
-> synchronized(mDatabases)

mUnmountReceiver.onReceive()
-> synchronized(mDatabases)
-> db.update()

beginTransaction() blocks any other operations on the database
until endTransaction() is called.
Therefore, db.update() method can be blocked in the synchronized block
and bulk inserting also can be blocked simultaneously to enter
the synchronized block.

This patch resolves the problem above by restricting the scope
of the synchronized block in mUnmountReceiver.

Change-Id: Ibb65ac82ea389145a6a3e44942928b7548c53b22
Signed-off-by: Sangkyu Lee <sk82.lee@lge.com>

When images or videos are deleted from the media provider, only delete
the underlying files if the caller is allowed to.

b/9818756

Change-Id: Iddf50b1fcf56220886ed9b6d953d97960cda0ec6

When an app is trying to open a Uri, check whether it has been granted
read or write permission by another app via the Intent.FLAG_GRANT_... flags,
instead of only checking whether the app itself has external storage read
or write permissions.

b/10345049

Change-Id: Idbc87fe34a05be9d8220ee7a0223d039480c3ffe

Screenshots were being inserted into the database with the wrong
"date taken" timestamp. Fix existing entries so they are correct
again and appear in the right order in gallery.

b/10424911

Change-Id: I6ff7283ac10be94b0e159b72da7e072084ef5a2b

When the audio doesn't contain embedded art, MediaProvider
will help to look for a suitable image file in the same
directory as the media file, excpet if that directory is
the root directory of the sd card or download directory.

MediaProvider looks for, in order of preference:
 1 AlbumArt.jpg
 2 AlbumArt*Large.jpg
 3 Any other jpg image with 'albumart' anywhere in the name
 4 Any other jpg image
 5 any other png image

If we put a image file and a audio file in same directory of
sdcard, and the size of a image should large than maximal heap size.
It will cause hte process android.process.media stop because OOM.
As a result, we need catch OutOfMemoryError exception to avoid this issue.

Change-Id: I4131188b4b75454f5bdb20c50b930ff8b7a370fa

Change-Id: I4131188b4b75454f5bdb20c50b930ff8b7a370fa

Change-Id: I2f30b3f01fe61306d89a8bd83fbd375a324e5e55

For paths that do not point to the sdcard or cache partitions (for which
READ_EXTERNAL_STORAGE, WRITE_EXTERNAL_STORAGE and ACCESS_CACHE_FILESYSTEM
permissions are checked as needed), check that they are world-readable.

b/9604671

Change-Id: Ib3b8c745139f356e9cb070c0862e0ce63c7bb1ba

When an app uses the MediaStore.Images.Media.insertImage() convenience
API, put the image in the Pictures folder, not in DCIM/Camera.
This seems like a more appropriate location, and avoids problems with
the Camera folder not existing (the Pictures folder is created during
initial setup).
b/9370759

Change-Id: I231aeae5ee24780ea0337f0ef3fd1a6030f2c372

If media provider failed to open the database during an upgrade,
it deletes the database file and tries again.
But when deleing the file, it doesn't delete wal and shm files.
This commit is to guarantee that
all related files (db, wal, shm) are deleted together.
Signed-off-by: jangwon.lee <jangwon.lee@lge.com>

Change-Id: I7b4e3cf71d0b285399794ee9b45791c6a112a00c

computeTakenTime() depends on the value DATE_MODIFED,
so call it after DATE_MODIFIED are set to ensure it
works correctly.

Change-Id: Ib4f3b03c487b45dd081dab5bd4ddfa72221b434f