1. 16 Apr, 2013 1 commit
  2. 05 Mar, 2013 1 commit
    • Hyoseong Kim's avatar
      Delete the code that does not use · ad9c7d31
      Hyoseong Kim authored
      Collator.getInstance() returns new Collator object.
      But, new Collator object is not used in function.
      
      Change-Id: Ie6ef4ecb5de8e47ac797aebed58fe5c8a0693cc0
      ad9c7d31
  3. 28 Feb, 2013 1 commit
    • Daniel Bonnevier's avatar
      Column in log table is not unique · ef8c5a39
      Daniel Bonnevier authored
      DATETIME was set as primary key but that value is not always unique.
      This solution is to remove primary key constraint from column "time"
      to avoid SQLiteConstraintException caused in case same DATETIME value
      is attempted to be inserted into log table.
      
      Change-Id: I06f1cd36a6f4f7becdb444599e4de7866813c9cd
      ef8c5a39
  4. 08 Feb, 2013 1 commit
    • Hiroaki Kuriyama's avatar
      Default ringtone cannot be previewed as alarm stream type. · f7188914
      Hiroaki Kuriyama authored
      When choosing a ringtone for alarm use by "Android System"
      ringtone picker (RingtonePickerActivity), default ringtone is
      not played for preview with volume of alarm stream type but
      with that of normal stream type.
      
      It is because stream type is not reflected on mDefaultRingtone
      instance of RingtonePickerActivity.
      
      Change-Id: Idc71c9b620e40e4109604b2337677134bb74a8cd
      f7188914
  5. 07 Feb, 2013 1 commit
    • Oscar Rydhé's avatar
      Notify change of movePlaylistEntry after transaction ends · 5e7f74c6
      Oscar Rydhé authored
      When a client asks the Media Provider to rearrange a playlist
      the notifyChange callback function is called before the database
      transaction is ended resulting in that listeners can't get the
      new data when they get the callback.
      
      notifyChange() is called before the database transaction is ended
      resulting in that listeners can't get the new data when they get the
      callback.
      
      This fix will wait until the database transaction is finished
      to do the callback.
      
      Change-Id: Ifdfbb047b809bd5fba4752bcdd299927f9082eee
      5e7f74c6
  6. 08 Nov, 2012 1 commit
  7. 22 Sep, 2012 1 commit
  8. 19 Sep, 2012 2 commits
  9. 18 Sep, 2012 2 commits
    • Jeff Sharkey's avatar
      Multi-user MTP, handle secondary user boot. · 8efd65fe
      Jeff Sharkey authored
      Watch for BOOT_COMPLETED, and dispatch any current USB state or
      mounted volumes which may have already occured.  This specifically
      handles starting of secondary users.
      
      The current MTP kernel driver at /dev/mtp_usb is exclusive, meaning
      only one process can have it open. To solve this, the framework
      cycles the USB host stack when switching users, giving the new
      user's media process a chance to claim the kernel device.  We only
      start an MtpServer when we're the active user.
      
      Bug: 6925114
      Change-Id: Idfcda09aed88140bb470a110a9e4434f5b79abdd
      8efd65fe
    • Mike Lockwood's avatar
      Make sure file paths are canonical in scanFile() · 704fe6bc
      Mike Lockwood authored
      
      Bug:  6987701
      
      Change-Id: I55d2f95ab63df19f9c9ba39da5215893b8e658e4
      Signed-off-by: default avatarMike Lockwood <lockwood@google.com>
      704fe6bc
  10. 12 Sep, 2012 2 commits
  11. 22 Aug, 2012 1 commit
  12. 20 Aug, 2012 1 commit
  13. 13 Aug, 2012 1 commit
    • Marco Nelissen's avatar
      Fix mediaprovider stats · 9b1fff74
      Marco Nelissen authored
      Increment delete/update counters in a few places I missed, and add
      an extra log for unmounted storage to help diagnose b/6094111
      
      Change-Id: I8118f67bb6114526dfe2839055ff447937266436
      9b1fff74
  14. 25 Jul, 2012 1 commit
  15. 23 Jul, 2012 1 commit
  16. 19 Jun, 2012 1 commit
  17. 23 May, 2012 5 commits
    • Jeff Sharkey's avatar
      Treat missing Cursor as FNFE. · 8ea255e8
      Jeff Sharkey authored
      Bug: 6543820
      Change-Id: I215921f9bc2196ec16df40bacdc249b5c079254a
      8ea255e8
    • Fabrice Di Meglio's avatar
      Fix bug #6522190 MountService should respond to configuration changes... · 9681e238
      Fabrice Di Meglio authored
      Fix bug #6522190 MountService should respond to configuration changes ("INTERNAL STORAGE" string should be translated dynamically)
      
      - use an ID instead of a String for StorageVolume description
      - use this ID for getting the correct localized version of the description string
      
      Change-Id: I7f1b1cf6c953442e3c47e54ed4ffbb4498f4cf78
      9681e238
    • Jeff Sharkey's avatar
      Handle the case case. · dfd97076
      Jeff Sharkey authored
      Since external storage is case-insensitive, check if we have an
      exact match on internal storage before opening directly. When it
      doesn't match exactly, we fall back to letting the sdcard daemon
      resolve the path.
      
      Bug: 6544070
      Change-Id: I6e6094f4b639ac70feae6549648c1e486480ed71
      dfd97076
    • Mike Lockwood's avatar
      MtpService: Recreate MtpStorage objects each time MTP starts · 55bf981b
      Mike Lockwood authored
      This will allow recomputing the volume description in case the locale has changed
      
      Bug: 6522190
      Change-Id: Icc055ae3404841582285c0f2a153d5ee10ebcc6d
      55bf981b
    • Jeff Sharkey's avatar
      Open file directly when external storage emulated. · f3329452
      Jeff Sharkey authored
      For the special case where (1) a file lives on external storage,
      (2) it's being opened for reading, and (3) external storage is
      emulated, this change rewrites the path at the last moment to open
      the file directly from internal storage.
      
      This avoids the overhead of forcing I/O through the emulated storage
      layer when we've already asserted the caller has permission. This is
      only possible because MediaProvider is running with the media_rw GID.
      
      Bug: 6539384
      Change-Id: Ieda6b30e819340d46466f8db2e34b47bbf06ee08
      f3329452
  18. 22 May, 2012 1 commit
    • Marco Nelissen's avatar
      Handle _ and % in paths · 54618878
      Marco Nelissen authored
      When doing a "like" match on a path, add a second non-like constraint
      so that sqlite wildcard characters don't match arbitrary other characters.
      b/6501408
      
      Change-Id: I3912dd70b842ccba2652385a7733965b6691d303
      54618878
  19. 15 May, 2012 2 commits
    • Marco Nelissen's avatar
      Optimize bucket name, enhance logging · 988280a7
      Marco Nelissen authored
      Small optimization to bucket field updater: reuse the same ContentValues
      and not needlessly convert to/from integer.
      Also add a mechanism to store short messages in the database, in order to get
      better information from bugreports.
      
      b/6467624
      
      Change-Id: I2777d58e5fefe98a0e91794ef25e1be0d2408304
      988280a7
    • Marco Nelissen's avatar
      Speed up schema update · 677d5c9a
      Marco Nelissen authored
      Restrict updating the "bucket" columns to just images and videos,
      instead of all files.
      
      b/6344917
      
      Change-Id: I93bb236556220a05dffc633219302cda43facbd7
      677d5c9a
  20. 14 May, 2012 2 commits
    • Marco Nelissen's avatar
      Set the right parent id · d4e1312b
      Marco Nelissen authored
      The media provider was filling the parent-cache with bogus values during
      a media scan, causing all files to appear in the MTP root instead of in
      their proper locations.
      b/6487442
      
      Change-Id: I3dacd6c69072be13e75ddf59662b16682e806d68
      d4e1312b
    • Mike Kasick's avatar
      Check external storage volume ID to ensure media is actually mounted. · ae1e6c56
      Mike Kasick authored
      Programs may request to media scan files (via MediaScannerConnection::scanFile)
      before external storage is mounted.  If that happens, MediaProvider creates
      an external-ffffffff.db (volume ID -1) database once external storage is
      mounted, instead of the one with the expected volume ID.
      
      Later, if android.process.media is killed and respawned, the real external
      database (that is, the one corresponding to the actual external storage
      volume ID) is attached.  At best, that database contains stale records.
      However, in conjunction with another bug (where the LRU database garbage
      collector prunes all but one external database), most often a new, empty
      database is created.  This results in the sudden disappearance of all
      ringtones and media from programs that depend on the media database.
      
      Change-Id: If4e23b52cd09a640e26852916eef53710c27d933
      ae1e6c56
  21. 07 May, 2012 1 commit
    • Marco Nelissen's avatar
      Fix media provider dumpsys · 5619dbb4
      Marco Nelissen authored
      MediaProvider would not set the scan start time in some cases, which
      would then make it skip some dumpsys output. This fixes the problem
      by ensuring that the scan start time is set when attaching to the
      volume.
      b/6456260
      
      Change-Id: I99f25ff5f2dd44cf92b08bbdf8fb015cd062e958
      5619dbb4
  22. 03 May, 2012 1 commit
  23. 02 May, 2012 1 commit
  24. 25 Apr, 2012 1 commit
  25. 19 Apr, 2012 1 commit
    • Marco Nelissen's avatar
      Fix album art retrieval edge case · 34fa8b51
      Marco Nelissen authored
      When re-retrieving album art that had previously been deleted, a
      NullPointerException might occur.
      b/6359924
      
      Change-Id: Icb1aa1bd52583025893e5b8cc7a73c47a4bfe8f3
      34fa8b51
  26. 18 Apr, 2012 1 commit
  27. 16 Apr, 2012 1 commit
  28. 13 Apr, 2012 1 commit
    • Marco Nelissen's avatar
      Fix media database after sdcard mountpoint move · 59f8f11e
      Marco Nelissen authored
      The internal "sd card" storage is now in /storage/sdcard0. However
      since /mnt/sdcard still exists for compatibility, the media scanner
      will see a bunch of new files in /storage, in addition to the existing
      files in /mnt/sdcard, resulting in two entries in the database for
      every file.
      This change removes any entries that were already scanned in /storage,
      then updates the paths for the existing /mnt/sdcard entries to point
      to /storage instead. This will handle both updates from ICS, as well
      as fix the database for people that ran a build inbetween the move
      to /storage and this change.
      
      b/6131916
      
      Change-Id: I1c071187651544be0fdb69e1cdb6367b636fc6d5
      59f8f11e
  29. 06 Apr, 2012 1 commit
    • Marco Nelissen's avatar
      Fix playlist issues. · 4eff7fef
      Marco Nelissen authored
      If an item was removed from a playlist, the play_order field of the following
      items would not be adjusted. Because of a bug in the code for reordering items
      in playlists, this would prevent reordering of items after the deleted item,
      and could confuse apps that appended more items to the playlist after that,
      causing them to insert with duplicate play_order values.
      This change both makes it safe to have gaps in the play_order sequence, and
      ensures that when deleting items, the following items have their play_order
      adjusted downward so as to not leave any gaps if there weren't any before.
      
      b/6299084
      
      Change-Id: I0709fa7167790a86b966059184e15b97da2ed74f
      4eff7fef
  30. 05 Apr, 2012 1 commit
  31. 04 Apr, 2012 1 commit