GitLab

Fix merge conflict into nyc-release
When opening a downloaded file, enforce that the caller can actually
see the requested download before clearing their identity to read
internal columns.

However, this means that we can no longer return the "my_downloads"
paths: if those Uris were shared beyond the app that requested the
download, access would be denied.  Instead, we need to switch to
using "all_downloads" Uris so that permission grants can be issued
to third-party viewer apps.

Since an app requesting a download doesn't normally have permission
to "all_downloads" paths, we issue narrow grants toward the owner of
each download, both at device boot and when new downloads are
started.

Bug: 30537115, 30945409
Change-Id: If944aada020878a91c363963728d0da9f6fae3ea
(cherry picked from commit 243e6294)
(cherry picked from commit 1db23ffb)

Fix merge conflict into nyc-release
When opening a downloaded file, enforce that the caller can actually
see the requested download before clearing their identity to read
internal columns.

However, this means that we can no longer return the "my_downloads"
paths: if those Uris were shared beyond the app that requested the
download, access would be denied.  Instead, we need to switch to
using "all_downloads" Uris so that permission grants can be issued
to third-party viewer apps.

Since an app requesting a download doesn't normally have permission
to "all_downloads" paths, we issue narrow grants toward the owner of
each download, both at device boot and when new downloads are
started.

Bug: 30537115, 30945409
Change-Id: If944aada020878a91c363963728d0da9f6fae3ea
(cherry picked from commit 243e6294)

When deleting a file from DownloadManager, we also reach over and
clean up any scanned MediaStore entries.  However, DownloadManager
clients may not hold the WRITE_EXTERNAL_STORAGE permission, such as
when they downloaded a file into their package-specific directories.

The safest fix for now is to clear the calling identity and always
clean up the MediaStore entries ourselves, since DownloadProvider
always holds the required storage permission.

Bug: 29777504
Change-Id: Iea8f5696410010807b118bb56e5b897c53f0e1fe

When deciding to kick off a media scan of a newly-downloaded file,
use the latest values from InfoDelta, instead of stale values from
the last database read, which may lead us to skip the scan.

Bug: 29234780
Change-Id: I7ffbcdd1edb9965999b7f5f100f57a9c2933f3a5

When a download is stopped due to a metered network, we should
reschedule the job just like any other network failure.  If a
download requires an unmetered network, treat WAITING_FOR_NETWORK as
QUEUED_FOR_WIFI so we show a meaningful notification.

Bug: 29440531
Change-Id: I31e6535c575fd32e2982ef840ae501acf1db3927

When inserting an already-completed download, we don't schedule a
job, leaving notifications stale until the next real download comes
along.  This change kicks off a notification update pass in these
cases to ensure we reflect the internal state.

Bug: 29548026
Change-Id: I6ff87d69d83c265738d5e035197204bbb63cfa81

Bug:29505888
Change-Id: Ifc33fd75e44d1dbc5a4ce5caa8e1ff938b94623e

Auto-generated-cl: translation import

Bug: 29169863
Change-Id: I09904dcd600f9abb31e57857c603af53ac3d710e

Change-Id: I0af9c77f30ac97457c5fa029ffa9138b1e8a3c6d
Auto-generated-cl: translation import

Otherwise it's confusing to see notifications for downloads that
are otherwise invisible.

Bug: 28623639
Change-Id: I1b2aeccfcca1369f66c56c441dfef68ee95c6d62

Change-Id: I20691844173d81874c3220b1813f4b8726f3e58d
Auto-generated-cl: translation import

Auto-generated-cl: translation import

Bug: 28857042
Change-Id: I57cd87a88242f29ec5038bf53cc74f4b0e6279ba

BUG: 28743623

Change-Id: I314febe06e5516dfa69062da691e0189b051dac5

Change-Id: I7f86c0526a2ec3ce85affb5f6cca26c56eb34647
Auto-generated-cl: translation import

BUG: 28521946

Change-Id: I32129977c121b610bdd1a780fd371baaff3ead4b

The recent JobScheduler rewrite means we no longer spin up a service
when insterting an already-completed download.  However, the calling
app may have requested the download to be scanned, so kick off a
scan request for them.

Bug: 28659693
Change-Id: I497e10995ba04f1522fe8d7e547ebea6e305f6e9

The recent JobScheduler rewrite means we no longer spin up a service
when insterting an already-completed download.  However, the calling
app may have requested the download to be scanned, so kick off a
scan request for them.

Bug: 28659693
Change-Id: I497e10995ba04f1522fe8d7e547ebea6e305f6e9

Bug: 28476442
Change-Id: I12a35a2c35c16ddf899637dfb85c30006c169fd7

Auto-generated-cl: translation import

Bug: 28463229
Change-Id: If9046aa28360250cc5d2a5e646a10d2a7b666d43