Skip to content

GitLab

Switch branch/tag
  1. 12 Oct, 2016 1 commit
    • Jeff Sharkey's avatar
      Enforce calling identity before clearing. · ceec8c3f
      Jeff Sharkey authored 
      Fix merge conflict into nyc-release
When opening a downloaded file, enforce that the caller can actually
see the requested download before clearing their identity to read
internal columns.

However, this means that we can no longer return the "my_downloads"
paths: if those Uris were shared beyond the app that requested the
download, access would be denied.  Instead, we need to switch to
using "all_downloads" Uris so that permission grants can be issued
to third-party viewer apps.

Since an app requesting a download doesn't normally have permission
to "all_downloads" paths, we issue narrow grants toward the owner of
each download, both at device boot and when new downloads are
started.

Bug: 30537115, 30945409
Change-Id: If944aada020878a91c363963728d0da9f6fae3ea
(cherry picked from commit 243e6294)
      ceec8c3f
  3. 31 Aug, 2016 1 commit
  5. 29 Aug, 2016 1 commit
    • Jorge Gil's avatar
      DO NOT MERGE: Check that file exists in disk in queryChildDocs · a4b509c3
      Jorge Gil authored 
      Check that files returned from querying DownloadManager in
queryChildDocuments and queryChildDocumentsForManage still exist in
External Storage.

Bug: 28430547, 31108493

Change-Id: I4efe9f9ba79d41b3c3099fb96d18460880b742b5
(cherry picked from commit c45f4998c0b4f7ab44d3d2a180ca977ca2fa5ca8)
(cherry picked from commit 314026d4)
      a4b509c3
  7. 27 Aug, 2016 1 commit
  9. 26 Aug, 2016 10 commits
  11. 22 Aug, 2016 1 commit
  13. 10 Aug, 2016 1 commit
  15. 09 Aug, 2016 10 commits
  17. 01 Aug, 2016 1 commit
    • Jeff Sharkey's avatar
      Enforce calling identity before clearing. · 8be3a92e
      Jeff Sharkey authored 
      When opening a downloaded file, enforce that the caller can actually
see the requested download before clearing their identity to read
internal columns.

Bug: 30537115
Change-Id: I01bbad7997e5e908bfb19f5d576860a24f59f295
      8be3a92e
  19. 31 Jul, 2016 1 commit
  21. 28 Jul, 2016 1 commit
  23. 27 Jul, 2016 1 commit
  25. 21 Jul, 2016 2 commits
  27. 29 Jun, 2016 2 commits
    • The Android Automerger's avatar
      merge in nyc-dr1-release history after reset to nyc-mr1-dev · 47a75626
      The Android Automerger authored
      47a75626
    • Jeff Sharkey's avatar
      Clear identity when deleting scanned entry. · cc25d6c2
      Jeff Sharkey authored 
      When deleting a file from DownloadManager, we also reach over and
clean up any scanned MediaStore entries.  However, DownloadManager
clients may not hold the WRITE_EXTERNAL_STORAGE permission, such as
when they downloaded a file into their package-specific directories.

The safest fix for now is to clear the calling identity and always
clean up the MediaStore entries ourselves, since DownloadProvider
always holds the required storage permission.

Bug: 29777504
Change-Id: Iea8f5696410010807b118bb56e5b897c53f0e1fe
      cc25d6c2
  29. 28 Jun, 2016 3 commits
  31. 27 Jun, 2016 1 commit
  33. 25 Jun, 2016 1 commit
    • Jeff Sharkey's avatar
      Make scanning decisions based on latest data. · 3a4a3e7c
      Jeff Sharkey authored 
      When deciding to kick off a media scan of a newly-downloaded file,
use the latest values from InfoDelta, instead of stale values from
the last database read, which may lead us to skip the scan.

Bug: 29234780
Change-Id: I7ffbcdd1edb9965999b7f5f100f57a9c2933f3a5
      3a4a3e7c
  35. 23 Jun, 2016 1 commit