GitLab

Fix the bitmap leaks in InCallUI that were a result of
StatusBarNotifier instances being retained across calls.

Bitmap -> StatusBarNotifier -> CallUpdateListenerMap ->
CallList

Bug: 25003292
Change-Id: I4f8695d7dfbc397b0fee0305a6f94e8d2e8e593f

The child number display functionality assumed that the child number for
a call would only bet set at the start of the call.  This change removes
that assumption and supports changes to the child number at any point
during the call by adding a new listener to the InCall Call List.  It
appears there are some instances in reality where the child number can
come in after the start of a call (delayed only slightly, but enough to
prevent the number from showing up).

Bug: 24585039
Change-Id: I23148e8c4265f1bc16ce563f2919e9b3eb71784f

Even if the carrier config is set to disable call subjects for a carrier,
the RIL will still send any incoming call subjects to the InCall UI.
We cannot suppress this lower down as the RIL is using the same extra
to report caller id presentation reasons.

Bug: 22779583
Change-Id: Ic349408014a47e25d62100886ea59b73e4f76709

Changes to fetch the no-caller ID reason from callsubject extra in the
call object to display in the InCall UI. The callsubject extra would be
populated by the RIL to hold the non-caller ID reason in case of number
presentation that is set to RESTRICTED/UNKOWN and hence we need to
differentiate the contents of this extra in InCallUI.
PS: We should ideally be creating a different extra for the no-caller ID
reason at telephony layer even if RIL sends it in the same exta as call
subject, but that would require API changes.

BUG: 22683773
Change-Id: I4ae51754d7660e4b8c1082d142e2c1860d3f1604

Last forwarded number:
- Added assets for the "forward" icon for last forwarded number.
- Modified InCall Call to store last forwarded number; also calls
onLastForwardedNumberChange callback (the last forwarded number is
received via a supp service update, so may change after call starts).

Call subject (i.e. instant lettering):
- Added placeholder subject_bubble asset to form the chat bubble for
incoming calls with a subject.
- Modified InCall Call to store the call subject (expected to be populated
in extras at start of call.
- Added code to hide the call status (e.g. "incoming call via XYZ") line
and primary call label (e.g. a location "California", or the number type
"Mobile" for the number).  This was necessary to make room for the call
subject bubble, and is in line with the UX mocks.
- Change call subject text color to background color of call card (per
UX mocks)
- Modified call notification to show call subject if it is specified.

- Moved code to show HD icon into common method.

Bug: 22685114
Change-Id: I22d9dae16658490e3245cfdd9c936bb0584cd6db

Reusing a previously HUN for a non-incoming call notification
can lead to unexpected behavior with the NotificationManager.

Instead, keep track of what kind of notification we are currently
displaying, so that we can cancel the old HUN and display a new
notification if the need arises.

Also log a little less verbosely when creating notification actions.

Bug: 21926442
Change-Id: Id888b65aeecded6b9ca22f7cf36b265af3d93327

Move NotificationBroadcastReceiver into its own class.

Change-Id: Ieefc840af7df596bfbb9297847ad164870e48970

Because a new copy of a rounded bitmap is created everytime,
the check against the cached copies of information was failing to
detect identical notifications, causing multiple full-screen
notifications to be sent to the notification manager.

This causes a delay in the time it takes for the HUN to be
hidden when accepting a call.

Bug: 20764430
Change-Id: I4f62d5091b7fc216312a612181a91e3ec4828661

- fixed potential NPE in VideoCallFragment when setting preview size.
- moved photo load into the postExecute for the async task -- it is
already threaded and I was seeing intermittent concurrency issues.

- Changed CallButtonFragment to retrieve max # of buttons from config.xml.
  - Added override for wider screens (e.g. N6 and wider) to show an extra
    button.
- Reorganized call buttons so that the "Camera on/off" button is adjacent
to the flip camera button.
- Changed answer Glowpad to pass correct video state so that accepting a
video request uses the correct state (important for accepting requests to
turn camera back on).
- added new Session modification state REQUEST_REJECTED for when the remote
user explicitly declines the request.  This is used to trigger a
"video request rejected" message when the remote party rejects the
request.

Bug: 20257400
Change-Id: Ibe25eb045ee868748f91bf411f285629d36ebcd2

Bug: 20160395
Change-Id: Ibc877c3d6898770bce4bd96bdcbe673061141892

Always show the InCall notification iff there is a live call
(incoming, outgoing, active or held).

Change-Id: I2fc2a54c92cd0978dcf1bf49b0e8217bf2acc3ec

Bug: 20108489

Always show the InCall notification iff there is a live call
(incoming, outgoing, active or held).

Change-Id: I2fc2a54c92cd0978dcf1bf49b0e8217bf2acc3ec

Bug: 20108489

This is fixing multiple deficiencies affecting video call upgrade or
downgrade in the L MR1 InCallUi.

Change-Id: I61bf7efa6ac23859c900dfd059faf72184987943
Signed-off-by: Matthieu Baglin <matthieu.baglin@intel.com>

This is done in the call card by showing the wifi icon.

This is done in the notification, by change the subtext.

For international calls in particular, this helps users understand
how accepting a phone call will affect the cost of their call.

Change-Id: Ifebd9f9cc8598b7fe5b693673b27a485f7ecdf0f

Replace CircularRevealActivity with a fragment that is tied to
the lifecycle of InCallActivity so that InCallActivity is the
only activity that is involved in the outgoing call process.

Simplify some of the intent creation logic that is used to launch
InCallActivity since we no longer need some of the flags that were
currently provided via various method overloads in
InCallPresenter.getAnimationIntent and getInCallIntent.

To further simplify this CL, a very rudimentary approach is taken to
track the state where we are starting up the UI but haven't received
a call from Telecom yet. This is done by a boolean flag set on the
InCallPresenter: mBoundAndWaitingForOutgoingCall.

Further changes will build upon and improve this.

Also set most elements inside primary_call_info.xml to
visibility: GONE by default to fix some animation jank where a
empty but not GONE view would continue to take up space.

Change-Id: Ic70857685680af6868d4b2153d942d73eef3ca56

* Start InCallUI immediately once Telecom binds

* This CL is a bandaid for improving outgoing call responsiveness
in the MR1 timeframe. Refactoring InCallActivity into dynamically
added fragments and modifying its lifecycle with respect to
the call list is too risky.

* Add a lightweight activity (CircularRevealAnimationActivity)
that is used to display the circular reveal animation while
the significantly heavier InCallActivity is starting up

* Inside InCallServiceImpl.bind, start the reveal animation once
bind is called to avoid being blocked by any synchronous work in
Telecom.

* Refactor CallCardFragment.animateForNewOutgoingCall to
conditionally display the reveal animation, depending on
whether or not it was already displayed by the
CircularRevealAnimationActivity.

* Refactor the calculation of theme colors in InCallPresenter so that
the CircularRevealAnimationActivity can use those colors as well.

* Remove PENDING_OUTGOING from the list of call states that bring up
InCallUI.

Bug: 18373617
Bug: 18611753

Change-Id: I44c593373864ffc0ba9edebb88887177112d8b27

The phone number should always be displayed LTR, regardless of
whether the language is LTR or RTL.

Bug: 18581329
Change-Id: I7f8e43f86d996625da781500e61c65abe507304e

Bug: 18468085
Change-Id: I5d64f8958fe2be1952ee8a98fef77c6dd7d5e46a

Change-Id: I62a93662730afb8f8a5f75417549c8bb7d50cc78

This code path happens ~8 times in the outgoing call process
and causes unnecessary binder transactions

Bug: 18373617
Change-Id: I179159df396fcbbae306c5599f59b24f3addc56f

Don't use conference call string / icon if it's a generic conference;
we aren't positive what the state of the call is.

Bug: 18488721
Change-Id: Ib9041b25d33f5f0baada6defca6351beb5a929d2

Bug: 18021170
Change-Id: Ib618f5d244701d50faaf1070cb510b38deacd5f4

Bug: 17894022
Change-Id: I021f362f261fd9053c8749361692e6f3fabb9fcf

Bug: 17879740
Change-Id: I6320cb60cdcc06408b576396d187cdfc1844b1c3

Bug: 17879740
Change-Id: Ie97f382e65faea5fe2804076adbc415b90c82a7f

- Changing package from android.telecomm to android.telecom
- Changing package from com.android.telecomm to
com.android.server.telecomm.
- Renaming TelecommManager to TelecomManager.

Bug: 17364651
Change-Id: Ie5ae18f51baa5da2eb9793785ad0c9d83b6343d1

Use PhoneAccount defined values for SCHEME_{TEL, SIP, VOICEMAIL}.

Bug:17398074
Change-Id: Icd841240929a7531e3c7a93021fc19f7620f2cc6

+ Swap out/in new assets for end/split icons in the manager screen,
and the splash screen in the InCall screen.
- Removed unused conference call manager code, including things like
chronometer and the "done" button.
+ Replaced custom action bar in conferece call manager with standard
action bar.
+ Added contact image (does not open quick contact) in the list of
calls in the conference call manager. This is done with a lookup
using the contact photo manager, and required adding the lookup key
to the ContactCacheEntry.
+ Handled a missing Call.State case in CallCardFragment for calls
with state CONFERENCED which caused crashes.
+ Misc style changes on conference call manager: colors, sizes,
paddings.
+ Adjusted elevations so dialpad covers manager/secondary buttons.
+ Added ripple to manager/secondary buttons.

Bug: 15862303
Change-Id: Iab9b6421d5a1ea69cd951a459d46c065f9456a8f

Not directly related to bug, but cleanup I noticed along the way.

Bug: 15862303
Change-Id: I332597af836c073c4e6ae5f037cc033adf22e518

Bug: 17179079
Change-Id: I3b327250c181f821ec37d574ae804f8003d04603

Bug: 17129072

Change-Id: I4cf78580a0cbab93a2362d564a3454c81d596d95

+ Move session modification listener into the video call presenter.
+ Add new video accept/reject notification and full-screen UI.
+ Added "handling" which sends session modification response.

Bug: 16657915
Change-Id: I35ff04e383d4938cbfb4e76677730f82557fd918

Add PENDING_OUTGOING as a state where the Telecomm information has not
yet returned but the UI has started. This allows the UI to immediately
begin initiating while Telecomm is waiting for the return of its
broadcast intent.

Bug: 16396523

Change-Id: Ia4b39689b89f9dea3aafae9e63ca0bfebb730501

- Add isVideo method to the InCallUI call.
- Added cases and actions for isVideo to StatusBarNotifier.
- Added cases for isVideo for processing incoming call in the
full-screen experience in AnswerPresenter.
- Did what I figured would be some cleanup, to consolidate some
helper methods only ever called once, and reorder some methods
to be more alphabetical.
- Added new intent type for video calls (and revised old one for
audio calls), which are dispatched by the StatusBarNotifier and
received by the InCallApp.
- Update icons used, and deleted unused icons.

Bug: 16013878
Change-Id: If0a8d04e2ee6eaf8258ce6a677b22d55a584f9ab

Change-Id: Ic1eb6fc98e7f030885596c9c40f0ed4f0e34e28b
(cherry picked from commit c90543e6)

Change-Id: Ic1eb6fc98e7f030885596c9c40f0ed4f0e34e28b

Bug: 13568999
Change-Id: Ib138621e9aaee88b9f069ebc96ef3a5a914a8f01

* Modify InCallActivity to perform an animation only on a new outgoing
call
* Add an animated scrim to call_card.xml that serves as the backdrop
of the full screen animated reveal
* Add resize animation
* Add circular reveal animation

Bug: 14820894

Change-Id: Iaa7e87e8a96dcd269e444a40eadac9d912625c01

Bug: 14489962
Change-Id: I8e83cf04fc4acaefcb83fa2ea7c37d091c99f5c1

Change-Id: I3916e33e184f57bb6e58ed93a26b866d3ce0e7df