GitLab

Listen to FM -> switch to loudspeaker mode -> now go to music
player to listen to music with earphone connected, Music switches
to loudspeaker mode automatically even when the earphones are connected.

Bug 19729515
from: https://partner-android-review.googlesource.com/#/c/209191/



Change-Id: I17f84a6ceb63783ca7627eab2b8dd6bf59fe151b
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

In the saving the recording dialog box the "Discard" button is
truncated to 2 (two) letters. Currently we use the most obvious
and explicit translation of ".. .........". This can be shortened,
if required, but not to 2 letters anyway. Please provide more space.

The fix is to change the layout.

Bug 19206787
from: https://partner-android-review.googlesource.com/#/c/202243/1



Change-Id: I328783efd2cbb959b658824b683391a81e48af0c
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

[Modify]
Use a decimal comma (,) instead of a decimal period(.) when
showing frequency throughout the application.

from: https://partner-android-review.googlesource.com/#/c/201685/


Bug:19206785
Change-Id: Ib98725442186dad65b0acd93ec61798024b8413a
Signed-off-by: Tony Kuo <tony.kuo@mediatek.com>

Launch FM radio app with headset connected -> Play any channel
-> Tap on pause button -> Observe saved recordings option in options menu,
saved recording option is disabled.

Bug 19203981
from: https://partner-android-review.googlesource.com/#/c/200585/



Change-Id: Ia0ce4fe0efbdf3e4d64ffb6b573d27f068c8d260
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Launch FM radio and play -> Stop FM -> Turn on BT and connect with BT
earphone with A2DP -> Open FM and resume playing, there is no sound
output after step 4.

Bug 19171819
from: https://partner-android-review.googlesource.com/#/c/199683/



Change-Id: I01d3975387840d9356c6f80d1f411eeb8526f930
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

[FM] Only space character should not be allowed while renaming a FM channel or a recorded audio file

Launch FM app and plug in a wired headset -> Star mark a channel
to add it favorite -> Go to favorite, tap on the menu (3 dots) and
tap on rename to rename the channel -> Enter only spaces and save
the channel -> Record an audio and on the dialogue, rename it with
only spaces and tap on save, the channel names and audio files are
saved without any error message. While playing this channel, FM
notification shows no name because of the spaces

The fix is to add some condition check for showing/hiding save button.

Bug 19087268
from: https://partner-android-review.googlesource.com/#/c/198815/



Change-Id: I2ac0b81d2311eace3d5e28baca31d59d3095c8d1
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Launch FM and play a channel without a name -> Start recording
-> Stop recording and discard it -> Reboot the device -> Check
the recording name in Play Music, FM recording named as "MMddyyyy_hhmmss"
displays in Play Music.

The fix is to delete FM recording file when discarding.

Bug 19059404
from: https://partner-android-review.googlesource.com/#/c/193717/



Change-Id: I37fa949c108af175131fd08d0bbac66ef1cf4daf
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Select "Start Recording" in options menu -> Wait for SD storage
to be nearly fully occupied -> "Insufficient storage" toast
message displays and "Save recording" dialog pops up ->Tap "Save"
to save the recording -> Tap "LISTEN" to playback the recording,
"Can't play the track you requested" pops up.

The fix is to also check storage free space when handling message
MSG_UPDATE_NOTIFICATION.

bug: 19007352
from: https://partner-android-review.googlesource.com/#/c/193407/



Change-Id: I63d7e22e699cb3ddb90e32a785d5c264258b6a06
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Change-Id: Ie520e5ae119e72637f699a4f97a9e02413210972

The CL is to add jni folder in packages/apps/FMRadio.

https://partner-android-review.git.corp.google.com/#/c/193524/



Bug 18632972

Change-Id: Ib98143af4870eedd8752d28970ff2056577225db
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Merge "    [FM] Fix 18847131 There is no sound output from BT earphone while BT earphone is connected" into lmp-mr1-dev

Merge "    [FM] FM icon does not display in the notification bar when FM is playing" into lmp-mr1-dev

    Launch FM and play a channel for the first time -> Tap Star icon
    to add the channel to Favorites and then tap Star icon to remove
    it -> Go to Radio Stations and check the view, "Getting stations"
    does not show, white view displays and then search channel
    successfully.

    Bug 19000983

    Review: https://partner-android-review.git.corp.google.com/#/c/193405

Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Change-Id: I7b347a3430d3813f98241f370d32a56095d24d2b

    FM powered up -> Select "Start Recording" in options menu
    -> Tap "STOP RECORDING" and "save recording" dialog pops up
    -> Tap Home key and check FM icon in the status bar,
    FM icon will not display in the status bar.

    The fix is to update playing notification when the saving
    dialog is shown.

    Bug 19001738

    Review: https://partner-android-review.git.corp.google.com/#/c/193404

Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Change-Id: I2edd7c548c736cf58b1e8ae13da3c0b4f62ea031

    Review: https://partner-android-review.git.corp.google.com/#/c/192445

Signed-off-by: Hochi Huang <hochi.huang@mediatek.com>

Change-Id: Ic762271f980b61503ae4e1b32118bf34ad40577f

    Launch FM app and search for FM channels -> Add one of
    the channels to Favorite and rename the channel with a
    long name (60 characters or more) -> Now play the renamed
    channel and start recording the audio, stop recording and
    tap on the save button on the pop up to save the audio ->
    Start recording the audio again from the same channel, stop
    recording and tap on the save button on the pop up to save
    the audio, "<audio file name> already exists" and audio is
    not saved.

    The CL is to limit the maximum length for renaming a station
    and fix the layout issue when the station name is too long.

    Bug 18844225

    Review: https://partner-android-review.git.corp.google.com/#/c/192386

Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Change-Id: I30eb19497e3181efe5143a39b84d9c25c3ee37a6

Launch FM and play a station -> Plug out headphones
-> Plug in headphones -> Switch to speaker mode, There
is no sound via speaker.

The fix is to let FM sound output via speaker.

from: https://partner-android-review.googlesource.com/#/c/192523/3


Bug 18795162

Change-Id: I16fce6914ea0b3d463c1205708d11265925097e4
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

    [FM] The channel name will not disappear on the main screen after deleting a channel from the Favorites

    Enter FM radio -> Tap star icon to add the channel in
    the Favorites -> Rename the channel -> Tap star icon
    to delete a channel from the Favorites -> Check the name
    on the main screen, the channel name will not disappear.

    The CL is to fix the issue that gjalan reproduced.

    Bug 18847141

    Review: https://partner-android-review.git.corp.google.com/#/c/192521

Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Change-Id: Ib5339c1e956981bdbcff74767b5c422d2e4fcf8b

Merge "[FM] FM recording time will display incorrectly when recording time is beyond 60 minutes" into lmp-mr1-dev

Merge "[FM] If recording to fill up SD card, "insufficient storage" warning will not show up on the save recording dialog" into lmp-mr1-dev

Launch FM from Launcher and power up FM -> Select "Start
Recording" in options menu, check the Recording Timer Text
("00m00s" is OK) -> Wait for FM recording more than 60 minutes
(e.g. 61 minutes 20 seconds), click power key to unlock screen
and check the recording timer text in FM record, the recording
timer text will be "00m20s".

The fix is to follow SoundRecorder's way to show recording timer.

from: https://partner-android-review.googlesource.com/#/c/192375/1



Bug 18842895

Change-Id: Iefb385ab855e2e940d23632502c35bc3e27ad8a5
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

[FM] If recording to fill up SD card, "insufficient storage" warning will not show up on the save recording dialog

Select "Start Recording" in options menu -> Wait for
SD storage to be nearly fully occupied, The save recording
dialog will show up, but without "insufficient storage"
warning on dialog UI.

The fix is to show "insufficient storage" toast in this
situation.

Bug 18832487
from: https://partner-android-review.googlesource.com/#/c/192347/



Change-Id: I117c61d503349745d65fb5595c935c90c0b29e31
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Launch FM and play -> Plug out headphone quickly ->
Plug in headphone quickly -> Repeat step 2~3 several
times -> Check the FM screen, FM will not change to FM
main view after re-plugging in the earphone.

The fix is to let FM change to main activity after re-plugging
in the earphone.

Bug 18836352
from: https://partner-android-review.googlesource.com/#/c/192346/



Change-Id: Ib924356e83f794560b91e47b5b35f2087eb876d7
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Merge "[FM] "Speaker on/headset" should not be available while BT earphone is connected" into lmp-mr1-dev

Merge "[FM] PS will disappear after refreshing stations if the station is not added to Favorites" into lmp-mr1-dev

Merge "[FM] The channel name will not disappear on the main screen after deleting a channel from the Favorites" into lmp-mr1-dev

Launch FM Radio and play -> Turn on BT and connect with
BT earphone -> Enter FM again and check "Speaker on/headset"
, "Speaker on/headset" will be available.

The fix is to also check BT headset is connected or not when
enabling menu item.

Bug 18795153

from: https://partner-android-review.googlesource.com/#/c/192377/2



Change-Id: Ia6d78b85563389f193860820447273a27e76d050
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Launch FM and play a station with PS(the station is not
added to Favorites) -> Refresh channels -> After searching
out the channels and tap Back key -> Check the PS information,
PS information will disappear.

The fix is to set correct station name.

from: https://partner-android-review.googlesource.com/#/c/192378/



Bug 18842996

Change-Id: Ib691d3d1472fe032f528987173d3b186ee17bf06
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

[FM] The channel name will not disappear on the main screen after deleting a channel from the Favorites

Enter FM radio -> Tap star icon to add the channel in
the Favorites -> Rename the channel -> Tap star icon
to delete a channel from the Favorites -> Check the name
on the main screen, the channel name will not disappear.

The CL is to fix this issue.

Bug 18847141

from: https://partner-android-review.googlesource.com/#/c/192388/1



Change-Id: Ia8331caa460f3bf0036c3470705e37d8aaf14e5a
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Select "Start Recording" in options menu -> Press "Home"
key, drag-down notification bar -> Tap "stop recording"
button -> Check the screen, "Save recording?"dialog will
not pop up.

The fix is set different intent actions to distinguish
which intent is called at onNewIntent(). If clicking stop
button, need to stop recording.

Bug 18849361
from: https://partner-android-review.googlesource.com/#/c/192387/



Change-Id: I229c8cf7c44c7a9ba3b2ba752a47cbcda4690b37
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Select "Start Recording" in options menu -> Stop
recording and "Save recording" pops up -> Rename
the recording file to contain "%" -> Save recording
and tap "LISTEN", Saved recording file can not be played
and "Couldn't play the track you requested." displays.

The fix is to encode the record name.

from: https://partner-android-review.googlesource.com/#/c/192398/1



Bug 18849397

Change-Id: I2b58dad093865845fd598483e96775a192946c4c
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Launch FM and play -> Tap stop button to stop playing
-> Tap stop button to resume playing -> Check the audio
when tapping stop button in step 3, there is a pop noise
when tapping start button to resume playing.

The fix is to check if it needs to ignore first three frames
of audio data from AudioRecord to avoid pop noise.

from: https://partner-android-review.googlesource.com/#/c/192415/2



Bug 18809647

Change-Id: I09ffc058ee3e87296e8d3d98fc2909ec77046e1d
Signed-off-by: Benson Huang <benson.huang@mediatek.com>

Select "Start Recording" in options menu -> Press "Home"
key -> Enter Settings/Storage/Unmount SD card/OK ->Check
the notification bar after unmounting SD card, FM icon will
disappear after unmounting SD card.

The fix is to add the handling of message
FmListener.LISTEN_RECORDSTATE_CHANGED.

Bug 18861474

From: https://partner-android-review.googlesource.com/#/c/192419/1



Change-Id: I39abee765f6eab77865fb1fdb145fb1fb7eb23fe
Signed-off-by: Benson Huang <benson.huang@mediatek.com>