GitLab

Change-Id: Id484113b00cbae0a841e696d35ff7f00efc84e18
Auto-generated-cl: translation import

Bug: 22233200

Avoid repeatedly resetting text size to maximum, due to repeated
onMeasure calls.

Suppress text size change animation when the application is restarted.

Change-Id: Ic8b20deab2553176260051fa787416654bf0b3ef

Change-Id: I61ed5c14a41c3d5bc5436dcdb860de5254fe461a
Auto-generated-cl: translation import

Bug: 23728152

This avoids the one case in which we displayed neither a decimal
point nor an exponent, and the decimal point was not just to the
right of the number.

Remove a redundant test, which obscured the logic.

Add a couple of suggested manual tests that helped me find a
(newly introduced, not submitted) bug.

Change-Id: Iead1efa0a4e8ea74512e9e1f77334f80bbcdd202
(cherry picked from commit 73ecff20)

Bug: 21470513

Prevent timeout message from disappearing on rotation.
Have long timeout setting survive rotation.  Following Justin's
suggestion, associate it with a given expression and reset when
expression is cleared.

This does mean that when you rotate a device displaying an expensive-
-to-compute result, the device will initially display the formula for
several seconds, before it redisplays the result.  Previously you
had to reenable the long timeout.  Neither is 100% ideal.

Change-Id: Ibf8e151dd37ebadf1e86adee4718e8fa8f66b975
(cherry picked from commit 5e6a0ca2)

Bug: 22931305

When the calculator is in result mode, cause a typed function name to
clear the display, just as touching the function on the screen would.

Change-Id: I77c69737a571ad8d2e6396fa3f34d5ada324fee4
(cherry picked from commit 5d79d107)

Bug: 22836179

Handle + or - operators specially if they are followed by a constant
or pre-evaluated expression and the % operator.

Since this is basically an idiomatic use of the operators, we
apply it very conservatively.  When in doubt we use the old
interpretation.

Also fixes one unrelated anachronism in a comment.

Change-Id: I2f9fd26dd6c0456f0210815ef2bc1afca3a2b4d7
(cherry picked from commit 8afd0f85)

Bug: 22917707

Make a constant consisting of just a decimal point produce an error
when evaluated.

Change-Id: I970c8b396894f301553171dad3c325ffac09ff57
(cherry picked from commit fa5203c0)

Bug: 24811759
Bug: 22047258

Add code to actively prevent ...99999 from getting turned back into
...00000 .  This may have been imposssible anyway, but I couldn't
prove it.

Add tests for some Evaluator static functions, including the new
unflipZeroes().

Fix a minor bug in exponentEnd() discovered in the process.
The logic for limiting exponent length was wrong.

Remove some no longer needed code to force a reevaluation.

Generalize getPadding() function to repeat() and make it static.
Remove leadingZeroes() which is no longer used.

Make getMsdIndex() return the correct result even if it has changed
due to reevaluation.

Change-Id: Id457d8327ce0bc184d72ef78ddd3dbdaab7c6c78
(cherry picked from commit 7a432880)

Bug: 23224425
Bug: 23695835

This adds a "cleared" announcement when last token/character is deleted.
Also change the existing "clear" announcements to "cleared".

Improve the comments for desc_clr and desc_del to address prior
misunderstandings.

Improve xml comment formatting consistency.

Change-Id: Ibe5197ceac132b73d72f8ace3982238249f5e82b
(cherry picked from commit db6f9997)

Bug: 24575798

Make factorial(0) return 1, as intended.
Add a few factorial tests.
Fix targetPackage spec so test is actually runnable again.

Change-Id: Ibb8d827f0325999c6b5ed49a939e1532ddf55639
(cherry picked from commit 69515918)

Bug: 24811759

Add the following documentation files:

arithmetic-overview.html describes the approach used to get "exact"
arithmetic.

implementation-overview.html outlines the major parts of the
implementation.

Change-Id: I3c8645aabbc5fb8aa894372a1eea0b5aad4a6473
(cherry picked from commit dd895bca)

Bug: 24811759
Bug: 21469726
Bug: 23080519

Reformat to 100 columns.  Reformat simple if-statements and rename
variables for better consistency with coding conventions.

Switch many comments to javadoc style.

Consistently use signum() to compare to zero.  It's more concise and
probably slightly more efficient.

Change the asBigInteger implementation to use a single
divideAndRemainder call instead of relying on gcd. Add tests.

Eliminate redundant test in maybeReduce().

Change-Id: I4c275494e076612d09a05bc317c9972008619cda
(cherry picked from commit a4511f34)

Bug: 24811759
Bug: 21960281
Bug: 22047258

No substantive changes.

Reformat to 100 columns.

Correct and/or remove obsolete comments and occasional bits of clearly
dead code.

Better follow coding conventions.

Rename variables for both internal consistency and consistency with
other files.  This included a few renamings in Calculator.java
and CalculatorResult.java, and a comment fix in CalculatorResult.java.

Rename public fields per coding convention.  Correctly declare more
nested classes static.

Document FIXME issues to be addressed in followup CL.  This includes
a careful look at the msd computations.  I cannot construct any
failing examples, but I also cannot currently construct a correctness
argument.

Change-Id: I5c67493eeb7730edb4b3ca3ba1cb8b7d2b87dbc2
(cherry picked from commit abe2862b)

Change-Id: I3634105b46b3a4410a88c8041cecb8a77bfd8ff7
Auto-generated-cl: translation import

* commit '80018c88':
  Properly reserve display space for non-digits

Bug: 22882700

We did not correctly calculate the extra space we might need to add
a decimal point to a scientific notation results.  We also
incorrectly assumed that minus signs are the same width as a
digit. As a workaround we now reserve extra space for the possible
non-digit characters to ensure that a result is never inadvertently
truncated.

Change-Id: I79b499121703cd51bbbf3e1d85b2285a2dd5e025

* commit '9fd976e4':
  Import translations. DO NOT MERGE

Change-Id: I2cb5501fd2278919ccbc2d4168bf85ce99cc27d0
Auto-generated-cl: translation import

Change-Id: I34d56cc0f6022088837820b7452ff84637355dad
Auto-generated-cl: translation import

* commit '82e5a2f6':
  Avoid starting long uninterruptible computations

Bug: 21957088

Shorten timeouts.

We usually do short computations first, so this helps to avoid
starting absurdly big ones.

Check size of result before converting to decimal.  If the decimal
conversion is likely to time out anyway, just pretent we timed out.
This turns out to avoid a lot of problems, since BigInteger decimal
conversion is the clear bottleneck for something like 100000!
And its uninterruptible.

Remove the timeout in one case in which we had previously forgotten.

Check for interrupts in a couple of more places in BoundedRational.
One of these caused log(10^100000) to hang for a long time.

One or two trivial cleanups in code that was touched anyway.

Change-Id: I3494a8ed28f681fb26634ecd90042e2f2a8008a8

* commit '8a4f81c5':
  More correctly pronounce advanced operators in Talkback

Bug: 19190211
Bug: 19202945
Bug: 21052751
Bug: 19165054
Bug: 22594908

Add TtsSpans for operators that are otherwise misread by TalkBack.
Force correct reading for some individual characters.

This greatly improves Talkback for advanced operators in Calculator.

This is imperfect. There is no guarantee that the strings I'm
using will work in all languages.  But they're almost certainly better than
what we have now.  And it makes parentheses and factorial usable,
though perhaps a bit verbose.

We also no longer pronounce "sine" as "sin".

Removed some now obsolete TODO comments.

Change-Id: I5236f682be828699e08dca04ee6fa073269964f6

* commit '22c0a189':
  Import translations. DO NOT MERGE

Change-Id: Ie444e4259eb75707b8549ee4e62f25844f897736
Auto-generated-cl: translation import

* commit 'ae807e1d':
  Force reevaluation if mChangedValue is true

Bug: 22481292

This could result in display of an old result.

Factor out code to start a result evaluation.

Change-Id: I651d4386323c0abd7a86176b386072093345a1b1

Change-Id: Ic4484a9655f7ace9bf03b310b6ee97ac5819c185
Auto-generated-cl: translation import

* commit '0b9806f6':
  Support pasting of scientific notation numbers

Bug: 21470972

Support pasting of numbers using scientific notation with 'E'.  This
is intentionally very restricted to dodge ambiguities with the
constant e.  We only accept a scientific notation constant if it is

1) Contained within a single pasted text element.
2) Uses capital 'E' to introduce the exponent.
3) Does not contain an explicit '+' in the exponent.

We do currently use the same notion of 'digit' as elsewhere, i.e.
Character.isDigit(), which might be too general.

For consistency, and to make sure that we can recognize machine
generated output, this also adds a few more aliases for text input
of arithmetic operators.

For consistency, always use 'E' internally for scientific notation as
well.

We ensure that a pasted numeric string is not concatenated with
a pre-existing constant.  This is a judgment call, but it means
that pasting a previous calculator result gets similar treatment
whether or not we are still running the same calculator instance.

We support limited editing on exponents.  Once an exponent is deleted,
the only way to restore it is via pasting.  The 10^x button
produces similar results, though with different operator precedence
behavior.

Change-Id: I2d0f3dceb641cdad327fd3c3540b5eea38030146

* commit 'a8f47d36':
  Have TalkBack announce results and formula changes