GitLab

* commit 'ca9a5ad0':
  BoundedRational.java cleanup

* commit '492d496d':
  Evaluator.java and CalculatorExpr.java cleanup

* commit '114e08db':
  BoundedRational.java cleanup

* commit 'b13daf10':
  Evaluator.java and CalculatorExpr.java cleanup

Bug: 24811759
Bug: 21469726
Bug: 23080519

Reformat to 100 columns.  Reformat simple if-statements and rename
variables for better consistency with coding conventions.

Switch many comments to javadoc style.

Consistently use signum() to compare to zero.  It's more concise and
probably slightly more efficient.

Change the asBigInteger implementation to use a single
divideAndRemainder call instead of relying on gcd. Add tests.

Eliminate redundant test in maybeReduce().

Change-Id: I4c275494e076612d09a05bc317c9972008619cda
(cherry picked from commit a4511f34)

Bug: 24811759
Bug: 21960281
Bug: 22047258

No substantive changes.

Reformat to 100 columns.

Correct and/or remove obsolete comments and occasional bits of clearly
dead code.

Better follow coding conventions.

Rename variables for both internal consistency and consistency with
other files.  This included a few renamings in Calculator.java
and CalculatorResult.java, and a comment fix in CalculatorResult.java.

Rename public fields per coding convention.  Correctly declare more
nested classes static.

Document FIXME issues to be addressed in followup CL.  This includes
a careful look at the msd computations.  I cannot construct any
failing examples, but I also cannot currently construct a correctness
argument.

Change-Id: I5c67493eeb7730edb4b3ca3ba1cb8b7d2b87dbc2
(cherry picked from commit abe2862b)

* commit '6ddeb1d3':
  Import translations. DO NOT MERGE

* commit '51fc9bdd':
  Import translations. DO NOT MERGE

Change-Id: I3634105b46b3a4410a88c8041cecb8a77bfd8ff7
Auto-generated-cl: translation import

* commit 'dc0767d3':
  Properly reserve display space for non-digits

* commit '63bd424a':
  Properly reserve display space for non-digits

* commit '80018c88':
  Properly reserve display space for non-digits

Bug: 22882700

We did not correctly calculate the extra space we might need to add
a decimal point to a scientific notation results.  We also
incorrectly assumed that minus signs are the same width as a
digit. As a workaround we now reserve extra space for the possible
non-digit characters to ensure that a result is never inadvertently
truncated.

Change-Id: I79b499121703cd51bbbf3e1d85b2285a2dd5e025

am 86ab81d5: (-s ours) am a629d7d2: (-s ours) am 9fd976e4: (-s ours) Import translations. DO NOT MERGE

* commit '86ab81d5':
  Import translations. DO NOT MERGE

* commit 'e090d831':
  Import translations. DO NOT MERGE

* commit 'a629d7d2':
  Import translations. DO NOT MERGE

* commit '84d6b6d2':
  Import translations. DO NOT MERGE

* commit '9fd976e4':
  Import translations. DO NOT MERGE

Change-Id: I2cb5501fd2278919ccbc2d4168bf85ce99cc27d0
Auto-generated-cl: translation import

Change-Id: I34d56cc0f6022088837820b7452ff84637355dad
Auto-generated-cl: translation import

* commit '2a3b06bd':
  Avoid starting long uninterruptible computations

* commit '51f5acc6':
  Avoid starting long uninterruptible computations

* commit '82e5a2f6':
  Avoid starting long uninterruptible computations

Bug: 21957088

Shorten timeouts.

We usually do short computations first, so this helps to avoid
starting absurdly big ones.

Check size of result before converting to decimal.  If the decimal
conversion is likely to time out anyway, just pretent we timed out.
This turns out to avoid a lot of problems, since BigInteger decimal
conversion is the clear bottleneck for something like 100000!
And its uninterruptible.

Remove the timeout in one case in which we had previously forgotten.

Check for interrupts in a couple of more places in BoundedRational.
One of these caused log(10^100000) to hang for a long time.

One or two trivial cleanups in code that was touched anyway.

Change-Id: I3494a8ed28f681fb26634ecd90042e2f2a8008a8

* commit '70f49ecd':
  More correctly pronounce advanced operators in Talkback

* commit '9d75c1ac':
  More correctly pronounce advanced operators in Talkback

* commit '8a4f81c5':
  More correctly pronounce advanced operators in Talkback

Bug: 19190211
Bug: 19202945
Bug: 21052751
Bug: 19165054
Bug: 22594908

Add TtsSpans for operators that are otherwise misread by TalkBack.
Force correct reading for some individual characters.

This greatly improves Talkback for advanced operators in Calculator.

This is imperfect. There is no guarantee that the strings I'm
using will work in all languages.  But they're almost certainly better than
what we have now.  And it makes parentheses and factorial usable,
though perhaps a bit verbose.

We also no longer pronounce "sine" as "sin".

Removed some now obsolete TODO comments.

Change-Id: I5236f682be828699e08dca04ee6fa073269964f6

am 432f67c4: (-s ours) am d28d46e3: (-s ours) am 22c0a189: (-s ours) Import translations. DO NOT MERGE

* commit '432f67c4':
  Import translations. DO NOT MERGE

* commit 'd28d46e3':
  Import translations. DO NOT MERGE

* commit '22c0a189':
  Import translations. DO NOT MERGE

Change-Id: Ie444e4259eb75707b8549ee4e62f25844f897736
Auto-generated-cl: translation import

* commit '3fa10288':
  Force reevaluation if mChangedValue is true

* commit 'b9762f77':
  Force reevaluation if mChangedValue is true

* commit 'ae807e1d':
  Force reevaluation if mChangedValue is true

Bug: 22481292

This could result in display of an old result.

Factor out code to start a result evaluation.

Change-Id: I651d4386323c0abd7a86176b386072093345a1b1

* commit '9942e6f2':
  Import translations. DO NOT MERGE

* commit '3c46e939':
  Import translations. DO NOT MERGE

Change-Id: Ic4484a9655f7ace9bf03b310b6ee97ac5819c185
Auto-generated-cl: translation import