GitLab

Bug: 25895834

ag/811037 left a bug in place that this change addresses.

Specifically, if a one-time alarm is missed, an entry is left in
the alarm_instances table with a state of MISSED. The query's
join clause would not return a row for the alarm in this case.

A subselect is now used to return the alarm_instances row with
the smallest state value. This means:

 - SILENT instances are preferred over MISSED instances
 (the only case where 2 instances exist for the same alarm).
 - MISSED instances are returned if they are the only instance for
 an alarm (the above case)

Change-Id: I31de6d8b2d2bf7719f6b027a2401b1da1a09f247

Bug: 24341005
Change-Id: I558c6d15316c9391ae57b96b7324ebdf1eddc29e
(cherry picked from commit 09e29779)

Bug: 25695607
Change-Id: I41c20a905566f36827b433631baee97362ad7d02

Change-Id: I93002905a560686d0bbdc6535c4fe3506da45526
Auto-generated-cl: translation import

TimerIntentsTest actually caught this bug. The intent to show
the timer tab requested that a freshly deleted timer be displayed.
This can produce exceptions if it was the last timer.

When a timer is deleted, the timer tab can be shown but no
specific timer should be requested for display.

Change-Id: I7024fbe5a154d5ecb8d563c80c09044d3917ab50

Change-Id: I573d63871f3c2ad4949131c9419a32ff0f24b8b9
Auto-generated-cl: translation import

In order to sidestep b/25872174 it was agreed that code attempting
to show the "Night mode" menu item on just the clock tab would be
removed.

Change-Id: I842b093c7d206dc8e42a6a85bbd487dd9a235942

Bug: 24496589
Change-Id: Ic79b44e47824e3a1a494f28b87d2dde9a0a0d9f9

Bug: 24496589
Change-Id: I3bc06064fd13dfdefc91db04cfe678ee7e840645

Bug: 25843144

Attempting to view a specific timer trumps the timer setup screen
in all cases. onResume() now enforces that policy. The timer setup
screen is still displayed in all other cases, including:

- no timers exist
- the intent indicates a new timer should be created
- the last visible timer screen was the timer setup screen

Change-Id: I28d147cadeb29055fa0c68a44da6648f6ad33238

Change-Id: Ic357a1d328f780b68a8c9ff48d49086f830c6d9e
Auto-generated-cl: translation import

Bug: 25302368

The bug was already fixed as part of b/19651361 but I wanted to
add the reported use case to the corpus for better regression
testing.

Change-Id: I51f80cfbbae01681b018d249de56d0d39b4122d2

Bug: 25780110
Change-Id: I454ee709d296c7a2860281b2e981476608df1e57

Bug: 25779786

The issue here is that TimerSetupView actually customizes the fab.
These customizations include setting it invisible. It was a poor design
to share the fab with this view. So, the fix is that the view now holds
its own fab-like button that it is free to manipulate without fear of
altering the app-wide fab state unintentionally.

Change-Id: Ie83b03c98db4f77e0be912b122b6f74c2c7e6c8a

- add precision to some wording for translators
- update widget provider XML layout

Change-Id: I78d7d29b2ed2ea4768c0e36d125b38df971c1484

Change-Id: Ife7cf799c6d9ca5cf15deff3337526295fdf19b5
Auto-generated-cl: translation import

Bug: 24977472

By default, the menu is inflated after the first draw. A proactive
call to Toolbar.inflate(...) during creation defeats this default
behavior.

A second problem is that the menu that is inflated by default for
DeskClock contains the search menu item which is briefly shown.
By defaulting that menu item to be invisible and only making it
visible when its corresponding controller exists, the
dancing/flashing effect is avoided.

Change-Id: I933ab9a59b471abe26e1cf07385e4a4c128d1808

Bug: 25706729
Change-Id: Idf41102e733c5056f98ac4873a5b1dde442ffefe

Change-Id: I9474d45596185cb75b9f7cf061948d862a7ea7e7
Auto-generated-cl: translation import

Change-Id: I59086de027fc696976811b25303c5374523cbf86
Auto-generated-cl: translation import

Merge "Simplify HandleDeskClockApiCalls, TimerService and StopwatchService" into ub-deskclock-dazzle

Bug: 25121359

Calling Activity.recreate() while the activity is paused will create
a new copy of the activity that remains paused, even if it is the
foreground activity.

To work around this, we delay recreating the activity until after
it identifies as being resumed. This produces a noticeable flash
but is far better than the alternative...

Change-Id: Iae770a25fb5b6f80d50a321a0f2f4cd792eceb10

HandleDeskClockApiCalls used to pass through all timer and stopwatch
mutations to the corresponding Service to complete. This complicated
the logging of the corresponding event unnecessarily.

After this change:

- StopwatchService is only invoked from stopwatch notifications and may
now assume the event label

- TimerService is only invoked from timer notifications and AlarmManager
and may now assume the event label

- HandleDeskClockApiCalls.EXTRA_FROM_NOTIFICATION has been replaced
with HandleDeskClockApiCalls.EXTRA_EVENT_LABEL which explicitly
identifies the label of the event

Change-Id: Ic9796c43e826f82138ee431d3abb02524c0146ba

Bug: 25177293

If the default system alarm ringtone is invalid or malformed then
RingtoneManager will return a null Ringtone. In which case we now
fallback to playing our own internal alarm ringtone.

Change-Id: I1beeec0fc8998ad684e67062ffc0fd0d03f66f68

Change-Id: Ibe429ba988a8842715c8732b4524eefb2655f7e4

Bug: 25630846

Change-Id: I3a7566f6ef2c20ceb487e864fde0f0d12582f8cc

Bug: 24816218
Bug: 25494722

This refactoring introduces a Timer domain object. Instances of these
domain objects are fetched via a DataModel class that is the single point
of reference for all timer data. This allows the data to be shared across
the entire application. In particular, the timer notifications, TimerFragment
and ExpiredTimersActivity all draw upon the same model to determine
what the state of the timers are.

IMPORTANT: The public intent com.android.deskclock.action.STOP_TIMER
has been renamed to com.android.deskclock.action.PAUSE_TIMER to be
more accurate.

Change-Id: Ib904e80a25c6de1861de2b395bec27db16ff0e66

Bug: 25631044

The clock tab animation was noticeably longer than the other
tab animations. Some rotations were removed to shorten its
duration. Also, animated vectors are v22+, so the resource files
were moved into /animator-v22 to fix some lint warnings.

Change-Id: I90b116df2a3cc7a30bdd69b8e478207dd3f016fb

Bug: 17903090

When an alarm is missed the alarm_instances table actually contains two
entries for the same alarm.

- one represents the missed alarm
- one represents the next upcoming alarm

The query that joins alarm_templates to alarm_instances would return
two rows for the same alarm in this case. Since the alarm_instance data
is used offer a predismiss button in the UI, it is fine to ignore the
missed alarm in this join.

Change-Id: I720e48c9274b42d3cda9d57d3eef099c5dcd3902