GitLab

Change-Id: I50cde90d32448fa3afbe80a2b13c619a6eeaa89f

Change-Id: Ib97b5af9d196b5b73451e19c0cb11be798995f1d

The IconListenerSet inside CombinedBookmarkHistoryActivity is static. So when
the activity is destroyed, it needs to remove its listener to avoid leak.

pauseWebView(). But as mActivityInPause is false, pauseWebView doesn't do
anything. This cause inbalanced pause/resume and the WebCoreThread's timer
is never put on hold even Browser is in the background.

early bail out in onCreate(). This should avoid the NPE we saw in onResume.

current window instead of a new window.

When we made the bookmark permissions public, we also changed their
names, which might break existing apps.  Change them back.  Depends
on a change in frameworks/base.

When opening a new tab from the context menu, treat the new tab as a child of
the current tab. This change was cherry-picked from master.

This change was previously made in master, but I believe it is
responsible for a crash.  We should not be using this deprecated
method, so I am now instead using ContentResolver.update().

Check for a null tab in onDestroy. This fix is in master but the crash appears
in donut as well.

* changes:
  Fix #1953520. When MENU is down, consume the key in the BrowserActivity which are not shortcut keys. So it won't trigger the search panel. If a shortcut action is taken, reset the mMenuIsDown as it has been used once.

Fix #1953520. When MENU is down, consume the key in the BrowserActivity which are not shortcut keys. So it won't trigger the search panel. If a shortcut action is taken, reset the mMenuIsDown as it has been used once.

Before, android:searchSettingsDescription was set in searchable.xml,
but not in bookmarks_searchable.xml, which is the one that
is used from global search.

Fixes http://b/issue?id=1971319
"Description string for Browser source not showing in settings"

This is dependant on change https://android-git/g/6623
Bug: http://b/issue?id=1865037

Fix 1970279. Like "Go", search key should get the current url and pre-fill it in the search/goto widget.

* changes:
  Add new searchSettingsDescription attribute for Browser's searchable. This will be shown under the individual searchable item in system search settings.

This will be shown under the individual searchable item in system search settings.

Fix #1947053. Use EXTRA_POST_DATA to send POST request to the WebView. This is used for sending location now.

Per Leland's requst, change "Set text size" to "Text size" and etc.

Fix #1705293. When we about to hijack the url, we check the intent first. If it is not resolved to any activity, we will try to download it from the Market.

* changes:
  Return the url of a browser history item in the intent query column of the suggestion. This is so that global search can rewrite a query in the search dialog (i.e., fill in the search box with the url of the suggestion when the user rolls over to select the suggestion). Browser uses android:searchMode="rewriteQueryFromData" to accomplish this but global search does the default thing of using the intent query column, if present, as a rewrite for the current query.

suggestion. This is so that global search can rewrite a query in the search
dialog (i.e., fill in the search box with the url of the suggestion when the
user rolls over to select the suggestion). Browser uses
android:searchMode="rewriteQueryFromData" to accomplish this but global search
does the default thing of using the intent query column, if present, as a rewrite
for the current query.

This got missed when we made the change to invoke the system default web search handler instead of the browser directing all searches to Google. This makes sure that the receiving web search providers can pass on the source parameter appropriately as part of the results page that they launch.

* changes:
  Fix 2 NPEs in the Browser.

The first was from freeMemory getting a tab back that had already been freed.
This is a really hard case to reproduce but it appears that it can happen. So
just check for a null mMainView before trying to free the tab.

The second was a null mTabOverview during the onAnimationStart method when
animating to the tab overview. I think this is caused by message delays not
being accurate enough to ensure the overview has been created. A check for null
fixes the problem for now but I am working on a better solution to ensure
animation message order.

Depends on change https://android-git.corp.google.com/g/4775,
which adds bookmark permissions the the public API.  This
change removes the old private permissions and uses the
new public ones.

This changes the browser's URI->intent processing to use the new generic
"intent:" scheme supported by Intent.  Doing so allows the user to
provide links to arbitrary intents in a web page.  The browser restricts
which intents can actually be execute to those supported by the
BROWSABLE category by adding this to the resulting Intent and making
sure there is no explicit component in the Intent.

With the addition of package-specific Intents, this allows people to
have a link that is guaranteed to launch an activity in their own
package, not allowing others to intercept it.