Commit b011709b authored by Paul Miller's avatar Paul Miller Committed by Android Git Automerger
Browse files

am 28994826: am f88fc286: Merge "Show JS alerts over their origin tab"

* commit '28994826':
  Show JS alerts over their origin tab
parents 76ec5b74 28994826
......@@ -52,6 +52,8 @@ import android.webkit.CookieManager;
import android.webkit.GeolocationPermissions;
import android.webkit.GeolocationPermissions.Callback;
import android.webkit.HttpAuthHandler;
import android.webkit.JsPromptResult;
import android.webkit.JsResult;
import android.webkit.PermissionRequest;
import android.webkit.SslErrorHandler;
import android.webkit.URLUtil;
......@@ -788,6 +790,27 @@ class Tab implements PictureListener {
}
}
@Override
public boolean onJsAlert(WebView view, String url, String message,
JsResult result) {
mWebViewController.getTabControl().setActiveTab(Tab.this);
return false;
}
@Override
public boolean onJsConfirm(WebView view, String url, String message,
JsResult result) {
mWebViewController.getTabControl().setActiveTab(Tab.this);
return false;
}
@Override
public boolean onJsPrompt(WebView view, String url, String message,
String defaultValue, JsPromptResult result) {
mWebViewController.getTabControl().setActiveTab(Tab.this);
return false;
}
@Override
public void onProgressChanged(WebView view, int newProgress) {
mPageLoadProgress = newProgress;
......
......@@ -674,6 +674,12 @@ class TabControl {
return true;
}
// Used by Tab.onJsAlert() and friends
void setActiveTab(Tab tab) {
// Calls TabControl.setCurrentTab()
mController.setActiveTab(tab);
}
public void setOnThumbnailUpdatedListener(OnThumbnailUpdatedListener listener) {
mOnThumbnailUpdatedListener = listener;
for (Tab t : mTabs) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment