- 09 Dec, 2013 5 commits
-
-
Kenny Root authored
-
Kenny Root authored
newInstance should not call supportsParameter since they're not the same thing. It is type-specific how the parameter is used, so it's not necessarily the parameter used for the constructor. The constructor type supplied to newInstance is only used for CertStore, but CertStore does not support the supportsParameter call. This was causing CertStore-related tests to fail since newInstance called into supportsParameter. Additionally, to make sure we throw the correct exceptions, we need to keep a list of valid parameters for all the types we know about. Right now this just means moving the special case that existed before into a HashMap and adding null entries for the other types we know about. Adding the null types allows the disambiguation from types we don't know about so we can throw an exception when a constructor parameter is supplied to a type that should not take one. Change-Id: Ia1755481df1bfa9f76dc4cf7eee5c966a8019396
-
Kenny Root authored
-
Kenny Root authored
The parameter could still be null at this point, but it should not be accepted since null obviously wouldn't match one of the given key classes or formats. Change-Id: I0ab4d6dc0d805232bf1b487320802b7a910ccc16
-
Narayan Kamath authored
-
- 06 Dec, 2013 4 commits
-
-
Narayan Kamath authored
All functions delegate directly to the native code. We do not perform any sort of central directory or local file related lookups in the java layer. For each entry, libziparchive gives us an offset to the start of data for the entry and the compressed size. We use a RandomAccessFile to seek to that offset and then construct an InputStream that's bounded between [offset, offset + compressed_size). We reuse existing code (JarVerifier / Manifest) for certificate validation & collection. bug: 10193060 Change-Id: I21eb4e6dc6aa8749e3f63830f9799e1f621d26e6
-
Narayan Kamath authored
-
Narayan Kamath authored
The returned class didn't override the full set of SignatureSpi methods, meaning that some method calls wouldn't be sent down to the SPI delegate. Also add some missing @Override annotations, remove pointless comments and make a private field final. bug: https://code.google.com/p/android/issues/detail?id=63139 Change-Id: I00762213a4afad0dc69e385105043b01aa77bb95
-
Kenny Root authored
-
- 05 Dec, 2013 7 commits
-
-
Kenny Root authored
First step in late-binding support. This will be used later to support late binding by rejecting possible providers using the supportsParameter call. This allows security providers to specify attributes in their registration that allow the Security framework to filter them out earlier instead of failing on instantiation. The attributes supported in this change are SupportedKeyClasses and SupportedKeyFormats. Change-Id: Iee954e2b6c95c41d3b45aa738e869471fbe14341
-
Ying Wang authored
-
Narayan Kamath authored
-
Xizhi Zhu (Steven) authored
The previous implementation leaves a chance for timing attacks. Change-Id: I7db4ca25de0ed89723af37655e1a25e15750fd31 Signed-off-by:
Xizhi Zhu <xizhi.zhu@gmail.com>
-
Brian Carlstrom authored
-
Xizhi Zhu (Steven) authored
Duplicated words in the doc. Change-Id: Ic400197781f1dea114e3755dc630c8dc58696fc2 Signed-off-by:
Xizhi Zhu <xizhi.zhu@gmail.com>
-
Ying Wang authored
With this change, libcore_to_document will be evaluated only once. As a side effect, this fixes the build log spam reported in: https://code.google.com/p/android/issues/detail?id=63184 Change-Id: I4fcfbcd70f6d4b119487525825aeafa2926507b4
-
- 02 Dec, 2013 2 commits
-
-
Narayan Kamath authored
-
Narayan Kamath authored
The object doesn't override equals & hashCode so it needs a serialization comparator. Change-Id: Ie6067ad1e6cd22f5e2b83907e5bf2ea0039466cb
-
- 28 Nov, 2013 4 commits
-
-
Narayan Kamath authored
-
Narayan Kamath authored
Whitespace issues. Change-Id: I12bf6134c9bdd060ab5362f97d2315471ecd7251
-
Lorenzo Colitti authored
-
Lorenzo Colitti authored
These are defined in RFC 3549 (netlink) and will be used, for example, to determine whether an IP address has global scope. Bug: 9180552 Change-Id: I7e712cdd0bcb0dd7b24eb2e46b4205ad96b42164
-
- 27 Nov, 2013 9 commits
-
-
Alex Klyubin authored
-
Mathieu Chartier authored
-
Narayan Kamath authored
-
Narayan Kamath authored
Check for the nio canonical name instead of the "old" canonical name. bug: 11665359 Change-Id: Icc813a77cfb7d61ddb0ce33fbdf48ccbe0ded7fb
-
Narayan Kamath authored
-
Narayan Kamath authored
These tests were added in commit 5ec6bf8d and were assumed to have been caused by an ICU bug. They were in fact caused by bugs in our ICU glue code and those issues have now been fixed. Change-Id: Ia21a5b466eea685f175fa370d9e2b3b3342cd1b8
-
Narayan Kamath authored
-
Narayan Kamath authored
-
Narayan Kamath authored
-
- 26 Nov, 2013 9 commits
-
-
Elliott Hughes authored
-
Elliott Hughes authored
Bug: https://code.google.com/p/android/issues/detail?id=62539 Change-Id: If41b9afe801832ea796649d27b0af25657653684
-
Alex Klyubin authored
Change-Id: I806cfd4fd7f8be39c9bfcce956f6c2804e917c26
-
Narayan Kamath authored
- NativeConverter should report unterminated character sequences to managed code. - CharsetDecoderIcu should report those errors correctly from flush() - InputStreamReader should check the return value of flush() and not ignore it altogether. bug: 11665359 bug: 10729779 Change-Id: Ic678a645a4ef2b3fe70e2c900c0cd393679f1037
-
Narayan Kamath authored
Deal with truncated char sequences correctly. bug: 10729779 Change-Id: I232b0ec899084270a6d621e6c7292ef8b94f8f7d
-
Narayan Kamath authored
Fix path to test resource. bug: 11665359 Change-Id: Id360215499bc20620c096a3f0a4e85970e606c2b
-
Narayan Kamath authored
-
Mathieu Chartier authored
Used to know when to do trimming and will be used for knowing when to do compaction. Bug: 8981901 Change-Id: I0f715f8c9dfc5f7399b54261fe08410449fef10e
-
Alex Klyubin authored
-