1. 15 Apr, 2015 1 commit
  2. 14 Apr, 2015 1 commit
  3. 09 Apr, 2015 4 commits
  4. 06 Apr, 2015 4 commits
  5. 16 Mar, 2015 4 commits
  6. 11 Mar, 2015 1 commit
  7. 25 Feb, 2015 1 commit
  8. 20 Feb, 2015 3 commits
  9. 10 Feb, 2015 2 commits
  10. 09 Feb, 2015 1 commit
    • Nick Kralevich's avatar
      ril.cpp: fix misuse of strncat · c52e45ed
      Nick Kralevich authored
      strncat(dest,src,size) appends size+1 bytes to the end of
      dest, so sizeof(dest) must be greater than
      strlen(dest) + size + 1. Passing the buffer size to strncat
      instead of sizeof(dest) - strlen(dest) - 1 is a common
      strncat bug. Use strlcat instead, as it has more intuitive
      behavior and ensures the buffer is properly null terminated.
      
      Addresses the following compiler warning:
      
        In file included from system/core/include/cutils/sockets.h:22:0,
                         from hardware/ril/libril/ril.cpp:24:
        In function 'char* strncat(char*, const char*, size_t)',
            inlined from 'void android::RIL_register(const RIL_RadioFunctions*)' at hardware/ril/libril/ril.cpp:4258:62:
        bionic/libc/include/string.h:199:61: warning: call to char* __builtin___strncat_chk(char*, const char*, unsigned int, unsigned int) might overflow destination buffer
             return __builtin___strncat_chk(dest, src, n, __bos(dest));
                                                                   ^
      
      (line numbers are from internal master and do not match AOSP)
      
      Even with this change, this code feels weird.
      MAX_DEBUG_SOCKET_NAME_LENGTH is 12, and rildebug is initialized to be
      SOCKET_NAME_RIL_DEBUG ("rild-debug"), which is 11 bytes including null
      terminator. The strlcat call here can append a maximum of 1 byte before
      the buffer is full. I don't know if this is intended or not.
      
      Change-Id: I49801ad1ea3aa6173bbc9fd7cf00f3d308693253
      c52e45ed
  11. 08 Feb, 2015 2 commits
  12. 03 Feb, 2015 1 commit
    • Nanik Tolaram's avatar
      Removal of dead code and adding log messages to make it easier · 4bd5eb59
      Nanik Tolaram authored
      for debugging
      
      - Add more logging using ALOGD(..) for function dispatchSmsWrite,
      dispatchDial, dispatchSIM_IO, dispatchSIM_APDU, dispatchCallForward,
      dispatchRaw and dispatchCdmaSmsAck. To make it easier for debugging.
      
      - Remove commented log message inside wakeTimeoutCallback () function
      and remove the else clause as it's dead not used for anything.
      
      - Modify log message inside removeFromList and removeWatch using +
      and - to make it consistent with the other log message.
      
      Change-Id: Ife0212e6a4724d8b06a1dd767484bfdf98b8e1a6
      Signed-off-by: default avatarNanik Tolaram <nanikjava@gmail.com>
      4bd5eb59
  13. 23 Jan, 2015 3 commits
  14. 09 Jan, 2015 6 commits
  15. 09 Dec, 2014 1 commit
  16. 08 Dec, 2014 1 commit
  17. 04 Dec, 2014 1 commit
    • Sukanya Rajkhowa's avatar
      Modify RIL_Data_Call_Response to include MTU · b44dda3e
      Sukanya Rajkhowa authored
      Include MTU as part of RIL Data Call Response so that the
      framework uses the dynamic MTU value provided by network
      and updates LinkProperties accordingly.
      
      Upping RIL version to 11.
      
      bug:18391670
      Change-Id: I8a85d7f58c99d73278646cdcb2aa466b85ae9a81
      b44dda3e
  18. 24 Nov, 2014 1 commit
  19. 23 Nov, 2014 1 commit
  20. 22 Nov, 2014 1 commit