Skip to content

GitLab

Switch branch/tag
  1. 06 May, 2016 1 commit
  3. 05 May, 2016 1 commit
  5. 29 Apr, 2016 4 commits
  7. 14 Apr, 2016 7 commits
  9. 08 Apr, 2016 4 commits
    • Yu Ning's avatar
      reference-ril: Stop using pthread_cond_timedwait_relative_np() · 3fb9de50
      Yu Ning authored 
      am: f3769c17

* commit 'f3769c17':
  reference-ril: Stop using pthread_cond_timedwait_relative_np()

Change-Id: Id11534397b2360c2dffa00eede02a4447c6e1030
      3fb9de50
    • Jinhui Li's avatar
      reference-ril/atchannel.c: Fix time conversion · e278a4a6
      Jinhui Li authored 
      am: 99f6a4e8  -s ours

* commit '99f6a4e8':
  reference-ril/atchannel.c: Fix time conversion

Change-Id: I41ebd943fda8e72aa7eaa19c4159c441e2f1fe64
      e278a4a6
    • Yu Ning's avatar
      reference-ril: Stop using pthread_cond_timedwait_relative_np() · f3769c17
      Yu Ning authored 
      pthread_cond_timedwait_relative_np() is deprecated, and is only
available in the 32-bit ABI (see bionic/libc/include/pthread.h). It is
still used by the 32-bit version of reference-ril. Thanks to a recent
bugfix for 64-bit [1], it is now safe to replace the deprecated
function with the standard pthread_cond_timedwait(). Doing so also
simplifies the code, as there is now a unified logic for 32 and 64-bit
targets.

[1] https://android-review.googlesource.com/210301

Signed-off-by: default avatarYu Ning <yu.ning@intel.com>

(cherry picked from commit 3480b183)

Change-Id: I1a15ee0fdfea38b6ee9c9fd49845d10d45f485b1
      f3769c17
    • Jinhui Li's avatar
      reference-ril/atchannel.c: Fix time conversion · 99f6a4e8
      Jinhui Li authored 
      
setTimespecRelative() converts a relative time to an absolute time, by
adding the relative time to current system time. However, it fails to
handle the case where the nanosecond component (tv_nsec) of the
conversion result exceeds 10^9, which can cause a subsequent call to
pthread_cond_timedwait() to return EINVAL.

This bug is the root cause of the "no SIM card" error seen occasionally
on x86_64 Android emulator. In fact, all 64-bit targets use
setTimespecRelative() in conjunction with pthread_cond_timedwait()
during AT handshake, but an EINVAL return value from the latter will
lead to an infinite loop and hang the communication. With this fix,
x86_64 emulator can boot with functional 3G networking every time.
Signed-off-by: default avatarJinhui Li <jinhui.li@intel.com>
[Revised code and commit message]
Signed-off-by: default avatarYu Ning <yu.ning@intel.com>

(cherry picked from commit 11476211)

Change-Id: I5d7396ef7f0af5ef02ccab785046d635fb8f168c
      99f6a4e8
  11. 01 Apr, 2016 5 commits
  13. 31 Mar, 2016 1 commit
  15. 30 Mar, 2016 3 commits
  17. 25 Mar, 2016 1 commit
    • Jinhui Li's avatar
      reference-ril/atchannel.c: Fix time conversion · 11476211
      Jinhui Li authored 
      
setTimespecRelative() converts a relative time to an absolute time, by
adding the relative time to current system time. However, it fails to
handle the case where the nanosecond component (tv_nsec) of the
conversion result exceeds 10^9, which can cause a subsequent call to
pthread_cond_timedwait() to return EINVAL.

This bug is the root cause of the "no SIM card" error seen occasionally
on x86_64 Android emulator. In fact, all 64-bit targets use
setTimespecRelative() in conjunction with pthread_cond_timedwait()
during AT handshake, but an EINVAL return value from the latter will
lead to an infinite loop and hang the communication. With this fix,
x86_64 emulator can boot with functional 3G networking every time.
Signed-off-by: default avatarJinhui Li <jinhui.li@intel.com>
[Revised code and commit message]
Signed-off-by: default avatarYu Ning <yu.ning@intel.com>

Change-Id: If04ba560e350bc4e13b22c51f8d215a673230667
      11476211
  19. 21 Mar, 2016 2 commits
  21. 14 Mar, 2016 1 commit
  23. 12 Mar, 2016 1 commit
    • Ajay Nambi's avatar
      New error codes for SMS/other messages · 68900f5a
      Ajay Nambi authored 
      This gerrit adds error codes for messages related
to SMS and set_mute, get_mute requests

Bug: 27038563
Change-Id: I4991e4a38c81501c39e91cfd5df90d8288f542ad
      68900f5a
  25. 11 Mar, 2016 3 commits
  27. 10 Mar, 2016 1 commit
  29. 08 Mar, 2016 4 commits
  31. 05 Mar, 2016 1 commit