Skip to content

GitLab

Switch branch/tag
  1. 13 Mar, 2015 1 commit
  3. 02 Mar, 2015 1 commit
  5. 28 Jan, 2015 1 commit
    • vandwalle's avatar
      aggressively blacklist WifiConfiguration for the purpose of switching network · 4fa99f57
      vandwalle authored 
      In cases where networks are not properly configured, WiFi might tries to repeatdly
switch from one network to a bad network, or might try to roam and renew DHCP which can fail.
In KK, WiFi autojoin would try other networks (by cycling to network it sees) and
end up associated to a "good" network. In L release even thought WiFi might pick
a good network it will still repeatedly try to switch to what it thinks is a better
network and fail, thus annoying the user whose connection becomes unstable.

This CL tries to remember networks that have seen multiple DHCP or auth failure in
the past and for those networks it disable roaming temporarily.
That is, if wifi is not associated to any network, it will tries to join a network
aggressively, however if wifi is currently associated to a network, it will not try
to switch to a new network if that new network has seen multiple failure in the past.

The maximum blacklist time is set to 2 days for now.
An example of such situation is:
- user has multiple SSID at home, one of which is incorrectly configured with a wrong password
- broken DHCP situation (potentially: multiple servers on home network, broken implementation incorrecting NAK'ing DHCP requests but properly serving DHCP offer...)
Bug:18792931

Change-Id: Ib09eaaea978c772f630e86696f9a49f18ad708e2
      4fa99f57
  7. 22 Jan, 2015 1 commit
  9. 16 Jan, 2015 1 commit
  11. 14 Jan, 2015 2 commits
  13. 13 Jan, 2015 1 commit
  15. 09 Jan, 2015 1 commit
    • Vinit Deshpande's avatar
      Fix an NPE in WifiConfigStore · 537324a4
      Vinit Deshpande authored 
      Disabling an invalid configuration causes Wifi service
to crash. This change gaurds against bad API call.

Bug: 18904771
Change-Id: I8d853b754cbd4163c17f3d53bf81dc7625c95466
      537324a4
  17. 08 Jan, 2015 1 commit
    • Jeff Davidson's avatar
      Fix incorrect tracking of ephemeral network statistics. · 2c9b6297
      Jeff Davidson authored 
      The lastUntrustedBSSID variable was being used as an SSID, not a
BSSID, and was not cleared after the untrusted network was
disconnected, causing stats not to increment on new connections if the
last connection was to the same SSID.

So, remove this unnecessary variable, and check the current
WifiConfiguration to determine which network we're currently using, if
any. Increment the connection count only when we are actually going to
associate with the SSID.

This only affects untrusted network flows and should have no impact
when connecting to saved Wi-Fi networks. The only non-statistical
change involves the boost given to the active network, which is
controlled by the NetworkScorer and can be updated dynamically
(outside of the framework).

Bug: 18908655
Change-Id: I5b712a4ff613d8199d0591e568886be0d2419645
      2c9b6297
  19. 07 Jan, 2015 1 commit
    • Erik Kline's avatar
      Disconnect if we had IPv4 and lost it. · ac966790
      Erik Kline authored 
      More specifically, the DHCP_FAILURE case is entered when a
DHCPv4 RENEW fails.  Even though we would connect to a network with
no IPv4, when roaming to a "same network" and losing IPv4 it's
probably better to disconnect and start afresh.

Bug: 18867306
Change-Id: Ie667b4f0481ae0510d0dc00db819f4e5d43d98a9
      ac966790
  21. 06 Jan, 2015 1 commit
  23. 29 Dec, 2014 1 commit
  25. 22 Dec, 2014 1 commit
  27. 18 Dec, 2014 2 commits
  29. 17 Dec, 2014 1 commit
  31. 16 Dec, 2014 2 commits
    • Jeff Davidson's avatar
      Stabilize ephemeral connections in the face of new BSSIDs. · 16fdf070
      Jeff Davidson authored 
      Currently we only check whether the most recently seen BSSID has a
score before deciding to disconnect an ephemeral network. This causes
unnecessary flapping - if multiple BSSIDs are in visible range, and
the scorer likes one of them but has no score for the other (or is
still looking up the score), we will drop the connection.

Instead, as long as we've recently seen a scored BSSID (in the last
minute), we keep the connection alive.

A scorer can still initiate an immediate disconnect from an unwanted
network by nulling scores for all BSSIDs.

The timeout (and whether we use this new behavior at all) is
controlled by a Settings.Global flag.

Bug: 18637384
Change-Id: I6bde3c9eef12caf2cc51c449abffc1c69f60c17f
      16fdf070
    • vandwalle's avatar
      Disable legacy poor Network detection · 82f9342c
      vandwalle authored 
      Bug:18723206
Legacy poor network detection was removed from L settings but can still be enabled during an upgrade if it had been manually enabled by user, now really disable it.

Change-Id: I661b326c6f5dfacfcc5582cea14dc52501740367
      82f9342c
  33. 14 Dec, 2014 4 commits
  35. 12 Dec, 2014 4 commits
  37. 11 Dec, 2014 2 commits
  39. 10 Dec, 2014 1 commit
  41. 09 Dec, 2014 1 commit
    • Vinit Deshpande's avatar
      Fix an unhandled exception in WifiP2pStateMachine · 84befe36
      Vinit Deshpande authored 
      An exception is thrown when group creation is deemed failed. It is
thrown because an empty peer address is encountered. It is not clear
when the address goes empty (there are no logs); but this change
would prevent resstarting of the framework.

Bug: 18667239

Change-Id: I523646eaa1ff6c8dab9ee99b893ebc4291eee2da
      84befe36
  43. 08 Dec, 2014 1 commit
  45. 06 Dec, 2014 4 commits
  47. 05 Dec, 2014 2 commits
  49. 04 Dec, 2014 1 commit
  51. 02 Dec, 2014 1 commit