GitLab

The lastUntrustedBSSID variable was being used as an SSID, not a
BSSID, and was not cleared after the untrusted network was
disconnected, causing stats not to increment on new connections if the
last connection was to the same SSID.

So, remove this unnecessary variable, and check the current
WifiConfiguration to determine which network we're currently using, if
any. Increment the connection count only when we are actually going to
associate with the SSID.

This only affects untrusted network flows and should have no impact
when connecting to saved Wi-Fi networks. The only non-statistical
change involves the boost given to the active network, which is
controlled by the NetworkScorer and can be updated dynamically
(outside of the framework).

Bug: 18908655
Change-Id: I5b712a4ff613d8199d0591e568886be0d2419645

More specifically, the DHCP_FAILURE case is entered when a
DHCPv4 RENEW fails.  Even though we would connect to a network with
no IPv4, when roaming to a "same network" and losing IPv4 it's
probably better to disconnect and start afresh.

Bug: 18867306
Change-Id: Ie667b4f0481ae0510d0dc00db819f4e5d43d98a9

Bug:18865214

Change-Id: Iae9297cd50ebaf12217d12e4c5d55ae05316e917

This ensures that we see all requests for untrusted networks.

Bug: 18815795
Change-Id: I9aaba6095b934fee27a27b20fa3adb2a10648e80

Merge "Disable legacy poor Network detection Bug:18723206 Legacy poor network detection was removed from L settings but can still be enabled during an upgrade if it had been manually enabled by user, now really disable it." into lmp-mr1-dev

Bug:18706288

Change-Id: I27a86aeb650a63511b667244b0138afbc1bc059e

Currently we only check whether the most recently seen BSSID has a
score before deciding to disconnect an ephemeral network. This causes
unnecessary flapping - if multiple BSSIDs are in visible range, and
the scorer likes one of them but has no score for the other (or is
still looking up the score), we will drop the connection.

Instead, as long as we've recently seen a scored BSSID (in the last
minute), we keep the connection alive.

A scorer can still initiate an immediate disconnect from an unwanted
network by nulling scores for all BSSIDs.

The timeout (and whether we use this new behavior at all) is
controlled by a Settings.Global flag.

Bug: 18637384
Change-Id: I6bde3c9eef12caf2cc51c449abffc1c69f60c17f

Bug:18723206
Legacy poor network detection was removed from L settings but can still be enabled during an upgrade if it had been manually enabled by user, now really disable it.

Change-Id: I661b326c6f5dfacfcc5582cea14dc52501740367

* changes:
  fix logspam Bug:18589606
  Apply 5GHz band preference only when comparing configurations on different bands

Merge "autojoin scanning + P2P - discard autojoin scan when both infra and P2P are connected - reduce autojoin scan period when P2P is connected and infra is disconnected Bug:18692653" into lmp-mr1-dev

Bug:18589606

Change-Id: Ieee0b91ab96ec9392a9b91ac1017a319605425dc

Bug:18703749

Change-Id: If6452e7dbaaabb164cf2a99b48b3964f4cb86ee5

Bug:18589301

Change-Id: I0093620c859940d993c9ea60d9d6cdc86bb2fa58

- discard autojoin scan when both infra and P2P are connected
- reduce autojoin scan period when P2P is connected and infra is disconnected
Bug:18692653

Change-Id: Id1891e6a9f2863d8876915cfefd158fb1712b8fe

Bug:18654243

Change-Id: Ied2fbc87c7effc23fecb68e9863153d63c0cfba4

Bug:18589301

Change-Id: Ifa2ae05620207798d24e5e196ff522a71fc0fd48

An exception is thrown when group creation is deemed failed. It is
thrown because an empty peer address is encountered. It is not clear
when the address goes empty (there are no logs); but this change
would prevent resstarting of the framework.

Bug: 18667239

Change-Id: I523646eaa1ff6c8dab9ee99b893ebc4291eee2da

* changes:
  rework scan logic so as to make use of delayed messages instead of scan alarm
  reenable disabled config after a few minutes

Merge "- keep track of ephemeral configurations that are deleted by user -  make sure we cleaned up prior ephemeral WiFiconfiguration from wpa_supplicant.conf Bug:18525241" into lmp-mr1-dev

Bug:18594119
Change-Id: I0d49fa2908d824de6adb125cf862de47f8ba5e91

This change also loose stale user selection which prevents device to re-join potentially
reenabled configs

Bug:18571727
Change-Id: I0acacd3fb1fbb64a48d0407d7b9e4e5403a93726

Allow callers that hold INTERACT_ACROSS_USERS_FULL access to scan
results even if they aren't on the current user.

Bug: 16559573
Change-Id: I27fae71b3cdc1c084777242f21fe4bb692ab7135

-  make sure we cleaned up prior ephemeral WiFiconfiguration from wpa_supplicant.conf
Bug:18525241

Change-Id: I773cb9b28fe139d1cd5df622619b4a9cf866d6ce

This change uses list_network last_id=x form of list_networks to
retrieve all networks saved in the system.

Bug: 18566264
Change-Id: Ie439acd98d39ca32417418944035dcce3068d44b

...(512KB RAM, 10K objects)

Pull this back to 300 entries on Svelte devices...  we also need to reduce
this on non-Svelte devices, but at least right now we desperately need it
fixed on Svelte.

Change-Id: I301bf8a4637c066166a5a69c178d581c072b8dc5

Bug: 18245283
Change-Id: Ie844353bffcf40baa4db8cad2c18dcc5ffaf5a82

Bug:18512598

Change-Id: I79aa972f686f2c4090012a36dcad13a9e53d5566

Change-Id: I387816c8682e9f595229ecbb20c35711ea1f069b

- use scorer only for untrusted networks
Bug:18490330
Bug:18368125

Change-Id: I13f21a2247d071d2e8edc48546c14e0a9e2bc5d6

Bug:18451553

Change-Id: I729ae360209e852e4e64bed0c584ed076b1281b4