GitLab

Add a couple of unit tests to cover the periodic scan exponential
backoff feature.

Extended MockAlarmManager class such that users can query a
pending alarm's trigger time.

Bug: 28750989
Change-Id: I9520477180786fce2937e5fa87f790f60f12a3da

When the phone screen is on, the periodic scan interval is setup
in an exponential backoff fashion. Also, if the traffic is higher
than certain threshold, perform scan on certain channels only
instead of full band.

Bug: 28627603
Change-Id: I95b686d7835265d843edac7c005f661393ae5383

Bug: 28437662
Change-Id: I9d478d644cc5b52a031a3ee3e157d40f952dff50

* changes:
  WifiController: set to proper state after SoftAP
  WifiControllerTest: cleanup style issues
  WifiSettingsStore: add methods for WifiSavedState

Now that writeApConfiguration has no return type, so we
should also ignore the value in the tests.

BUG=28692504
TEST=compile
TEST=runtest frameworks-wifi

Change-Id: Ia4a562335de2c1dcadb5f41dcb3dc9f96a926680

After receiving a CMD_AP_STOPPED message, WifiController should return
to the DeviceActive state or the appropriate Idle state.  This CL sets
the correct pending state and also adds a check for the idle state.
A test is also added to confirm the DeviceActive state is entered after
the SoftAp state is completed.

Note: An additional test for the DeviceIdle path will be added at a
later point after some code refactoring (bug 28669096)

BUG: 28434530
Change-Id: Ie19e66b9c84ff545a622119890bc7705ebd74c46

Clean up some style issues for WifiControllerTest.

This is in preparation for additional tests being added for the bug fix.

BUG: 28434530
Change-Id: Idfcc51e2d30753051b9d8e2ec066035f771f0339

Add methods to get and set WifiSavedState in WifiSettingsStore.  This
change allows us to better test state transitions in WifiController
since we can now mock out the calls easily.

BUG: 28434530
Change-Id: Ie2b6f0311462da0179ecd28665f78f4bf14a02f9

Quite some logs should be debug message instead of error
message.

Bug: 28619076
Change-Id: Iee06f57bab58aeca881068f0b4f36a0d5bbb3230
Test: Wifi Unit Tests

This CL uses value comparision instead of reference comparision
for strings.
This also removes returning value in finally block, otherwise
exception may be suppressed.

BUG=28605846
TEST=compile
TEST=runtest frameworks-wifi

Change-Id: I6ace4d233d2b0af3627f75dfdb7dcec6a46b0092

Truncate the hidden network id list if it goes beyond wpa_supplicant's
max value. wpa_supplicant has a hard coded value of 16 for the max
number of networks that can be specified for each scan.

There is currently no way to query this value from wpa_supplicant, so
hardcoding this value in SupplicantScanner.

BUG: 28632556
Change-Id: I31a338b91c221c1686437b738894e13abb897474
TEST: Compiles & unit-test passes

Always return when the current preferred BSSID is the same as
the target one. This was done previously only if the DBG flag
is set.

While there, fixed the log message wording a bit.

Bug: 28619076
Tests: Wifi unit tests, manual connection & roaming tests
Change-Id: I109b57d54b1bcaccb00a148b488244b7d9358907

Clear the config BSSID after roaming completed and before entering
ConnectedState. Wifi chipset may roam from this point on and
having the BSSID specified by QNS would cause the roam to fail
and the device to disconnect.

We used to rely on the fact that entering ObtainingIpState
clears the config BSSID. But this assumption was broken by
commit bcbc449d, which changed from transition
to ObtainingIpState to ConnectedState.

Bug: 28520770
Test: Wifi unit tests, manual tests
Change-Id: I09a2d5d1132ff597c63a324a24d13719be384603

* changes:
  WifiConnectivityManager: Unit tests for metrics
  WifiConnectivityManager: Increment metrics

Add couple of unit-tests for metrics. Had to migrate the unit-tests to use
mock alarm manager.

BUG: 27479439
BUG: 27704599
BUG: 28480516
Change-Id: I1424053c35799905612b37edeb679e7556568ca5
TEST: Compiles & unit-test passes

Make changes to increment the watchdog related metrics in
WifiConnectivityManager.

PS: Will need to add mock alarm manager to add unit-tests here. This is
done in the next CL.

BUG: 27479439
BUG: 27704599
Change-Id: I96e35e06d222056ec29488666619486a65746b38

If the vendor's Wifi HAL does not provide packet fate
functions, then WifiServiceImpl (and hence, system server)
will crash when WifiLogger calls packet fate functions.

Fix this, by providing stub implementations. These will
be automatically overriden by vendor-provided implementations.

BUG=28565646
TEST=manual

Manual test:
- repeat for angler and bullhead:
  - try to connect to WPA-2 network with wrong password
  $ adb shell dumpsys > /tmp/dumpsys
  - verify that dumpsys contains "Last failed connection fates"
  - verify that dumpsys shows Authentication messages
- on bullhead
  - hack up HAL, so that packet fate functions are not registered
  $ adb logcat -d | grep 'Failed to start packet fate'
    -> should see matching lines
  (with the hacked up HAL, and without this patch, the call to
  startPktFateMonitoring() causes a SIGSEGV, instead of just a
  clean failure message)

Change-Id: I86ce34784dea396f9e8741353395cab1ec6e0913

* changes:
  WifiStateMachine: dynamically configure WifiHAL log level
  wifi service: abstract away access to SystemProperties

Fixes: 28563549
Change-Id: I445054af4b176c69a26af6fe340a6eb88cf06452

By default, VERBOSE level logging is disabled for native code.
However, when debugging Wifi issues, we'll sometimes want to
include VERBOSE level log messages from the HAL implementation.

Update WifiStateMachine's verbose-debugging logic, to support
this case.

Note that VERBOSE level messages will not be compiled in
on user builds. Nor will system server be permitted to change
the logging level on user builds. For these reasons, the
log level is only modified on non-user builds.

BUG=27857554
TEST=unit tests, manual

Manual test (bullhead):
- On userdebug build with 'Enable Wi-Fi Verbose Logging' set:
  $ adb reboot && adb wait-for-device && adb logcat -d | grep 'V WifiHAL'
  -> matching lines seen
  $ adb shell getprop | grep WifiHAL
  [log.tag.WifiHAL]: [V]
- On userdebug build with 'Enable Wi-Fi Verbose Logging' unset:
  $ adb reboot && adb wait-for-device && adb logcat -d | grep 'V WifiHAL'
  -> NO matching lines
  $ adb shell getprop | grep WifiHAL
  [log.tag.WifiHAL]: [D]
- On user build with 'Enable Wi-Fi Verbose Logging' set:
  $ adb logcat -d | grep 'V WifiHAL'
  -> NO matching lines
  $ adb shell getprop | grep WifiHAL
  -> NO matching lines

Change-Id: Icaa91d9d1261a6cf5851d5ad9b0a6a25fd329344

We want the ability to modify the value of a system property,
so that we can dynamically change the logging level for WifiHAL.

This ability depends on permissions that are not available to
the test runner. For example, the process that is running the
wifi service code needs the ability to connect to the
|property_service| socket.

To resolve the problem, we do the following:
- add a PropertyService interface, which abstracts away access
  to SystemProperties
- add PropertyService to the dependencies managed by WifiInjector
- add SystemPropertyService, which routes property requests
  to android.os.SystemProperties
- update WifiStateMachine, to access properties via PropertyService
- update WifiStateMachineTest, to use a mock implementation of
  PropertyService

BUG=27857554
TEST=unit tests

Change-Id: Ic930337a6a8f6a600ae7b4da2ca2eaf5c9e6c2cb

Fixes: 28452172
Change-Id: I99a1c11f15adf615b13496aec63642bfc2e552de

This CL fixes a bug where scan results were being paired with null
configs instead of their associated WifiConfiguration, and passed to
WifiLastResortWatchdog. This lead to the watchdog trigger potentially
not activating.

BUG=28476482

Change-Id: I0a10fc2309cf2199001dc440ed93ceaa3c891dba

mNetworkFactory and mUntrustedNetworkFactory are being dumped twice. The
second time, potentially causing null exceptions.
Removed the second calls (were left over from bad rebase).

BUG=28530520

Change-Id: I3312ac83a7ea2d4027036ea85702caa74985753d

We sometimes fetch the channel list often (every 20 seconds),
so logging the message on every attempt to fetch the list is
spammy.

Demote the message to verbose level, to reduce spam.

BUG=28425940
TEST=manual

Manual test:
- install new code
- reboot device
- after reboot, sleep 60
$ adb logcat -d \
  | egrep 'getting valid|ScannerImpl: Starting wifi scan for freqs'
  -> match for "ScannerImpl...", but not "getting valid"

Change-Id: I56a8f941ced0f291f0c37e9279e5dda635351cb2

Added an exponential back off retry mechanism for networks
found by PNO scan but rejected by QNS due to their low RSSI
values.

Bug: 28402107
Change-Id: I8a69afb3d22fbd2f479073e6087893c24e5a5d39

When new scan results are processed, networks already stored as the
available networks may have updated configs passed in, but they may also
have null configs.  The null configs should not be used to update the
stored config.  Added a check to determine if the passed in config is
not null before the update.

In addition, debugging output also reported the value of
HasEverConnected as false for networks with a null config.  This was
updated to report null_config instead.

Added tests covering config updates.
Added tests for debugging output.

BUG: 28451079
Change-Id: Iff9888ab87c61619b2f865516eca22d87eb4f4b8