GitLab

This CL uses value comparision instead of reference comparision
for strings.
This also removes returning value in finally block, otherwise
exception may be suppressed.

BUG=28605846
TEST=compile
TEST=runtest frameworks-wifi

Change-Id: I6ace4d233d2b0af3627f75dfdb7dcec6a46b0092

If the vendor's Wifi HAL does not provide packet fate
functions, then WifiServiceImpl (and hence, system server)
will crash when WifiLogger calls packet fate functions.

Fix this, by providing stub implementations. These will
be automatically overriden by vendor-provided implementations.

BUG=28565646
TEST=manual

Manual test:
- repeat for angler and bullhead:
  - try to connect to WPA-2 network with wrong password
  $ adb shell dumpsys > /tmp/dumpsys
  - verify that dumpsys contains "Last failed connection fates"
  - verify that dumpsys shows Authentication messages
- on bullhead
  - hack up HAL, so that packet fate functions are not registered
  $ adb logcat -d | grep 'Failed to start packet fate'
    -> should see matching lines
  (with the hacked up HAL, and without this patch, the call to
  startPktFateMonitoring() causes a SIGSEGV, instead of just a
  clean failure message)

Change-Id: I86ce34784dea396f9e8741353395cab1ec6e0913

* changes:
  WifiStateMachine: dynamically configure WifiHAL log level
  wifi service: abstract away access to SystemProperties

Fixes: 28563549
Change-Id: I445054af4b176c69a26af6fe340a6eb88cf06452

By default, VERBOSE level logging is disabled for native code.
However, when debugging Wifi issues, we'll sometimes want to
include VERBOSE level log messages from the HAL implementation.

Update WifiStateMachine's verbose-debugging logic, to support
this case.

Note that VERBOSE level messages will not be compiled in
on user builds. Nor will system server be permitted to change
the logging level on user builds. For these reasons, the
log level is only modified on non-user builds.

BUG=27857554
TEST=unit tests, manual

Manual test (bullhead):
- On userdebug build with 'Enable Wi-Fi Verbose Logging' set:
  $ adb reboot && adb wait-for-device && adb logcat -d | grep 'V WifiHAL'
  -> matching lines seen
  $ adb shell getprop | grep WifiHAL
  [log.tag.WifiHAL]: [V]
- On userdebug build with 'Enable Wi-Fi Verbose Logging' unset:
  $ adb reboot && adb wait-for-device && adb logcat -d | grep 'V WifiHAL'
  -> NO matching lines
  $ adb shell getprop | grep WifiHAL
  [log.tag.WifiHAL]: [D]
- On user build with 'Enable Wi-Fi Verbose Logging' set:
  $ adb logcat -d | grep 'V WifiHAL'
  -> NO matching lines
  $ adb shell getprop | grep WifiHAL
  -> NO matching lines

Change-Id: Icaa91d9d1261a6cf5851d5ad9b0a6a25fd329344

We want the ability to modify the value of a system property,
so that we can dynamically change the logging level for WifiHAL.

This ability depends on permissions that are not available to
the test runner. For example, the process that is running the
wifi service code needs the ability to connect to the
|property_service| socket.

To resolve the problem, we do the following:
- add a PropertyService interface, which abstracts away access
  to SystemProperties
- add PropertyService to the dependencies managed by WifiInjector
- add SystemPropertyService, which routes property requests
  to android.os.SystemProperties
- update WifiStateMachine, to access properties via PropertyService
- update WifiStateMachineTest, to use a mock implementation of
  PropertyService

BUG=27857554
TEST=unit tests

Change-Id: Ic930337a6a8f6a600ae7b4da2ca2eaf5c9e6c2cb

Fixes: 28452172
Change-Id: I99a1c11f15adf615b13496aec63642bfc2e552de

This CL fixes a bug where scan results were being paired with null
configs instead of their associated WifiConfiguration, and passed to
WifiLastResortWatchdog. This lead to the watchdog trigger potentially
not activating.

BUG=28476482

Change-Id: I0a10fc2309cf2199001dc440ed93ceaa3c891dba

mNetworkFactory and mUntrustedNetworkFactory are being dumped twice. The
second time, potentially causing null exceptions.
Removed the second calls (were left over from bad rebase).

BUG=28530520

Change-Id: I3312ac83a7ea2d4027036ea85702caa74985753d

We sometimes fetch the channel list often (every 20 seconds),
so logging the message on every attempt to fetch the list is
spammy.

Demote the message to verbose level, to reduce spam.

BUG=28425940
TEST=manual

Manual test:
- install new code
- reboot device
- after reboot, sleep 60
$ adb logcat -d \
  | egrep 'getting valid|ScannerImpl: Starting wifi scan for freqs'
  -> match for "ScannerImpl...", but not "getting valid"

Change-Id: I56a8f941ced0f291f0c37e9279e5dda635351cb2

Added an exponential back off retry mechanism for networks
found by PNO scan but rejected by QNS due to their low RSSI
values.

Bug: 28402107
Change-Id: I8a69afb3d22fbd2f479073e6087893c24e5a5d39

When new scan results are processed, networks already stored as the
available networks may have updated configs passed in, but they may also
have null configs.  The null configs should not be used to update the
stored config.  Added a check to determine if the passed in config is
not null before the update.

In addition, debugging output also reported the value of
HasEverConnected as false for networks with a null config.  This was
updated to report null_config instead.

Added tests covering config updates.
Added tests for debugging output.

BUG: 28451079
Change-Id: Iff9888ab87c61619b2f865516eca22d87eb4f4b8

Keep track of the network BSSID of the last connection attempt.
This BSSID is checked in case the phone is still in the process of
connecting to that network. mWifiInfo is checked for the currently
connected network. This is for the case that firmware performed
roaming automatically.

While there, addressed a checkstyle issue.

Bug: 28462151
Change-Id: Ia9316048e0549036de1c20bf1f3099cfcda9a75e
Test: WiFi unit tests

* changes:
  WifiLastResortWatchdog trigger logic
  WifiLastResortWatchdog failure counting

Added logging of various metrics to the WifiLastResortWatchdog. These
metrics count the number of times the Watchdog triggers, and stats
counting the number of networks present at failure time for different
failure types.

BUG=27856474

Change-Id: If43836b1c33791fefb8000196b231c312161feef

Implemented trigger condition logic that is checked after a failure is
counted. The condition takes into account: failure counts, wifi
connected state, past connections to saved networks and whether the
watchdog has fired since the wifi environment changed.

Please note: This change only implements the logic for deciding when to
trigger, not the trigger itself.

BUG=27856709

Change-Id: I91ad6127a72ca24c72a5520348c4fff83f16b559

Move the execution of this method to the thread of
WifiStateMachine to address a potential WifiConnectivityManager
concurrent access issue.

While there, remove a dead method.

Bug: 28369823
Change-Id: I49f424637ee6897495daedbf4b1cc06477e78798

With WifiScanner also running on the WifiStateMachine thread,
WifiConnectivityManager is now exectued on a single thread context.

While there, fixed a few checkstyle issues.

Bug: 28369823
Change-Id: Ibf2b65be42d243deb61a68380a9011f4acc663b4

Implemented watchdog methods and calls to them from WifiStateMachine to
count association rejection, authentication failure & dhcp failures.

This will allow the watchdog to determine when all available networks
are failing, and Wifi Framework has no other options, however this Cl
does not implement that logic.

BUG=27855690
BUG=27856523

Change-Id: I416bfd0e0340823de5ca04f2d040bff7a751b677

This reverts commit ced2db17.

Reverting due to test failure.
BUG=28385150

Change-Id: I86ffd7f017727ee94508102cd7a2962dcf803ffc

BUG: 28242396
Change-Id: I53c0e91d2b9ee2731c0f74ef6376f4fb4e67f2e9

Sending ANQP request when wifi is connecting or connected
may fail the connection.
This CL fixes it by adding a parameter to WifiConfigManager
::updateSavedNetworkWithNewScanDetail(). This boolean value
can indicate that we are connecting or connected.
Link debouncing is also considered as connecting in this case.

BUG=26494190
TEST=runtest frameworks-wifi
Change-Id: Ic4dfd0c0ba0392da68b6705d18fb82d92f44e508

Also make logging in WifiScanningService not static and add some tests
to verify some logging behavior.

Fixes: 28274869
Change-Id: I879200778dcadb4e67d5a85d42442baf3ceef6c9