1. 29 May, 2016 1 commit
  2. 27 May, 2016 1 commit
  3. 26 May, 2016 3 commits
  4. 25 May, 2016 5 commits
  5. 24 May, 2016 3 commits
    • Randy Pan's avatar
      Wifi: local log size reduction · 15941215
      Randy Pan authored
      Cut down the max number of lines allowed in Wifi LocalLogs.
      Currently LocalLog checks the number of lines in its buffer
      instead of total size in number of bytes. The buffer being
      used can grow really big if some lines are lengthy.
      
      Bug: 28865103
      Change-Id: I7f77de1048bb465b79265b3ecb3a925e3a2659d9
      Test: Wifi Framework Unit Tests
      15941215
    • Randy Pan's avatar
      WifiConnectivityManager: enforce minimum single scan interval · c2963eb0
      Randy Pan authored
      Instead of always starting a single scan when the device enters
      screen on state, we now keep track of how long it has been since
      last periodic single scan and defer the new scan request.
      
      Bug: 28887789
      Tests: Wifi Unit Tests, manual tests
      Change-Id: Iba5b5b7db897d3227d87f8d989246a1942525b9c
      c2963eb0
    • The Android Automerger's avatar
  6. 23 May, 2016 2 commits
  7. 22 May, 2016 1 commit
  8. 21 May, 2016 1 commit
  9. 20 May, 2016 6 commits
  10. 19 May, 2016 4 commits
    • Roshan Pius's avatar
      Change clock for time interval/elapsed measurments · ee0ab818
      Roshan Pius authored
      1. Use the clock retrieved from WifiInjector in more modules: QNS,
      Scanner, WifiConfigManager.
      2. Use |elapsedRealtime| for time interval/elapsed measurments. Things
      like scan results, config elements still continue to use
      |currentTimeMillis|
      
      Also,
      1. Had to make |tryEnableQualifiedNetwork| public to prevent mockito from
      calling the real method in WifiConfigManager.
      2. Move keystore also into WifiInjector.
      
      BUG: 28299258
      BUG: 28824635
      Change-Id: I91272aa5665abb741da7530d8920d09c8c5ea41f
      TEST: Compiles & unit-test passes
      ee0ab818
    • The Android Automerger's avatar
    • mukesh agrawal's avatar
      WifiLogger: fetch packet fate on dump() · 1bf15571
      mukesh agrawal authored
      We've observed that it's tricky to detect when a connection
      fails. Consequently, even if the user is careful to generate
      a bugreport while the device is in the failed state, the
      bugreport will not include packet fate data for the most
      recent connection.
      
      Improve the utility of packet fate, by fetching the most
      recent fate on the call to dump(). With this change in place,
      we'll get packet fates for the most recent connection
      attempt (even if it's still in progress).
      
      BUG=28849396
      TEST=unit tests, manual
      
      Manual test
      - configure bullhead for open network
      - configure bullhead for wpa-2 network, wrong password
      - let bullhead fail connecting to wpa-2 network
      - let bullhead succeed connecting to open network
      $ adb dumpsys > /tmp/dumpsys
      $ grep 'fates ---' /tmp/dumpsys
      --------------------- Last failed connection fates ----------------------
      --------------------- Latest fates ----------------------
      
      Change-Id: Iaeb2584020f70ac5d2f3139bac72ea07a7ddce81
      1bf15571
    • Mukesh Agrawal's avatar
  11. 18 May, 2016 11 commits
    • Randy Pan's avatar
      WifiConnectivityManager: partial scan only when connected · f5c525eb
      Randy Pan authored
      Starts partial scan only when Wifi is connected and traffic
      is heavy. This is to work around an issue that WifiInfo
      tx/rx rate is not updated to reflect the Wifi state. Ideally
      the tx/rx rate should have been reset to 0 when Wifi is
      disconnected.
      
      Bug: 28831562
      Change-Id: Ifa415b14e2b216654ddd8a2a0c885754da489bef
      Test: Wifi Framework Unit Tests, manual tests
      f5c525eb
    • Mitchell Wills's avatar
      Fix crash when scanner gets results that don't match the request · ea0d993f
      Mitchell Wills authored
      Before this, when WifiScanningService processed single scan results from
      supplicant that only contained results that did not match a request the
      filter code would return null indicating that the results should not be
      delivered, causing a NPE later. This change updates the meaning of the
      bucket index that the single scan code provides to the filtering code to
      instead force it to always include scan results.
      
      Change-Id: I65cd57b14abacec3f407991188c570601d05ac77
      Fixes: 28794598
      ea0d993f
    • mukesh agrawal's avatar
      WifiNative: add wallclock timestamps for packet fate · eaf6303a
      mukesh agrawal authored
      Packet fate reports are timestampped in a different format than
      logcat messages. This makes it hard to correlate packet fate
      summaries with other system activity.
      
      Resolve this, by adding wall-clock timestamps to packet fate
      summaries.
      
      BUG=28701632
      TEST=manual test
      
      Manual test:
      - set bullhead to non-GMT timezone
      - install build on bullhead
      - trigger connection failure
      - verify that walltime column is in the right ballpark,
        relative to logcat messages
      
      Change-Id: I3aed8d9acca42f0ef0cc4f2f2fbdabdde33ce4c8
      eaf6303a
    • Mitchell Wills's avatar
    • TreeHugger Robot's avatar
    • Randy Pan's avatar
      WifiConnectivityManager: partial scan only when connected · ee9329dc
      Randy Pan authored
      Starts partial scan only when Wifi is connected and traffic
      is heavy. This is to work around an issue that WifiInfo
      tx/rx rate is not updated to reflect the Wifi state. Ideally
      the tx/rx rate should have been reset to 0 when Wifi is
      disconnected.
      
      Bug: 28831562
      Change-Id: Ifa415b14e2b216654ddd8a2a0c885754da489bef
      Test: Wifi Framework Unit Tests, manual tests
      ee9329dc
    • Mukesh Agrawal's avatar
      Merge changes I5884dee0,I6f4cb00c into nyc-dev · 43d1480f
      Mukesh Agrawal authored
      * changes:
        WifiLogger: use large ringbuffers on eng/userdebug
        WifiService: add build properties abstraction
      43d1480f
    • The Android Automerger's avatar
    • Mitchell Wills's avatar
      Add tests to verify single scan blame behavior · 1345d63e
      Mitchell Wills authored
      Bug: 28320003
      Change-Id: I4cfdedb1d5c3c29608208bb1c3bda42f4759fb7f
      1345d63e
    • mukesh agrawal's avatar
      WifiLogger: use large ringbuffers on eng/userdebug · 8df302f5
      mukesh agrawal authored
      We're having trouble resolving some field reports, due
      to insufficient time coverage in the HAL ring buffers.
      
      Increase the ringbuffer size of eng/userdebug builds,
      to make it easier to debug issues reported by
      dogfooders.
      
      This change will be reverted closer to launch.
      (b/28822174 has been filed for the reversion.)
      
      BUG=28729317
      TEST=unit tests
      
      Change-Id: I5884dee05db79245d211a457ff44b5e7b96ddbcb
      8df302f5
    • mukesh agrawal's avatar
      WifiService: add build properties abstraction · b6d6e31d
      mukesh agrawal authored
      As it turns out, WifiStateMachine isn't the only thing that
      wants to change its logging behavior depending on
      Build.TYPE.
      
      1) Add an abstraction of Build.TYPE, so that we can
         a) check build type in a common way, and
         b) test the logging behavior across build types
      2) Migrate WifiStateMachine to use this new abstraction.
      
      BUG=28822027
      TEST=unit tests
      
      Change-Id: I6f4cb00ccb5f3a4b9a5b67e69f8365aab7fd429c
      b6d6e31d
  12. 17 May, 2016 2 commits
    • Randy Pan's avatar
      Merge changes from topic 'exponential backoff periodic scan' into nyc-dev · ac90f832
      Randy Pan authored
      * changes:
        WifiConfigManager: clean up makeChannelList()
        WifiStateMachine: clean up dead code
        WifiConnectivityManagerTest: exponential backoff periodic scan
        Restrict connectivty periodic scan
      ac90f832
    • Mitchell Wills's avatar
      Fix crash when scanner gets results that don't match the request · f5cdd8e7
      Mitchell Wills authored
      Before this, when WifiScanningService processed single scan results from
      supplicant that only contained results that did not match a request the
      filter code would return null indicating that the results should not be
      delivered, causing a NPE later. This change updates the meaning of the
      bucket index that the single scan code provides to the filtering code to
      instead force it to always include scan results.
      
      Change-Id: I65cd57b14abacec3f407991188c570601d05ac77
      Fixes: 28794598
      f5cdd8e7