Skip to content

GitLab

Switch branch/tag
  1. 25 Apr, 2016 1 commit
  3. 22 Apr, 2016 3 commits
  5. 21 Apr, 2016 7 commits
  7. 20 Apr, 2016 4 commits
    • mukesh agrawal's avatar
      WifiLogger: fix bug in HAL callback registration · 956fd40b
      mukesh agrawal authored 
      When we call WifiLogger.startLogging(), WifiLogger
may or may not register callbacks for ring-buffer
data delivery, and WiFi alerts.

Whether or not WifiLogger registers the callbacks
depends on whether or not the callbacks have already
been reigstered. If WifiLogger has already registered
callbacks, then a new call to startLogging() will
skip callback registration.

Now, it's not entirely clear if this already-registered
check is necessary. It is certainly conceivable that the
HAL implementations allow us to replace existing callbacks,
without explicitly removing the existing callbacks first.

But, the necessity of the check aside, the immediate
problem is that the already-registered check fails to
handle the case where an early registration failed.

This CL revises the code, to handle this case.

While there:
- Fix some whitespace issues.
- Remove unnecessary comment about the effects of
  resetLogHandler(). (Even if the comment _were_ necessary,
  it should be part of the Javadoc for resetLogHandler().)

BUG=28274991
TEST=(new) unit tests, manual

Manual test:
- boot device
$ adb shell dumpsys | grep -A1 'ring-buffer = driver_prints_rb'
ring-buffer = driver_prints_rb
<base64 encoded data...>

Change-Id: I04e9bc1863aaf5bda00ca9cf8dc35696ae1e5f24
      956fd40b
    • Jeremy Joslin's avatar
      Merge "Use external scores on saved networks if requested." into nyc-dev · de68b305
      Jeremy Joslin authored
      de68b305
    • Samuel Tan's avatar
      Merge changes Id4cc9c3c,Ice7dad5a into nyc-dev · af8c59a9
      Samuel Tan authored 
      * changes:
  Log summarized packet fate reports
  Add FrameParser
      af8c59a9
    • Jeremy Joslin's avatar
      Use external scores on saved networks if requested. · ea204873
      Jeremy Joslin authored 
      When a saved network has the useExternalScores boolean set to true then
lump it in with the ephemeral networks when considering it as a
candidate.

Externally scored saved networks are only considered if a saved network
candidate cannot be found.

BUG: 25562019
Change-Id: Icdb7318103e14e518536c3179cd30c87cc2c3035
      ea204873
  9. 19 Apr, 2016 2 commits
  11. 18 Apr, 2016 9 commits
  13. 16 Apr, 2016 1 commit
    • Samuel Tan's avatar
      Add FrameParser · 70b4f7f1
      Samuel Tan authored 
      Add FrameParser, a utility class that parses the contents
of a network frame, and stores it in its public member fields.
This utility will be used to print out summarized versions of
the contents of packet fate report frames.

In this initial implementation of FrameParser, we only parse out
the information we are interested in printing (i.e. the most specific
networking protocol, and the type of packet within this protocol).

BUG: 28150622
Change-Id: Ice7dad5a7800736605043688955027893fadffc7
TEST: 'runtest frameworks-wifi -c \
       com.android.server.wifi.util.FrameParserTest' passes.
      70b4f7f1
  15. 15 Apr, 2016 5 commits
  17. 14 Apr, 2016 8 commits