GitLab

Cut down the max number of lines allowed in Wifi LocalLogs.
Currently LocalLog checks the number of lines in its buffer
instead of total size in number of bytes. The buffer being
used can grow really big if some lines are lengthy.

Bug: 28865103
Change-Id: I7f77de1048bb465b79265b3ecb3a925e3a2659d9
Test: Wifi Framework Unit Tests

* changes:
  WifiNetworHistory: Don't persist QNS blacklist
  Change clock for time interval/elapsed measurments

Tell WifiConnectivityManager the screen state in case
WifiConnectivityManager missed the screen update event because
it was not started yet.

Bug: 28824622
Tests: Wifi Framework Unit Tests; reproduced the symptom and
       verified it went away after this change.

Change-Id: I33cce9276982f6e77cf89a42ddd14ad00f2e4f46

Bug: 28682351
Change-Id: If9296d862adbd479e8600699f06f4684d377ae6a

QNS blacklists network temporarily by setting the network status. Reset
this value when we bootup so that this not persisted. This is especially
needed as we move away from using wall clock for blacklist time.

Also,
Remove the unused blacklist timestamp key from network history parsing.

BUG: 28824635
Change-Id: Ie64c11f358b2e3389ec419cfcfdde8bb04298dd4
TEST: Compliles & unit-test passes

Fall back to full band scan when the currently connected network is not
present in scan result cache. This could be a transient problem, but we
don't want to cause an error by sending an invalid scan request.

Changes needed for unit-testing this change:
1. Make WifiInfo a real instance so that we can set the values for the
public members directly accessed like tx/rx success rate.
2. Make |getCurrentWifiConfiguration| public so that it can be stubbed
out.

BUG: 28845855
TEST: Compiles & unit-test passes
Change-Id: I6cb2b7ad762b3f8f2ab36d66c4b1fcc39fafffed

1. Use the clock retrieved from WifiInjector in more modules: QNS,
Scanner, WifiConfigManager.
2. Use |elapsedRealtime| for time interval/elapsed measurments. Things
like scan results, config elements still continue to use
|currentTimeMillis|

Also,
1. Had to make |tryEnableQualifiedNetwork| public to prevent mockito from
calling the real method in WifiConfigManager.
2. Move keystore also into WifiInjector.

BUG: 28299258
BUG: 28824635
Change-Id: I91272aa5665abb741da7530d8920d09c8c5ea41f
TEST: Compiles & unit-test passes

We've observed that it's tricky to detect when a connection
fails. Consequently, even if the user is careful to generate
a bugreport while the device is in the failed state, the
bugreport will not include packet fate data for the most
recent connection.

Improve the utility of packet fate, by fetching the most
recent fate on the call to dump(). With this change in place,
we'll get packet fates for the most recent connection
attempt (even if it's still in progress).

BUG=28849396
TEST=unit tests, manual

Manual test
- configure bullhead for open network
- configure bullhead for wpa-2 network, wrong password
- let bullhead fail connecting to wpa-2 network
- let bullhead succeed connecting to open network
$ adb dumpsys > /tmp/dumpsys
$ grep 'fates ---' /tmp/dumpsys
--------------------- Last failed connection fates ----------------------
--------------------- Latest fates ----------------------

Change-Id: Iaeb2584020f70ac5d2f3139bac72ea07a7ddce81

Packet fate reports are timestampped in a different format than
logcat messages. This makes it hard to correlate packet fate
summaries with other system activity.

Resolve this, by adding wall-clock timestamps to packet fate
summaries.

BUG=28701632
TEST=manual test

Manual test:
- set bullhead to non-GMT timezone
- install build on bullhead
- trigger connection failure
- verify that walltime column is in the right ballpark,
  relative to logcat messages

Change-Id: I3aed8d9acca42f0ef0cc4f2f2fbdabdde33ce4c8

Starts partial scan only when Wifi is connected and traffic
is heavy. This is to work around an issue that WifiInfo
tx/rx rate is not updated to reflect the Wifi state. Ideally
the tx/rx rate should have been reset to 0 when Wifi is
disconnected.

Bug: 28831562
Change-Id: Ifa415b14e2b216654ddd8a2a0c885754da489bef
Test: Wifi Framework Unit Tests, manual tests

* changes:
  WifiLogger: use large ringbuffers on eng/userdebug
  WifiService: add build properties abstraction

Bug: 28320003
Change-Id: I4cfdedb1d5c3c29608208bb1c3bda42f4759fb7f

We're having trouble resolving some field reports, due
to insufficient time coverage in the HAL ring buffers.

Increase the ringbuffer size of eng/userdebug builds,
to make it easier to debug issues reported by
dogfooders.

This change will be reverted closer to launch.
(b/28822174 has been filed for the reversion.)

BUG=28729317
TEST=unit tests

Change-Id: I5884dee05db79245d211a457ff44b5e7b96ddbcb

As it turns out, WifiStateMachine isn't the only thing that
wants to change its logging behavior depending on
Build.TYPE.

1) Add an abstraction of Build.TYPE, so that we can
   a) check build type in a common way, and
   b) test the logging behavior across build types
2) Migrate WifiStateMachine to use this new abstraction.

BUG=28822027
TEST=unit tests

Change-Id: I6f4cb00ccb5f3a4b9a5b67e69f8365aab7fd429c

* changes:
  WifiConfigManager: clean up makeChannelList()
  WifiStateMachine: clean up dead code
  WifiConnectivityManagerTest: exponential backoff periodic scan
  Restrict connectivty periodic scan

Before this, when WifiScanningService processed single scan results from
supplicant that only contained results that did not match a request the
filter code would return null indicating that the results should not be
delivered, causing a NPE later. This change updates the meaning of the
bucket index that the single scan code provides to the filtering code to
instead force it to always include scan results.

Change-Id: I65cd57b14abacec3f407991188c570601d05ac77
Fixes: 28794598

Removed the unused input paramater 'restrict'. Updated its
callers.

Bug: 28786277
Change-Id: I44dc870ce3f353698187f76e8996cc77395b17d3
Tests: Wifi Framework Unit Tests, manual tests

Cleaned up the dead code from the original exponential back off
scan implementation.

Bug: 28750989
Bug: 28070598

Change-Id: I8abf82cdaa3530fb514794b4004c5d3f15950672
Tests: Wifi Unit Tests, manual test

Add a couple of unit tests to cover the periodic scan exponential
backoff feature.

Extended MockAlarmManager class such that users can query a
pending alarm's trigger time.

Bug: 28750989
Change-Id: I9520477180786fce2937e5fa87f790f60f12a3da

When the phone screen is on, the periodic scan interval is setup
in an exponential backoff fashion. Also, if the traffic is higher
than certain threshold, perform scan on certain channels only
instead of full band.

Bug: 28627603
Change-Id: I95b686d7835265d843edac7c005f661393ae5383

Since PNO scans are started by the PNO debouncer (which debounces PNO state
change for 5 seconds), the log message stating that we have started PNO
scan should be moved to the location where the scan is actually started.

This removes the confusion from the logs in the below case:
05-16 16:51:40.135 D/SupplicantWifiScannerImpl(  876): Change PNO state
from false to true
05-16 16:51:42.356 D/SupplicantWifiScannerImpl(  876): Change PNO state
from true to false
05-16 16:51:45.109 D/SupplicantWifiScannerImpl(  876): Start PNO timer
with delay 2247
05-16 16:51:45.116 D/SupplicantWifiScannerImpl(  876): Starting wifi PNO
scan
05-16 16:51:50.111 D/SupplicantWifiScannerImpl(  876): Change PNO state
from false to true
05-16 16:51:52.368 D/SupplicantWifiScannerImpl(  876): Change PNO state
from true to false
05-16 16:51:55.143 D/SupplicantWifiScannerImpl(  876): Start PNO timer
with delay 2225
05-16 16:51:55.148 D/SupplicantWifiScannerImpl(  876): Starting wifi PNO
scan

BUG: 28800979
Change-Id: Ib4cc7c59fde83a02a2b938fb334a85f0c046cd87

This also fixes the potential crash when handling intent
with null action string.

BUG=28689719
TEST=compile
TEST=runtest frameworks-wifi

Change-Id: I6ef3e07e38f33d8c5040dd358f161224095189d6

During 802.11 authentication, we've seen wpa_supplicant
report error information that is at odds with
over-the-air traffic.

For systems that provide packet fate for these early
frames, we can gather better information about the
auth process from the frames themselves.

Specifically: we can include the status code in the
packet fate summary. Make it so.

While there:
- fix a whitespace issue in parseIeee80211FrameCtrlType()
- rename frameControlField, since it didn't really hold
  all of the frame control info. (frameControlField
  omitted the frame control flags.)
- modify some packet fate tests to be less specific about
  expected whitespace; it's too hard to maintain the tests
  when exact whitespace matching is required

BUG=28717266
TEST=unit tests
TEST=manual

Manual test
- configure hostapd to allow zero connections
- configure bullhead to connect to hostapd
$ adb shell dumpsys > /tmp/dumpsys
- verify that packet fate summary shows auth frame with status 17

Change-Id: Ib8742091d0a9acc7fdde0423229d150bf4c1c6d8

Change-Id: I87779468d37971c53c1c9cfd615e5ca2e7a65108
Fixes: 28793104

Bug: 28437662
Change-Id: I9d478d644cc5b52a031a3ee3e157d40f952dff50

* changes:
  WifiController: set to proper state after SoftAP
  WifiControllerTest: cleanup style issues
  WifiSettingsStore: add methods for WifiSavedState

Now that writeApConfiguration has no return type, so we
should also ignore the value in the tests.

BUG=28692504
TEST=compile
TEST=runtest frameworks-wifi

Change-Id: Ia4a562335de2c1dcadb5f41dcb3dc9f96a926680

After receiving a CMD_AP_STOPPED message, WifiController should return
to the DeviceActive state or the appropriate Idle state.  This CL sets
the correct pending state and also adds a check for the idle state.
A test is also added to confirm the DeviceActive state is entered after
the SoftAp state is completed.

Note: An additional test for the DeviceIdle path will be added at a
later point after some code refactoring (bug 28669096)

BUG: 28434530
Change-Id: Ie19e66b9c84ff545a622119890bc7705ebd74c46

Clean up some style issues for WifiControllerTest.

This is in preparation for additional tests being added for the bug fix.

BUG: 28434530
Change-Id: Idfcc51e2d30753051b9d8e2ec066035f771f0339