Commit 439e5e49 authored by xiaoli.xb.zuo's avatar xiaoli.xb.zuo Committed by Marco Nelissen
Browse files

Fix memory leak in MediaScannerConnection

This patch adds releasing of MediaScannerConnection in ClientProxy
after disconnecting and releasing of ClientProxy and
IMediaScannerService in disconnection sequence in
MediaScannerConnection.

Bug: 30150344

Change-Id: I1e162e4c9a0b7a741ace20480bcf06f3151a93bf
parent 6c997934
......@@ -133,6 +133,10 @@ public class MediaScannerConnection implements ServiceConnection {
}
try {
mContext.unbindService(this);
if (mClient instanceof ClientProxy) {
mClient = null;
}
mService = null;
} catch (IllegalArgumentException ex) {
if (false) {
Log.v(TAG, "disconnect failed: " + ex);
......@@ -205,6 +209,7 @@ public class MediaScannerConnection implements ServiceConnection {
void scanNextPath() {
if (mNextPath >= mPaths.length) {
mConnection.disconnect();
mConnection = null;
return;
}
String mimeType = mMimeTypes != null ? mMimeTypes[mNextPath] : null;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment