GitLab

bug:2651952
this mode was previously available in Eclair and below. this mode was removed
by me for no particular reason in Froyo.
this change doesn't bring in any new modules into sqlite. just
allows FTS1 or 2 apps be used with FTS3 running in backward compatibility mode

Change-Id: Id5d72b440a378dd6d6703ce99b5d3d70ffd0c80f

sqlite doesn't think corruption when it detects bad file header. on android,
there should be no reason to try to open a database file and find
a bad header. so, add android patch to sqlite to assume corruption
when this occurs.

Change-Id: I6b26613852b5247799af35a9c8e166b32ba697ff

applying the following bug fixes
http://www.sqlite.org/src/info/82dd61fccf
   Sync the database file after a rollback
http://www.sqlite.org/src/info/6f368b5448
  Modify the sqlite3_log() interface and implementation so that it never
  uses dynamic memory allocation - to avoid deadlocking when called
  while holding the memory allocator mutex.

Change-Id: I93929d2dacd399ae9bd291404bcdf2c512691254

after the following CL is submitted, check this in
   Change-Id: If07d4f67facf9b5806b8cd11879bae51f8daf322

Change-Id: Ie3c20489265aebdb83657343d25f1e9ecb7f2d84

this is redoing the reverted CL
https://android-git.corp.google.com/g/#change,42672

sqlite3 from DRH broke mac builds.

this will remove a lot of android specific code from sqlite in
external/sqlite/dist.
we are getting closer to using the public domain sqlite.
 ******* NOTE TO REVIEWERS *********
to compare, don't use gerrit. that will compare this sqlite3.c with
the currently-checkin version, showing you the differences
between this sqlite version and the previous sqlite version.
you may not care about that.
if you just need to see what android changes to sqlite are,
then compare the following two files in this CL
    sqlite3.c.orig
    sqlite3.c

log a message until sqlite guy gives me a fix to implement logging of
such events in a more elegant way (like sqlite3_trace)

this STOPSHIP CL is adding to the previous STOPSHIP CL for this class of bugs
  https://android-git.corp.google.com/g/#change,40395

this CL wil have to be reverted before shipping. thats why the STOPSHIP
comment all over this CL.
goal is to get stacktrace to help debug http://b/2419869 because it is
intermittently occuring bug and sqlite3 doesn't give enough info
when this error occurs.
Richard Hipp of sqlite is going to send a patch that will provide additional
info when this error occurs.

that CL isn't so useful. and it introduced a bug too: http://b/issue?id=2418478
plus, it added code to sqlite3.c. need to avoid doing that wherever possible

patch from sqlite is http://www.sqlite.org/src/ci/26cb1df735

When database close() fails, sqlite gives a cryptic message
"unable to close due to unfinalised statements".
Added more info to this message to help developer look at one of the sql
statements that is not finalized and is causing this problem.

it has 2 bugs (1) needs to be extended to return strings longer than 1K
(2) the following bug
      create table a1 (i int, j varchar(5));
    insert 2 rows with j = ''
      insert into a1 values(1,'');
      insert into a1 values(1,'');
    insert 2 rows with j = null
      insert into a1 (i) values (2);
      insert into a1 (i) values (2);
    with original sqlite3 groupConcat func
       select length(group_concat(j,' ')) from a1 where i = 1;
    result is
       1
    with android sqlite3 groupConcat func
       select length(group_concat(j,' ')) from a1 where i = 2;
    result is
       0

unsupported file format error causes the database file NOT be deleted.
and that makes the app not recoverable.
by making it corruption error, db will get removed and app will get re-inited,
even though removing the DB is on corruption is extreme.
but that is a different issue..

this should help in identifying the line of code in sqlite3.c reporting
database corruption.
this is a redo of this CL: https://android-git.corp.google.com/g/#change,37799
(because the old CL was submitted to master branch, but I meant to submit it
to mr3)

you should notice the following from the Android changes in 3.5.9
1. Android Changes are grouped wherever possible.

To Do
1. sqlite3_get_pager_stats() needs to be completed
2. Android change lines 63480-63482 on master branch in sqlite3.c is
not ported yet. can't see where it goes in 3.6.22 code.

this should help in identifying the line of code in sqlite3.c reporting
database corruption.