Commits · nougat-cts-release · halo / external_skia

25 Feb, 2016 1 commit

mtklein authored 9 years ago

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1732353002

Review URL: https://codereview.chromium.org/1732353002

bb5f309b

18 Feb, 2016 1 commit

Port Skia recipe to normal Python scripts, move to Skia repo · d9fa7582

borenet authored 9 years ago

BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703663002

Review URL: https://codereview.chromium.org/1703663002

d9fa7582

15 Dec, 2015 1 commit

Add link to Gold trybot runs in every uploaded Skia CL · 11f457e1

rmistry authored 9 years ago

BUG=skia:4433
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521913005

Review URL: https://codereview.chromium.org/1521913005

11f457e1

07 Nov, 2015 1 commit

Comments Style: s/skbug.com/bug.skia.org/ · 6950de6c

halcanary authored 9 years ago

DOCS_PREVIEW= https://skia.org/?cl=1432503003

Review URL: https://codereview.chromium.org/1432503003

6950de6c

29 Oct, 2015 1 commit

Revert "Revert "Merge remote-tracking branch 'goog/master-skia' into goog/master"" · 2880df26

Tom Hudson authored 9 years ago

When I broke android yesterday we reverted this merge to fix the breakage.
Undoing that revert so we can pull in the fix from Skia.

2880df26

28 Oct, 2015 1 commit
- Revert "Merge remote-tracking branch 'goog/master-skia' into goog/master" · f7834221
  Tom Hudson authored 9 years ago
```
This reverts commit 0efb99a7.

Change-Id: I971811435410091088a932f79ddbe254fd80e79d
```
  f7834221
07 Oct, 2015 1 commit
- Automatically add TSAN bots to the CQ for changes affecting SkAtomics.h · ab8296b4
  mtklein authored 9 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/1396523002
```
  ab8296b4
01 Oct, 2015 2 commits

Automatically add extra CQ trybots for predetermined paths · 5827653e

rmistry authored 9 years ago

If the CL does not contain a "CQ_EXTRA_TRYBOTS=" section then it constructs one from the paths modified in your CL.

If you already have an existing "CQ_EXTRA_TRYBOTS=" section in your CL then it parses it, preserves your options, and only adds the builders and masters that were missing.

Also ensures no trybots are repeated (i.e. each master trybot combination only shows up once).

And I killed the hashtags feature in this CL, nobody was using it.

BUG=skia:4364

Review URL: https://codereview.chromium.org/1383743002

5827653e

Resolve TODOs in PRESUBMIT.py · 9806d4de
rmistry authored 9 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/1384453004
```
9806d4de

28 Jul, 2015 1 commit
- update presubmit to know about include/private · bda12677
  mtklein authored 9 years ago
```
BUG=skia:4126

Review URL: https://codereview.chromium.org/1259953004
```
  bda12677
01 Jul, 2015 4 commits

Revert "Move headers used by headers in include/ to include/private." · 478c9e48
Mike Klein authored 10 years ago
```
This reverts commit 928e1656.

BUG=skia:

Review URL: https://codereview.chromium.org/1213093004.
```
478c9e48

Move headers used by headers in include/ to include/private. · 928e1656

mtklein authored 10 years ago

Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h
used by (public) SkPictureRecorder.h.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/a89f55198bdc58f0b6f6196907ab25a6afc1a661

Review URL: https://codereview.chromium.org/1217293004

928e1656

Revert "Move headers used by headers in include/ to include/private." · 4417c7f8

jvanverth authored 10 years ago

This reverts commit a89f5519.

Reason: breaking the roll.

TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1216033008

4417c7f8

Move headers used by headers in include/ to include/private. · a89f5519

mtklein authored 10 years ago

Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h
used by (public) SkPictureRecorder.h.

BUG=skia:

Review URL: https://codereview.chromium.org/1217293004

a89f5519

04 Jun, 2015 1 commit
- Presubmit: add PRESUBMIT=false to non-master branch changes · af6005c8
  borenet authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/1161973005
```
  af6005c8
05 May, 2015 1 commit
- Add presubmit to run `{dm,nanobench}_flags.py test` when changed. · e4b19c45
  mtklein authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/1129443005
```
  e4b19c45
07 Apr, 2015 1 commit
- Bypass owners check for dry run CLs. · 04abf130
  rmistry authored 10 years ago
```
BUG=skia:
NOTRY=true

Review URL: https://codereview.chromium.org/1068853002
```
  04abf130
01 Apr, 2015 1 commit

Find the HASHTAGS file even if you are not at the checkout root. · 57291dcc

rmistry authored 10 years ago

The post upload hook was failing if you were not at the root, this fixes it.

NOTRY=true

Review URL: https://codereview.chromium.org/1058483002

57291dcc

25 Mar, 2015 3 commits

Add post upload hook to substitute hashtags for their mapped text · 3cfd1ad6
rmistry authored 10 years ago
```
BUG=skia:3586
NOTRY=true

Review URL: https://codereview.chromium.org/1004733009
```
3cfd1ad6

More file types to check for (C). · 18e55800

mtklein authored 10 years ago

 - objective C++           (31)
 - objective C             (4)
 - C                       (2)
 - alternate C++ extension (1)
 - Go                      (1)

BUG=skia:

Review URL: https://codereview.chromium.org/1032143002

18e55800

Add copyright check to PRESUBMIT · c7c91806
borenet authored 10 years ago
```
BUG=skia:1724

Review URL: https://codereview.chromium.org/1003363005
```
c7c91806

12 Mar, 2015 4 commits

Ignore public API checks if COMMIT=false is in the description · f91b717a

rmistry authored 10 years ago

BUG=skia:
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621

Review URL: https://codereview.chromium.org/1006473002

f91b717a

Revert of Ignore public API checks if COMMIT=false is in the description... · a10ea431

mtklein authored 10 years ago

Revert of Ignore public API checks if COMMIT=false is in the description (patchset #4 id:80001 of https://codereview.chromium.org/1006473002/)

Reason for revert:
I cannot upload patches:

~/skia (skskp) $ git clu --bypass-hooks
++ git log -1 --pretty=%B
+ git cl upload -t update
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /Users/mtklein/.codereview_upload_cookies
Running presubmit upload checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Original issue's description:
> Ignore public API checks if COMMIT=false is in the description
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621

TBR=borenet@google.com,rmistry@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1005583002

a10ea431

Ignore public API checks if COMMIT=false is in the description · d1783aef
rmistry authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/1006473002
```
d1783aef
Make presubmit check that #if or #ifdef does not come before includes. · 01cbf6c4
rmistry authored 10 years ago
```
BUG=skia:3362

Review URL: https://codereview.chromium.org/998273002
```
01cbf6c4

26 Feb, 2015 2 commits

Automatically add NOTREECHECKS when uploading CLs from non master branches · 896f3932

rmistry authored 10 years ago

These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').

BUG=skia:

Review URL: https://codereview.chromium.org/963553002

896f3932

Automatically add a docs preview link and NOTRY=true when there are only docs changes. · d223fb21

rmistry authored 10 years ago

These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').

BUG=skia:3474

Review URL: https://codereview.chromium.org/960203002

d223fb21

26 Aug, 2014 2 commits

PRESUBMIT should only check owners for the top level include directory · 9407eceb

rmistry authored 10 years ago

BUG=skia:1846
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/511503002

9407eceb

Public API changes are allowed if an owner is TBR'ed. · f2d83caf

rmistry authored 10 years ago

The following TBR formats are supported:
* TBR=reed
* TBR=reed@google.com
* TBR=xyz,reed
* TBR=xyz,reed@google.com

BUG=skia:2870
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/504843003

f2d83caf

18 Jul, 2014 1 commit

Adding djsollen to list of owners · 83fab473

rmistry authored 11 years ago

(SkipBuildbotRuns)

BUG=skia:
R=djsollen@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/397813007

83fab473

25 Jun, 2014 1 commit

Use new common tools in Python scripts · bb0ef0a1

Eric Boren authored 11 years ago

BUG=skia:2682
R=rmistry@google.com

Review URL: https://codereview.chromium.org/330423004

bb0ef0a1

03 Feb, 2014 1 commit

Check if the issue owner is in the AUTHORS file in PRESUBMIT.py · 745e08ca

commit-bot@chromium.org authored 11 years ago

BUG=skia:2072
NOTRY=true
(SkipBuildbotRuns)

R=borenet@google.com, hcm@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/131293005

git-svn-id: http://skia.googlecode.com/svn/trunk@13277 2bbb7eff-a529-9590-31e7-b0007b416f81

745e08ca

31 Jan, 2014 1 commit

Do not enforce the public API presubmit check for Revert CLs. · cfdc5962

commit-bot@chromium.org authored 11 years ago

NOTRY=true

BUG=skia:2068
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/151573002

git-svn-id: http://skia.googlecode.com/svn/trunk@13270 2bbb7eff-a529-9590-31e7-b0007b416f81

cfdc5962

28 Jan, 2014 1 commit

Adding rmistry for emergency reverts. · c2490880

commit-bot@chromium.org authored 11 years ago

(SkipBuildbotRuns)

TBR=
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/148583005

git-svn-id: http://skia.googlecode.com/svn/trunk@13212 2bbb7eff-a529-9590-31e7-b0007b416f81

c2490880

13 Aug, 2013 1 commit
- Snapshot from http://skia.googlecode.com/svn/trunk@10680 · e27eefc4
  Derek Sollenberger authored 11 years ago
```
Change-Id: I846e489575859eff43302c698606953c58420671
```
  e27eefc4
12 Aug, 2013 1 commit

If any change is made to the public API then make sure there is an LGTM from an owner. · fb4a68de

rmistry@google.com authored 11 years ago

This feature has been requested by reed@.

If no LGTM is found from an owner then the following msg is displayed:

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com')

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/22453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81

fb4a68de

23 May, 2013 1 commit
- Snapshot from http://skia.googlecode.com/svn/trunk@9231 · 7839ce1a
  Derek Sollenberger authored 12 years ago
```
Change-Id: I384e5f43ceb90b1a2e58a1e33753b3e79c85b949
```
  7839ce1a
12 Apr, 2013 1 commit

If the tree is closed then print information about contacting the sheriff. · 547012dc

rmistry@google.com authored 12 years ago

The motivation for this CL is because it is not very obvious on how to submit when tree is closed in git.

Also added a section 'How to submit when tree is closed' in https://sites.google.com/site/skiadocs/developer-documentation/tree-sheriff

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13932026

git-svn-id: http://skia.googlecode.com/svn/trunk@8666 2bbb7eff-a529-9590-31e7-b0007b416f81

547012dc

29 Mar, 2013 1 commit

Display prompt for caution only if it is an interactive shell. · f6c5f75b

rmistry@google.com authored 12 years ago

Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution.

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13325002

git-svn-id: http://skia.googlecode.com/svn/trunk@8446 2bbb7eff-a529-9590-31e7-b0007b416f81

f6c5f75b

14 Feb, 2013 1 commit
- Revert "Merge remote-tracking branch 'goog/master-chromium' into 'goog/master'" DO NOT MERGE · 6a07c772
  Chris Craik authored 12 years ago
```
This reverts commit ee9208ea, reversing
changes made to 2dad6229.

Change-Id: Id7f0fb0a3c46bcf9ae0e90de83661f8eadb30bfc
```
  6a07c772