Commits · f6bfccd562f4ac071db9902097ad4bea83294085 · halo / external_skia

25 Feb, 2016 1 commit

benjaminwagner authored 9 years ago

This CL relands https://codereview.chromium.org/1683743005/ with two fixes:
  - Removing the test for vertical text. Vertical text doesn't work on Windows and breakText isn't supported for non-trivial text.
  - Omit PaintBreakTextTest in Google3 because we don't have the correct font setup yet.

Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.

Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.

Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005

Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c

patch from issue 1683743005 at patchset ...

f6bfccd5

24 Feb, 2016 2 commits

Revert of Simple cleanups related to SkFixed. (patchset #4 id:120001 of... · c2d35d85

benjaminwagner authored 9 years ago

Revert of Simple cleanups related to SkFixed. (patchset #4 id:120001 of https://codereview.chromium.org/1683743005/ )

Reason for revert:
New test is failing on Windows.

Original issue's description:
> Cleanups related to SkFixed.
>
> Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
>
> Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
>
> Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
>
> BUG=skia:4632
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005
>
> Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c

TBR=mtklein@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4632

Review URL: https://codereview.chromium.org/1724283003

c2d35d85

Cleanups related to SkFixed. · 7ea5cb18

benjaminwagner authored 9 years ago

Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.

Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.

Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005

Review URL: https://codereview.chromium.org/1683743005

7ea5cb18

04 Jan, 2016 1 commit

handle halfway case in scan converter · 6df61157

caryclark authored 9 years ago

Scan edges that start at exactly -0.5 aren't trimmed by
clipping or by rounding, triggering a debug assert.

One way to fix this is to round the top and left
down instead of up.

Also, move the path initialization of gm/composeshader.cpp
to make debugging other path problems easier.

R=reed@google.com
BUG=skia:2715
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1544873002

Review URL: https://codereview.chromium.org/1544873002

6df61157

01 May, 2015 1 commit
- Simple CL to add a joinWithPossiblyEmptyArg to SkRect · 3dc2ccae
  joshualitt authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/1118293002
```
  3dc2ccae
28 Apr, 2015 1 commit

Remove useless SkASSERT in SkRect.h and SkRegion.h · 79612de0

dongseong.hwang authored 10 years ago

The pointer of reference is always not-null. It causes >50k lines of warnning when chromium is compiled by clang.
Warning looks like
../../third_party/skia/include/core/SkRect.h:284:19: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
    do { if (&r) break; SkNO_RETURN_HINT(); SkDebugf_FileLine("../../third_party/skia/include/core/SkRect.h", 284, false, "%s:%d: failed assertion \"%s\"\n", "../../third_party/skia/include/core/SkRect.h", 284, "&r"); SkDebugf_FileLine("../../third_party/skia/include/core/SkRect.h", 284, true, "SK_CRASH"); } while (false);

Review URL: https://codereview.chromium.org/1111013002

79612de0

13 Mar, 2015 1 commit
- some utils for rect and matrix · 11fa2247
  reed authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/1003813003
```
  11fa2247
25 Feb, 2015 3 commits

I'd really like to land this before the branch so speedy reviews are appreciated. · 570d2f81

joshualitt authored 10 years ago

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/586d5d640b19860dfbbd903a5188da1bbbe87336

Review URL: https://codereview.chromium.org/936943002

570d2f81

Revert of Pass clip to context (patchset #8 id:180001 of... · 2907059d

joshualitt authored 10 years ago

Revert of Pass clip to context (patchset #8 id:180001 of https://codereview.chromium.org/936943002/)

Reason for revert:
Strange blur problems on nexus 5

Original issue's description:
> I'd really like to land this before the branch so speedy reviews are appreciated.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/586d5d640b19860dfbbd903a5188da1bbbe87336

TBR=jvanverth@google.com,senorblanco@google.com,bsalomon@google.com,senorblanco@chromium.org,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/956083002

2907059d

I'd really like to land this before the branch so speedy reviews are appreciated. · 586d5d64
joshualitt authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/936943002
```
586d5d64

23 Feb, 2015 1 commit
- Move clip off of draw target · 44701df5
  joshualitt authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/947443003
```
  44701df5
07 Jan, 2015 3 commits

It is dangerous to ignore SkRect::intersect's return value · f4e5995a

robertphillips authored 10 years ago

Committed: https://skia.googlesource.com/skia/+/152f524fd325b7776b01f84afbfe2fa071648a05

Review URL: https://codereview.chromium.org/833943002

f4e5995a

Revert of It is dangerous to ignore SkRect::intersect's return value (patchset... · 690fc594

robertphillips authored 10 years ago

Revert of It is dangerous to ignore SkRect::intersect's return value (patchset #6 id:100001 of https://codereview.chromium.org/833943002/)

Reason for revert:
Still more Chromium clean up to do

Original issue's description:
> It is dangerous to ignore SkRect::intersect's return value
>
> Committed: https://skia.googlesource.com/skia/+/152f524fd325b7776b01f84afbfe2fa071648a05

TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/825983005

690fc594

It is dangerous to ignore SkRect::intersect's return value · 152f524f
robertphillips authored 10 years ago
```
Review URL: https://codereview.chromium.org/833943002
```
152f524f

16 Dec, 2014 1 commit

add sample for arcTo · a7a8b101

reed authored 10 years ago

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/808793002

a7a8b101

15 Dec, 2014 3 commits

pass dst-rect through from drawBitmapRect for better precision · 0393912d
reed authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/797963002
```
0393912d

Rewrite NaN checks in terms of SkScalarIsNaN() · 6f904756

ehsan.akhgari authored 10 years ago

We are trying to replace Skia's NaN checker with our own in Mozilla,
so it would be nice to have to patch a single place by making sure
these NaN checks used SkScalarIsNaN().

BUG=skia:

Review URL: https://codereview.chromium.org/809443002

6f904756

add dumpHex option to rect and rrect, to match path · e05fed0d
reed authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/801383002
```
e05fed0d

19 Nov, 2014 2 commits
- add roundOut that returns its result · b07a94f1
  reed authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/742663002
```
  b07a94f1
- change roundOut() to take a dst, so we can use that signature to return IRect · d02cf266
  reed authored 10 years ago
```
BUG=skia:
TBR=robertphilips

Review URL: https://codereview.chromium.org/731373003
```
  d02cf266
03 Nov, 2014 1 commit

Optimize SkRect::sort() · fb502f07

qiankun.miao authored 10 years ago

This optimization can reduce comparison and assignments. For
geo_rect_sort benchmark, performance improved to 1.63us from 3.28us.

BUG=skia:

Review URL: https://codereview.chromium.org/695443005

fb502f07

15 Oct, 2014 1 commit
- add tests for large cordinates bounds when building aaclip · 157f36d3
  reed authored 10 years ago
```
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/658753002
```
  157f36d3
10 Oct, 2014 1 commit

faster SkRect::sort · 40636a53

reed authored 10 years ago

BUG=skia:

Review URL: https://codereview.chromium.org/646863002

40636a53

09 Oct, 2014 1 commit
- cleanup and optimize rect intersect routines · 1119c870
  reed authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/640723004
```
  1119c870
01 Oct, 2014 1 commit
- add SkRect::joinNonEmptyArg for faster unioning · 10d0327c
  reed authored 10 years ago
```
BUG=skia:

Review URL: https://codereview.chromium.org/619853005
```
  10d0327c
18 Sep, 2014 1 commit

update to accommodate latest clang in chrome toolchain · a10742c6

caryclark authored 10 years ago

remove asserts for null pointers to references
change var args signature to pointer instead of array

R=mtklein@google.com, reed@android.com, reed@google.com, mtklein, reed

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/577243002

a10742c6

09 Jun, 2014 1 commit

Add dump() to SkClipStack to help with debugging. · b6b02526

bsalomon authored 11 years ago

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/311263015

b6b02526

02 Jun, 2014 1 commit

add makeOffset and makeInset to SkRect · 5c404c55

reed authored 11 years ago

TBR=bsalomon

precursor for https://codereview.chromium.org/306013010

Author: reed@google.com

Review URL: https://codereview.chromium.org/306893012

5c404c55

05 May, 2014 1 commit

add rounding-using-doubles methods on SkScalar and SkRect · 4e332f82

commit-bot@chromium.org authored 11 years ago

Inspired by the excellent repro case for https://crbug.com/364224

patch from issue 265933010

BUG=skia:
R=bungeman@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/267003002

git-svn-id: http://skia.googlecode.com/svn/trunk@14566 2bbb7eff-a529-9590-31e7-b0007b416f81

4e332f82

01 Jan, 2014 1 commit

speedup SkRect::intersect · ae8f9528

mike@reedtribe.org authored 11 years ago

git-svn-id: http://skia.googlecode.com/svn/trunk@12851 2bbb7eff-a529-9590-31e7-b0007b416f81

ae8f9528

17 Dec, 2013 1 commit

remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats · 8f4d2306

reed@google.com authored 11 years ago

To keep the CL (slightly) managable, this does not make any changes to
existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this
time around.

BUG=
R=bsalomon@google.com, caryclark@google.com

Review URL: https://codereview.chromium.org/117053002

git-svn-id: http://skia.googlecode.com/svn/trunk@12712 2bbb7eff-a529-9590-31e7-b0007b416f81

8f4d2306

07 Nov, 2013 1 commit

Revert "Revert "speed up A8 by creating a new entry-point in SkDraw that blits... · 126f7f52

reed@google.com authored 11 years ago

Revert "Revert "speed up A8 by creating a new entry-point in SkDraw that blits the path's coverage directly into an A8 target, regardless of the previous pixel values.""

This reverts commit 3c77887b3eb2d32ab668ab4e5f2f9e79103956e8.

BUG=

Review URL: https://codereview.chromium.org/50673005

git-svn-id: http://skia.googlecode.com/svn/trunk@12167 2bbb7eff-a529-9590-31e7-b0007b416f81

126f7f52

04 Nov, 2013 2 commits

Revert "speed up A8 by creating a new entry-point in SkDraw that blits the... · 84e922bf

reed@google.com authored 11 years ago

Revert "speed up A8 by creating a new entry-point in SkDraw that blits the path's coverage directly into an A8 target, regardless of the previous pixel values."

This reverts commit d615e839b71f75df895de6850b774a9e1c28ad2a.

Revert "must initialize SkDraw.fClip"

This reverts commit 108e46d29b5f57927fc8b8c403bb52019d8cb16d.

BUG=

Review URL: https://codereview.chromium.org/57883006

git-svn-id: http://skia.googlecode.com/svn/trunk@12122 2bbb7eff-a529-9590-31e7-b0007b416f81

84e922bf

speed up A8 by creating a new entry-point in SkDraw that blits the path's... · ac9d306a

reed@google.com authored 11 years ago

speed up A8 by creating a new entry-point in SkDraw that blits the path's coverage directly into an A8 target, regardless of the previous pixel values.

R=bsalomon@google.com, mtklein@google.com

Review URL: https://codereview.chromium.org/56453002

git-svn-id: http://skia.googlecode.com/svn/trunk@12118 2bbb7eff-a529-9590-31e7-b0007b416f81

ac9d306a

31 Oct, 2013 3 commits

Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome,... · 4469938e

reed@google.com authored 11 years ago

Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning""

This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d.

BUG=

Review URL: https://codereview.chromium.org/54603004

git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81

4469938e

Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning" · 6fcbfcea

reed@google.com authored 11 years ago

This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497.

git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81

6fcbfcea

add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning · 081560e3

reed@google.com authored 11 years ago

BUG=
R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org

Review URL: https://codereview.chromium.org/51033004

git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81

081560e3

30 Oct, 2013 1 commit

remove contains(x,y) for rects and rrects ... not well defined, and unused · 4db592c4

reed@google.com authored 11 years ago

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/51953003

git-svn-id: http://skia.googlecode.com/svn/trunk@12022 2bbb7eff-a529-9590-31e7-b0007b416f81

4db592c4

10 Oct, 2013 1 commit

Change SkImageFilter's cropRect from SkIRect to a CropRect struct, containing... · b295fb6f

senorblanco@chromium.org authored 11 years ago

Change SkImageFilter's cropRect from SkIRect to a CropRect struct, containing an SkRect and flags indicating which parameters are set.

NOTE: this will require SK_CROP_RECT_IS_INT=1 to be set in Chrome until Blink has been updated to use SkImageFilter::CropRect. Include https://codereview.chromium.org/26528002/ with the Skia roll.

Note also that SK_CROP_RECT_IS_INT is a temporary measure until all call sites in Blink have been updated to use SkRect.

R=reed@google.com

Review URL: https://codereview.chromium.org/26371002

git-svn-id: http://skia.googlecode.com/svn/trunk@11692 2bbb7eff-a529-9590-31e7-b0007b416f81

b295fb6f

16 Sep, 2013 1 commit

Revert 11247, 11250, 11251, 11257, and 11279 to unblock DEPS roll... · 24ddde97

robertphillips@google.com authored 11 years ago

Revert 11247, 11250, 11251, 11257, and 11279 to unblock DEPS roll (https://codereview.chromium.org/24159002/)

11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279
11257 Canary build fix - https://codereview.chromium.org/23532068
11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251
11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250
11247 Initial error handling code - https://chromiumcodereview.appspot.com/23021015

git-svn-id: http://skia.googlecode.com/svn/trunk@11288 2bbb7eff-a529-9590-31e7-b0007b416f81

24ddde97