Commits · b8f3655d492fc602c252f6fcc9aba3d37d8d59f4 · halo / external_skia

22 Jul, 2013 6 commits

bungeman@google.com authored 11 years ago

This is a step toward targets declaring their deps in a sane fashion.
This change resolves cycles by forcing core to the root, then everything
in skia_lib pointing toward core as best possible, then everything
outside skia_lib depending on skia_lib for things in skia_lib. This
prevents double definitions where a symbol is provided by both the
skia_lib shared object and and a statically linked component of skia_lib.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19823003

git-svn-id: http://skia.googlecode.com/svn/trunk@10231 2bbb7eff-a529-9590-31e7-b0007b416f81

b8f3655d

Update android_make to use arrays instead of space delimited strings · 489ba1da

djsollen@google.com authored 11 years ago

R=borenet@google.com

Review URL: https://codereview.chromium.org/19796008

git-svn-id: http://skia.googlecode.com/svn/trunk@10230 2bbb7eff-a529-9590-31e7-b0007b416f81

489ba1da

refactor gyp to isolate freetype usage · 2679ff8b

djsollen@google.com authored 11 years ago

R=bungeman@google.com

Review URL: https://codereview.chromium.org/19835002

git-svn-id: http://skia.googlecode.com/svn/trunk@10229 2bbb7eff-a529-9590-31e7-b0007b416f81

2679ff8b

Make the copy of fontconfig font names before freeing their memory. · 02dd688d

bungeman@google.com authored 11 years ago

R=reed@google.com

Review URL: https://codereview.chromium.org/19466004

git-svn-id: http://skia.googlecode.com/svn/trunk@10228 2bbb7eff-a529-9590-31e7-b0007b416f81

02dd688d

Revert "migrate skpdiff to tools" · 904f86e6

zachr@google.com authored 11 years ago

This reverts commit 58a7ec70ce6b4548793a2ddc37c63d3d44edbc36.

git-svn-id: http://skia.googlecode.com/svn/trunk@10226 2bbb7eff-a529-9590-31e7-b0007b416f81

904f86e6

migrate skpdiff to tools · a54aaf7f

zachr@google.com authored 11 years ago

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19671002

git-svn-id: http://skia.googlecode.com/svn/trunk@10225 2bbb7eff-a529-9590-31e7-b0007b416f81

a54aaf7f

20 Jul, 2013 3 commits

Add SkNWayCanvas comment API overrides. · 14cec91f

commit-bot@chromium.org authored 11 years ago

SkNWayCanvas should also dispatch beginCommentGroup(), addComment() & endCommentGroup.

R=robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19723012

git-svn-id: http://skia.googlecode.com/svn/trunk@10224 2bbb7eff-a529-9590-31e7-b0007b416f81

14cec91f

Sanitizing source files in Housekeeper-Nightly · 1f3c7382
skia.committer@gmail.com authored 11 years ago
```
git-svn-id: http://skia.googlecode.com/svn/trunk@10223 2bbb7eff-a529-9590-31e7-b0007b416f81
```
1f3c7382

Revert deps changes in r10220 and r10217. · 899f1d85

bungeman@google.com authored 11 years ago

Need to avoid linking in .a things which are already provided by .so things.


git-svn-id: http://skia.googlecode.com/svn/trunk@10222 2bbb7eff-a529-9590-31e7-b0007b416f81

899f1d85

19 Jul, 2013 31 commits

Add a 'unique' method to SkRefCnt, document the usage, and add support. · f64c6842

bungeman@google.com authored 11 years ago

std::shared_ptr has a method called 'unique' which captures the concept that
a reference count of 1 is special, and can be used to optimize copy on write.
It also has some undocumented need for memory barriers in certain situations
and those needs are documented here.

The motivation for looking into this is crbug.com/258499 . The use of the
reference count in this manner is a benign race with both ref() and unref().
By introducing sk_atomic_unprotected_read, it is possible for Chromium to
annotate this read to tell ThreadSanitizer that this is known.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18770007

git-svn-id: http://skia.googlecode.com/svn/trunk@10221 2bbb7eff-a529-9590-31e7-b0007b416f81

f64c6842

Lie about views_animated dependencies until Android situation is resolved. · 13388e71
bungeman@google.com authored 11 years ago
```
git-svn-id: http://skia.googlecode.com/svn/trunk@10220 2bbb7eff-a529-9590-31e7-b0007b416f81
```
13388e71
Fix latent warning as error in Android specific code. · 99e789c2
bungeman@google.com authored 11 years ago
```
git-svn-id: http://skia.googlecode.com/svn/trunk@10219 2bbb7eff-a529-9590-31e7-b0007b416f81
```
99e789c2

Add a detachAsStream to SkDynamicMemoryWStream. · c29f3d8c

bungeman@google.com authored 11 years ago

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10171

Committed: https://code.google.com/p/skia/source/detail?r=10178

Review URL: https://codereview.chromium.org/19677002

git-svn-id: http://skia.googlecode.com/svn/trunk@10218 2bbb7eff-a529-9590-31e7-b0007b416f81

c29f3d8c

Update obvious deps. · 2b0ab9e1

bungeman@google.com authored 11 years ago

This is a step toward targets declaring their deps in a sane fashion.
This change resolves cycles by forcing core to the root,
then opts, ports, and utils depending on core, then everything else.
We will need some other change to resolve the fact that
core, opts, ports, and utils depend on each other and other targets which
depend on them. Outside of these targets, things look ok.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19823003

git-svn-id: http://skia.googlecode.com/svn/trunk@10217 2bbb7eff-a529-9590-31e7-b0007b416f81

2b0ab9e1

Fix some noisy warnings on Windows x64. · 777ded06

bungeman@google.com authored 11 years ago

On Windows x64, sizeof(long) < sizeof(size_t).

Review URL: https://codereview.chromium.org/19786010

git-svn-id: http://skia.googlecode.com/svn/trunk@10216 2bbb7eff-a529-9590-31e7-b0007b416f81

777ded06

Revert "Slipping in a small bug fix for my previous patch" · faeb18bb

reed@google.com authored 11 years ago

This reverts commit 1908ef0441e37c98b00ffe6c0a89d247393aeead.

git-svn-id: http://skia.googlecode.com/svn/trunk@10215 2bbb7eff-a529-9590-31e7-b0007b416f81

faeb18bb

bad line in gyp fie snuck into last commit, continuing the ARM breakage · 8ac834b0
humper@google.com authored 11 years ago
```
git-svn-id: http://skia.googlecode.com/svn/trunk@10214 2bbb7eff-a529-9590-31e7-b0007b416f81
```
8ac834b0

Slipping in a small bug fix for my previous patch · 0817fb6e

sglez@google.com authored 11 years ago

Review URL: https://codereview.chromium.org/19858002

git-svn-id: http://skia.googlecode.com/svn/trunk@10213 2bbb7eff-a529-9590-31e7-b0007b416f81

0817fb6e

use SK_ScalarPI, and fix ARM build · 16acf751

humper@google.com authored 11 years ago

git-svn-id: http://skia.googlecode.com/svn/trunk@10212 2bbb7eff-a529-9590-31e7-b0007b416f81

16acf751

struct and class forward declarations incompatible on some compilers · dd85088c
humper@google.com authored 11 years ago
```
git-svn-id: http://skia.googlecode.com/svn/trunk@10211 2bbb7eff-a529-9590-31e7-b0007b416f81
```
dd85088c

scale --> convolution typo · f4366838

humper@google.com authored 11 years ago

git-svn-id: http://skia.googlecode.com/svn/trunk@10210 2bbb7eff-a529-9590-31e7-b0007b416f81

f4366838

missing M_PI include needed on Windows · f131cdee
humper@google.com authored 11 years ago
```
git-svn-id: http://skia.googlecode.com/svn/trunk@10209 2bbb7eff-a529-9590-31e7-b0007b416f81
```
f131cdee

remove unused function · ab56cdab

humper@google.com authored 11 years ago

git-svn-id: http://skia.googlecode.com/svn/trunk@10208 2bbb7eff-a529-9590-31e7-b0007b416f81

ab56cdab

fix mac · 5f3f681d

sglez@google.com authored 11 years ago

BUG=

Review URL: https://codereview.chromium.org/19845003

git-svn-id: http://skia.googlecode.com/svn/trunk@10207 2bbb7eff-a529-9590-31e7-b0007b416f81

5f3f681d

The image resampling code has been transplanted from Chrome; it's incredibly fast. · 138ebc3e

humper@google.com authored 11 years ago

We've tested this CL plumbed into Chrome and done benchmarking with excellent results.

This CL can land independent of any Chrome changes; it's completely internal to skia.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/19335002

git-svn-id: http://skia.googlecode.com/svn/trunk@10206 2bbb7eff-a529-9590-31e7-b0007b416f81

138ebc3e

Revert "Adds SkPDFResourceDict class to manage resource dicts. Refactors... · d322cf49

vandebo@chromium.org authored 11 years ago

Revert "Adds SkPDFResourceDict class to manage resource dicts. Refactors existing code to use this class."

This reverts commit r10202

Review URL: https://codereview.chromium.org/19790007

git-svn-id: http://skia.googlecode.com/svn/trunk@10205 2bbb7eff-a529-9590-31e7-b0007b416f81

d322cf49

please fix the build, please · 1d38ae91

sglez@google.com authored 11 years ago

BUG=

Review URL: https://codereview.chromium.org/19693012

git-svn-id: http://skia.googlecode.com/svn/trunk@10204 2bbb7eff-a529-9590-31e7-b0007b416f81

1d38ae91

Add include to fix build · fc9eb1b8

sglez@google.com authored 11 years ago

BUG=

Review URL: https://codereview.chromium.org/19516006

git-svn-id: http://skia.googlecode.com/svn/trunk@10203 2bbb7eff-a529-9590-31e7-b0007b416f81

fc9eb1b8

Adds SkPDFResourceDict class to manage resource dicts. Refactors existing code to use this class. · c84fb471

commit-bot@chromium.org authored 11 years ago

BUG=
R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18977002

git-svn-id: http://skia.googlecode.com/svn/trunk@10202 2bbb7eff-a529-9590-31e7-b0007b416f81

c84fb471

Fix build problem with reverted issue 16948011 · 6645cde4

commit-bot@chromium.org authored 11 years ago

BUG=
R=caryclark@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/19541009

git-svn-id: http://skia.googlecode.com/svn/trunk@10201 2bbb7eff-a529-9590-31e7-b0007b416f81

6645cde4

Remove unneeded mention of SkThread_pthread.cpp in ports.gyp. · fc70a4ae

bungeman@google.com authored 11 years ago

This was overlooked in r10105.


git-svn-id: http://skia.googlecode.com/svn/trunk@10200 2bbb7eff-a529-9590-31e7-b0007b416f81

fc70a4ae

Bench performance trigger rebaselines · d2fd07c5

robertphillips@google.com authored 11 years ago

(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@10198 2bbb7eff-a529-9590-31e7-b0007b416f81

d2fd07c5

Fix texture allocation in SWMaskHelper · d92cf2eb

robertphillips@google.com authored 11 years ago

https://codereview.chromium.org/19789006/



git-svn-id: http://skia.googlecode.com/svn/trunk@10197 2bbb7eff-a529-9590-31e7-b0007b416f81

d92cf2eb

revert unreviewed 10194, will send to review · 05b7bef0

edisonn@google.com authored 11 years ago

Review URL: https://codereview.chromium.org/19693010

git-svn-id: http://skia.googlecode.com/svn/trunk@10196 2bbb7eff-a529-9590-31e7-b0007b416f81

05b7bef0

SkAlpha constant defs · 9fdb7057

commit-bot@chromium.org authored 11 years ago

R=edisonn@google.com, vandebo@chromium.org, reed@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19592014

git-svn-id: http://skia.googlecode.com/svn/trunk@10195 2bbb7eff-a529-9590-31e7-b0007b416f81

9fdb7057

skpdiff: add ability to write the diff scores in a csv file (one line per pair... · 9345d94d

edisonn@google.com authored 11 years ago

skpdiff: add ability to write the diff scores in a csv file (one line per pair of diff images, with the result of each diff engine)

Review URL: https://codereview.chromium.org/19786004

git-svn-id: http://skia.googlecode.com/svn/trunk@10194 2bbb7eff-a529-9590-31e7-b0007b416f81

9345d94d

Alter resource cache and GrContext to (optionally) never reuse a scratch texture · e4eaea2d
robertphillips@google.com authored 11 years ago
```
https://codereview.chromium.org/19482004/



git-svn-id: http://skia.googlecode.com/svn/trunk@10193 2bbb7eff-a529-9590-31e7-b0007b416f81
```
e4eaea2d

add reformat-json.py script · 727b33fa

epoger@google.com authored 11 years ago

R=borenet@google.com

Review URL: https://codereview.chromium.org/19289011

git-svn-id: http://skia.googlecode.com/svn/trunk@10192 2bbb7eff-a529-9590-31e7-b0007b416f81

727b33fa

Add a detachAsStream to SkDynamicMemoryWStream. · 88682b77

bungeman@google.com authored 11 years ago

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10171

Review URL: https://codereview.chromium.org/19677002

git-svn-id: http://skia.googlecode.com/svn/trunk@10178 2bbb7eff-a529-9590-31e7-b0007b416f81

88682b77

Sanitizing source files in Housekeeper-Nightly · a7991988
skia.committer@gmail.com authored 11 years ago
```
git-svn-id: http://skia.googlecode.com/svn/trunk@10175 2bbb7eff-a529-9590-31e7-b0007b416f81
```
a7991988