GitLab

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/251133008

git-svn-id: http://skia.googlecode.com/svn/trunk@14455 2bbb7eff-a529-9590-31e7-b0007b416f81

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/260713003

git-svn-id: http://skia.googlecode.com/svn/trunk@14454 2bbb7eff-a529-9590-31e7-b0007b416f81

git-svn-id: http://skia.googlecode.com/svn/trunk@14453 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=368107
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/254083002

git-svn-id: http://skia.googlecode.com/svn/trunk@14452 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=skia:2473
NOTRY=true
R=caryclark@google.com
TBR=caryclark@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/254093002

git-svn-id: http://skia.googlecode.com/svn/trunk@14451 2bbb7eff-a529-9590-31e7-b0007b416f81

this was introduced in https://codereview.chromium.org/245963010

this was detected by caryclark@ by examining the result of valgrind on the skia buildbots

BUG=skia:1976
R=caryclark@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/255253002

git-svn-id: http://skia.googlecode.com/svn/trunk@14450 2bbb7eff-a529-9590-31e7-b0007b416f81

bench rebase test 4610a465
BUG=skia:2466
R=bensong@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: epoger@google.com

Review URL: https://codereview.chromium.org/263483002

git-svn-id: http://skia.googlecode.com/svn/trunk@14449 2bbb7eff-a529-9590-31e7-b0007b416f81

Reason for revert:
errors

Original issue's description:
> Improve Android scripts:
>
> * android_gdbserver:
>   - Don't complain if $GDB_TMP_DIR already exists
>   - Since $GDB_TMP_DIR/gdb.setup might already exist, overwrite the file.
>
> * android_run_skia:
>   - Move resource files onto the device.
>   - Change to tmp directory before executing program.
>
> * android_make, android_setup:
>   - stop assuming PWD is skia source directory.
>
> NOTRY=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=14442

R=djsollen@google.com, scroggo@google.com
TBR=djsollen@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/254073003

git-svn-id: http://skia.googlecode.com/svn/trunk@14448 2bbb7eff-a529-9590-31e7-b0007b416f81

R=reed@android.com
TBR=reed
NOTRY=true
NOTREECHECK=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/263473002

git-svn-id: http://skia.googlecode.com/svn/trunk@14447 2bbb7eff-a529-9590-31e7-b0007b416f81

bench rebase test 4610a465
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: epoger@google.com

Review URL: https://codereview.chromium.org/258393002

git-svn-id: http://skia.googlecode.com/svn/trunk@14446 2bbb7eff-a529-9590-31e7-b0007b416f81

(fixes error introduced in 21a6d13a.)

NOTRY=true
R=djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/255263002

git-svn-id: http://skia.googlecode.com/svn/trunk@14445 2bbb7eff-a529-9590-31e7-b0007b416f81

Move GrGLInterface function ptr setup into a common function for all OpenGL GrGLInterface factories (but not GLES yet).

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/254713006

git-svn-id: http://skia.googlecode.com/svn/trunk@14444 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=skia:2043,skia:2044,skia:1942,skia:2466
R=caryclark@google.com
TBR=caryclark

Author: epoger@google.com

Review URL: https://codereview.chromium.org/262453002

git-svn-id: http://skia.googlecode.com/svn/trunk@14443 2bbb7eff-a529-9590-31e7-b0007b416f81

* android_gdbserver:
  - Don't complain if $GDB_TMP_DIR already exists
  - Since $GDB_TMP_DIR/gdb.setup might already exist, overwrite the file.

* android_run_skia:
  - Move resource files onto the device.
  - Change to tmp directory before executing program.

* android_make, android_setup:
  - stop assuming PWD is skia source directory.

NOTRY=true
R=djsollen@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/254923003

git-svn-id: http://skia.googlecode.com/svn/trunk@14442 2bbb7eff-a529-9590-31e7-b0007b416f81

The warning was:
	warning: Could not load shared library symbols for 4 libraries,
	e.g. /system/bin/linker.  Use the "info sharedlibrary" command to
	see the complete listing.

Fixed by grabbing all of those libraries along with libc.so.

NOTRY=true
R=scroggo@google.com, djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/255193003

git-svn-id: http://skia.googlecode.com/svn/trunk@14441 2bbb7eff-a529-9590-31e7-b0007b416f81

This refactoring seemed sufficiently fraught that I've broken it out of a larger patch to move fBitmapHeap out of SkPictureRecord/SkPicturePlayback and into SkPicture.

SkPicturePlayback's friending of SkPicture should be temporary and just allows SkPicture to access items that will be moving into it soon.

R=scroggo@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/256653006

git-svn-id: http://skia.googlecode.com/svn/trunk@14440 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=skia:2480
NOTRY=true
R=epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/254013003

git-svn-id: http://skia.googlecode.com/svn/trunk@14439 2bbb7eff-a529-9590-31e7-b0007b416f81

tested: out/Debug/dm && out/Release/dm

BUG=skia:2477
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/253733006

git-svn-id: http://skia.googlecode.com/svn/trunk@14438 2bbb7eff-a529-9590-31e7-b0007b416f81

TBR=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/255133004

git-svn-id: http://skia.googlecode.com/svn/trunk@14437 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=skia:2449
NOTRY=true
R=epoger@google.com
TBR=epoger

Author: borenet@google.com

Review URL: https://codereview.chromium.org/259263002

git-svn-id: http://skia.googlecode.com/svn/trunk@14436 2bbb7eff-a529-9590-31e7-b0007b416f81

Convert Color32 to intrinsics

This change is performance-neutral for high values of count and is
a big improvement for values smaller than 64.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=skia:
R=djsollen@google.com, mtklein@google.com, borenet@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/258173005

git-svn-id: http://skia.googlecode.com/svn/trunk@14435 2bbb7eff-a529-9590-31e7-b0007b416f81

An integer overflow was causing an issue when reading a string with a very large (or negative) size.

BUG=367764
R=senorblanco@google.com, senorblanco@chromium.org, reed@google.com, borenet@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/255693003

git-svn-id: http://skia.googlecode.com/svn/trunk@14434 2bbb7eff-a529-9590-31e7-b0007b416f81

On Mike's suggestion, I tested out not doing any empty-clip check at all in
SkRecordDraw, given that mostly we'll do that again anyway inside SkCanvas.

Most SKPs are identical to the status quo, whether bot or silk, played back in tiles
or full.  Average playback performance, both arithmetic and geometric mean, is also
unchanged.

A handful of SKPs do draw faster or slower reliably, particularly when tiled.  E.g. a
cnn tile draws about 40% faster, a cuteoverload tile about 20% slower.  Their profiles
look pretty much the same before and after, so I can't really explain the changes.

I'd say, given that performance is mostly identical and very identical in bulk,
we might as well remove this code.  It's nice to keep SkRecordDraw as dumb as possible.

BUG=skia:2378
R=reed@google.com, fmalita@chromium.org, mtklein@google.com, borenet@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/258183002

git-svn-id: http://skia.googlecode.com/svn/trunk@14433 2bbb7eff-a529-9590-31e7-b0007b416f81

Add a new GM that exercises tiled drawing all pixel-moving filters
(and some non-pixel-moving ones) and compares it against non-tiled
drawing of the same filters. Fixing this test revealed that tile and
matrix convolution filters had no onFilterBounds() traversals
(test-driven development FTW). Tile requires (conservatively) the
bounds to include the whole source rect, since it may end up in the
result. Matrix convolution requires the bounds to be offset by the
kernel size and target.

R=reed@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/258243005

git-svn-id: http://skia.googlecode.com/svn/trunk@14432 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=skia:
R=djsollen@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/253633003

git-svn-id: http://skia.googlecode.com/svn/trunk@14431 2bbb7eff-a529-9590-31e7-b0007b416f81

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/260363002

git-svn-id: http://skia.googlecode.com/svn/trunk@14430 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=skia:
R=caryclark@google.com
TBR=caryclark

Author: humper@google.com

Review URL: https://codereview.chromium.org/256273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14429 2bbb7eff-a529-9590-31e7-b0007b416f81

git-svn-id: http://skia.googlecode.com/svn/trunk@14428 2bbb7eff-a529-9590-31e7-b0007b416f81

Add __init__.py to gyp_gen and explicitly include android_framework_gyp
from there.

Fixes a bug where after moving that file, python was looking for it in
its old location, where there was a compiled version of the file.

BUG=skia:2468
R=epoger@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/251903003

git-svn-id: http://skia.googlecode.com/svn/trunk@14427 2bbb7eff-a529-9590-31e7-b0007b416f81

Just like with http://code.google.com/p/skia/source/detail?r=13618,
listing angle.gyp as a dependency when in the Android tree (i.e.
w/o third_party/externals) causes gyp_to_android.py to fail.

(See http://108.170.220.27:10115/builders/Housekeeper-PerCommit-AndroidRoll/builds/229/steps/Merge/logs/stdio
for example failure.)

Fortunately, views (and views_animated) has no need to depend directly
on angle.

R=bungeman@google.com, bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com

BUG=skia:2447

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/253773004

git-svn-id: http://skia.googlecode.com/svn/trunk@14426 2bbb7eff-a529-9590-31e7-b0007b416f81

Failed builders https://codereview.chromium.org/225023031/ at PS 24 look like they're failing because we're not exposing these symbols when Skia's a dynamic library.

BUG=skia:2378
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/253883003

git-svn-id: http://skia.googlecode.com/svn/trunk@14425 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/252993003

git-svn-id: http://skia.googlecode.com/svn/trunk@14424 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=skia:
NOTRY=true
TBR=borenet

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/253743005

git-svn-id: http://skia.googlecode.com/svn/trunk@14423 2bbb7eff-a529-9590-31e7-b0007b416f81

BUG=skia:2469
NOTRY=true
NOTREECHECKS=true
R=caryclark@google.com
TBR=caryclark@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/260053007

git-svn-id: http://skia.googlecode.com/svn/trunk@14422 2bbb7eff-a529-9590-31e7-b0007b416f81

The current implementation relies on soon-to-be-deprecated
kClip_SaveFlag behavior. Updated to use default save flags
(kMatrixClip_SaveFlag) and stop assuming that the matrix survives
restore() calls.

R=junov@chromium.org, reed@google.com, robertphillips@chromium.org, robertphillips@google.com

Committed: http://code.google.com/p/skia/source/detail?r=14319

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/246893005

git-svn-id: http://skia.googlecode.com/svn/trunk@14421 2bbb7eff-a529-9590-31e7-b0007b416f81

And nonlinearly stretch the resulting texture across proxy geometry.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=14392

Committed: http://code.google.com/p/skia/source/detail?r=14404

R=bsalomon@google.com, reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/248613004

git-svn-id: http://skia.googlecode.com/svn/trunk@14420 2bbb7eff-a529-9590-31e7-b0007b416f81

No measurable playback speed difference, but simpler code.

This makes sense: I'm seeing SkRecordDraw at ~0.25% of playback cost.  We can
pretty much do whatever we want in there for free if it helps avoid real work.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/260143002

git-svn-id: http://skia.googlecode.com/svn/trunk@14419 2bbb7eff-a529-9590-31e7-b0007b416f81

Rename GR_GL_GET_PROC macros in mesa and unix GrGLInterface factories to be more consistent with other platforms.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/258693008

git-svn-id: http://skia.googlecode.com/svn/trunk@14418 2bbb7eff-a529-9590-31e7-b0007b416f81

Default bench_record to report us, bench_playback ms.

BUG=skia:2378
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/253843004

git-svn-id: http://skia.googlecode.com/svn/trunk@14417 2bbb7eff-a529-9590-31e7-b0007b416f81

This CL just sketches out the structure of the gpuveto testing process. Two big areas for improvement are:
  render the picture in tiles and label as unsuitable if any gpu tile is slower than raster
  decide on whether tilegrid is used or not

As expected the current gpuveto heuristic isn't so good:

predicted 	   suitable    unsuitable
-------------------------------------------
actual suitable      10           17
actual unsuitable    15           27

R=rmistry@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/257723003

git-svn-id: http://skia.googlecode.com/svn/trunk@14416 2bbb7eff-a529-9590-31e7-b0007b416f81