Commits · 576dcdc793a762ec63fbecdbfd5768066b548fe5 · halo / external_skia

04 Jun, 2014 5 commits

Move Dashing filterPath to a dashing utils file · 576dcdc7

egdaniel authored 11 years ago

From inside GrContext, we have a need to create an SkPath an original path and
some dashing info. We do not have access to the original path effect so we need
a way to make the FilterPath function accessible outside of the effect. So I moved
the core filterPath code (and all need helper functions) out of SkDashPathEffect
and created a SkDashPath in utils to store these helper functions.

BUG=skia:
R=bsalomon@google.com, reed@google.com, rmistry@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/314623004

576dcdc7

Add bench to measure drawing a dashed grid · 05bb6f13

egdaniel authored 11 years ago

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/310083005

05bb6f13

Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) · 9b14f26d

robertphillips authored 11 years ago

R=reed@google.com, bsalomon@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/313613004

9b14f26d

Whitespace change to test bugdroid · 232f7259
Ravi Mistry authored 11 years ago
```
(SkipBuildbotRuns)

BUG=skia:2139,chromium:380617
```
232f7259

Update SKP version to 17 · e2d543a8

borenet authored 11 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/312043004

e2d543a8

03 Jun, 2014 33 commits

readd SK_SUPPORT_LEGACY_SETCONFIG_INFO -- missed a place in a blink test · abc07337

reed authored 11 years ago

R=jvanverth@google.com
TBR=jvanverth
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/316753002

abc07337

Disable PDF in dm for tonight. It's crashy. · e696a596

mtklein authored 11 years ago

BUG=skia:2598
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/317533003

e696a596

Added grid data to logging output · 06fdc693

kelvinly authored 11 years ago

BUG=skia:
R=bensong@google.com, jcgregorio@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/318433003

06fdc693

remove unneeded flags SK_SUPPORT_LEGACY_SETCONFIG_INFO and SK_SUPPORT_LEGACY_DEVICE_CONFIG · 9307073a
reed authored 11 years ago
```
TBR=scroggo

Author: reed@google.com

Review URL: https://codereview.chromium.org/315733002
```
9307073a

Android: remove -lcutils dependency · bec3634a

mtklein authored 11 years ago

I believe we no longer depend on this after we ported our atomics to __sync.

Tested by running android_ninja.

BUG=skia:
R=scroggo@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/318493002

bec3634a

DM: add pdf · 30bf3e2f

mtklein authored 11 years ago

BUG=skia:2598
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/312873002

30bf3e2f

DM: go back to memcmp for BitmapsEqual · 9c4ff80d

mtklein authored 11 years ago

Even when autovectorized, using MaxComponentDifference is slower than memcmp.
And debug builds (most runs of DM) will never even be autovectorized.

DM::MaxComponentDifference is the top function on DM profile, and memcmp moves
to ~20th.

BUG=skia:
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/315743002

9c4ff80d

Whitespace change to test the new cron.chrome bugdroid. · 182a631e
Ravi Mistry authored 11 years ago
```
(SkipBuildbotRuns)
BUG=skia:2139

Review URL: https://codereview.chromium.org/309333003
```
182a631e

Fix neglected cleanup of SkTileGridPicture.h · 795883e1

robertphillips authored 11 years ago

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/312803003

795883e1

Return NULL when building empty LayerRasterizer. · 65044bfe

scroggo authored 11 years ago

In SkLayerRasterizer::snapshotRasterizer() and ::detachRasterizer(),
if no layers have been added, do not attempt to create an
SkLayerRasterizer. Instead, return NULL.

This fixes an error when running tests on Android.

Update dox to state that NULL may be returned.

Add tests.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/313653006

65044bfe

Initial KTX file decoder · 99ffe242

krajcevski authored 11 years ago

R=bsalomon@google.com, robertphillips@google.com, halcanary@google.com, reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/302333002

99ffe242

Add LICENSE & README.google files to third_party/etc1 · 8a35140f

robertphillips authored 11 years ago

R=djsollen@google.com, krajcevski@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/309343004

8a35140f

SK_CPU_ARM --> SK_CPU_ARM32 · 3a2682a7

mtklein authored 11 years ago

That's what it means.  It keeps confusing us as named today.

BUG=skia:
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/314643004

3a2682a7

manual bench rebase after · 1800b1f5

jvanverth authored 11 years ago

R=robertphillips@google.com
TBR=robertphillips@google.com

Bypassing trybots:
NOTRY=true

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/315683004

1800b1f5

remove SkBounder -- unused and unloved · 868074b5

reed authored 11 years ago

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/312553006

868074b5

download_actuals.py: download JSON files from Google Storage instead of skia-autogen · 55ada063

epoger authored 11 years ago

uses google-api-python-client instead of gsutil binary to interact with Google Storage

BUG=skia:553
R=rmistry@google.com, bensong@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/309653005

55ada063

a few rebaseline stragglers from image scaling change · 2db11d18

humper authored 11 years ago

BUG=skia:
NOTRY=True
NOTREECHECKS=True
TBR=jvanverth

Author: humper@google.com

Review URL: https://codereview.chromium.org/311853004

2db11d18

ARM Skia NEON patches - 38 - arm64 8888 blitters · 866b95d6

kevin.petit authored 11 years ago


Enable NEON on arm64 for most 8888 blitters

This patch enables NEON optimisation for the Color32, S32_Blend,
S32A_Opaque blitters on arm64.

Here are the perf improvements vs the existing code:

Color32:
========

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -2.39% |     23.78% |
+-------+------------+------------+
|     2 |     -5.46% |      8.88% |
+-------+------------+------------+
|     4 |     -4.74% |      4.89% |
+-------+------------+------------+
|     8 |     67.74% |    107.12% |
+-------+------------+------------+
|    16 |     40.03% |    101.20% |
+-------+------------+------------+
|    64 |     11.09% |     98.40% |
+-------+------------+------------+
|   256 |     -2.20% |     74.81% |
+-------+------------+------------+
|  1024 |     -4.28% |     78.90% |
+-------+------------+------------+

S32_Blend:
==========

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |      7.84% |     -6.75% |
+-------+------------+------------+
|     2 |     28.95% |     39.77% |
+-------+------------+------------+
|     4 |      5.80% |      8.26% |
+-------+------------+------------+
|     8 |      1.35% |     33.80% |
+-------+------------+------------+
|    16 |     -2.13% |     41.13% |
+-------+------------+------------+
|    64 |     -4.91% |     42.84% |
+-------+------------+------------+
|   256 |     -6.53% |     48.72% |
+-------+------------+------------+
|  1024 |     -6.65% |     46.66% |
+-------+------------+------------+

S32A_Opaque:
============

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -7.51% |    -19.06% |
+-------+------------+------------+
|     2 |     -5.02% |    -27.70% |
+-------+------------+------------+
|     4 |     15.38% |    -21.66% |
+-------+------------+------------+
|     8 |     -0.98% |      1.05% |
+-------+------------+------------+
|    16 |     -7.35% |      3.34% |
+-------+------------+------------+
|    64 |     50.53% |     94.63% |
+-------+------------+------------+
|   256 |     71.17% |    164.10% |
+-------+------------+------------+
|  1024 |     79.58% |    197.60% |
+-------+------------+------------+
Signed-off-by: Kevin PETIT <kevin.petit@arm.com>

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/302283003

866b95d6

Remove legacy picture recording · dcf9ab14

robertphillips authored 11 years ago

This is unblocked now that Android no longer uses the old interface.

This is just the first step in cleaning this up. Future CLs will constify SkPicture access in SkCanvas and split up the SkPicture/SkPicturePlayback/SkPictureRecord trio.

R=bsalomon@google.com, reed@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/313613002

dcf9ab14

Update SKP version to 16 · 66aa609a

borenet authored 11 years ago

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/313593002

66aa609a

Fix etc1 support for SkFiddle. · 92bfb09a

jcgregorio authored 11 years ago

Also update design doc to fix MySQL notation for auto incrementing columns.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/315643002

92bfb09a

Fix memory leak in etc1bitmap GM. · 04cd368c

mtklein authored 11 years ago

We never drop our first ref on fileData. (All our ref counts start at one).
SkAutoTUnref<T> is almost always the right thing to use for refcounted types.

BUG=skia:2635
R=krajcevski@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/310793003

04cd368c

Allow chrome to use old version of installPixels. · 14052a0b

scroggo authored 11 years ago

R=jvanverth@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/312703003

14052a0b

Update link to Doxygen. · d0f18b1f

jcgregorio authored 11 years ago

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/302543007

d0f18b1f

Rebase a few GMs and remove some tests from ignored-tests.txt · c7671bec
Brian Salomon authored 11 years ago
```
Review URL: https://codereview.chromium.org/311813003
```
c7671bec

Remove brackets from gm names. · ef470f18

scroggo authored 11 years ago

BUG=skia:2634
R=epoger@google.com, borenet@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/307373003

ef470f18

Fall back to using clip effect for outer rect in drawdrrect · 8af0523b

bsalomon authored 11 years ago

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/310483010

8af0523b

Whitespace change to test multiple master support in CQ · 5fb3392c

rmistry authored 11 years ago

TBR=
BUG=skia:2624

(SkipBuildbotRuns)

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/315633002

5fb3392c

remove unneeded flags · 9b4353c8

reed authored 11 years ago

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/316463002

9b4353c8

Whitespace change to test new CQ trybot · da23e58b

rmistry authored 11 years ago

TBR=
BUG=skia:2203
(SkipBuildbotRuns)

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/311813002

da23e58b

Revert of Try TSAN blacklist for SkGLContextHelper::init.... · 59ef7704

mtklein authored 11 years ago

Revert of Try TSAN blacklist for SkGLContextHelper::init. (https://codereview.chromium.org/309823004/)

Reason for revert:
the bot's clang doesn't know -fsanitize-blacklist

Original issue's description:
> Try TSAN blacklist for SkGLContextHelper::init.
>
> Submitting to test this; this particular problem only happens on the bot.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/ab2ec19b975a898d4ee2278ddad7d4268f134478

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/314543002

59ef7704

Try TSAN blacklist for SkGLContextHelper::init. · ab2ec19b

mtklein authored 11 years ago

Submitting to test this; this particular problem only happens on the bot.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309823004

ab2ec19b

Clean up another silly race in benches when run concurrently. · cf44feb0

mtklein authored 11 years ago

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309193003

cf44feb0

02 Jun, 2014 2 commits

Tweak TSAN suppressions. · a78ef795

mtklein authored 11 years ago

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/312613002

a78ef795

remove unneeded inval · 73be51ee

reed authored 11 years ago

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/307993012

73be51ee