• scroggo@google.com's avatar
    Replace SkPicture(SkStream) constructors with a factory. · f1754ec6
    scroggo@google.com authored
    SkPicture:
    Remove the constructors which take an SkStream as an argument. Rather
    than having to check a variable for success, the factory will return
    NULL on failure.
    Add a protected function for determining if an SkStream is an SKP
    to share code with SkTimedPicture.
    In the factory, check for a NULL SkStream.
    Use a default decoder (from BUG:
    https://code.google.com/p/skia/issues/detail?id=1325)
    
    SkDebuggerGUI:
    Call SkPicture::CreateFromStream when necessary.
    Write a factory for creating SkTimedPictures and use it.
    
    Use the factory throughout tools.
    
    Add include/lazy to utils and effects gyp include_dirs so SkPicture.h
    can reference SkImageDecoder.h which references SkBitmapFactory.h (in
    include/lazy).
    
    Changes code Chromium uses, so this will require a temporary Skia
    and then a change to Chromium to use the new Skia code.
    
    TODO: Create a decoder that does nothing to be used by pinspect,
    lua pictures, etc, and allow it to not assert in SkOrderedReadBuffer.
    
    R=reed@google.com
    
    Review URL: https://codereview.chromium.org/17113004
    
    git-svn-id: http://skia.googlecode.com/svn/trunk@9822 2bbb7eff-a529-9590-31e7-b0007b416f81
    f1754ec6
utils.gyp 7.33 KB