• commit-bot@chromium.org's avatar
    Updates to Android.mk generation. · ba0c5ea9
    commit-bot@chromium.org authored
    Generate SkUserConfig.
    Include arm64 as another build flavor.
    Add tests.
    
    gyp/common_conditions.gypi:
    Add conditions for Android framework. These will get written into the generated SkUserConfig.
    
    include/core/SkUserConfig.h:
    Generated version that will ultimately be checked into Android (but not here).
    
    platform_tools/android/bin/gyp_to_android.py:
    Generate SkUserConfig.
    Add arm64 (note that arm64 is not currently respected by our gyp files, so it results in use _none.cpp for the various opts).
    Reset the common defines, which are now passed to the generated SkUserConfig.
    
    platform_tools/android/gyp_gen/generate_user_config.py:
    New script to generate SkUserConfig.h.
    
    platform_tools/android/gyp_gen/gypd_parser.py:
    Fix a lint error (unused import).
    
    platform_tools/android/gyp_gen/makefile_writer.py:
    Append any remaining DEFINES to LOCAL_CFLAGS (previously this was done during parsing).
    Add a warning for arm64 (corresponds to downstream Android.mk).
    
    platform_tools/android/gyp_gen/vars_dict_lib.py:
    Add OrderedSet.reset().
    Add DEFINES to VarsDict.
    
    platform_tools/android/tests/expectations/:
    Add and update expectations files.
    
    platform_tools/android/tests/generate_user_config_tests.py:
    New test for generate_user_config.py
    
    platform_tools/android/tests/inputs/SkUserConfig.h:
    Input to the new test, so we don't have to update the expectations each time the real SkUserConfig.h changes.
    
    platform_tools/android/tests/makefile_writer_tests.py:
    Add a way to rebaseline test_write_local_vars, which has changed.
    Refactor EXPECTATIONS_DIR and compare_files into a separate file for sharing with generate_user_config_tests.py.
    
    platform_tools/android/tests/utils.py:
    Common code for tests.
    
    platform_tools/android/tests/var_dict_tests.py:
    Use a for loop to test the new key (DEFINES) and future proof this test to test any new keys in the future.
    
    BUG=skia:1975
    R=djsollen@google.com, halcanary@google.com
    
    Author: scroggo@google.com
    
    Review URL: https://codereview.chromium.org/198063002
    
    git-svn-id: http://skia.googlecode.com/svn/trunk@13975 2bbb7eff-a529-9590-31e7-b0007b416f81
    ba0c5ea9
common_conditions.gypi 18.3 KB