• commit-bot@chromium.org's avatar
    Use SkAtomics_sync on Android · 64f6d154
    commit-bot@chromium.org authored
    Every doc I've found about using Android's atomics says, "stop".
    
    "* A handful of basic atomic operations.  The appropriate pthread
     * functions should be used instead of these whenever possible."
    
    "... we recommend stopping from using these functions entirely. Very fortunately, GCC provides handy intrinsics functions that work with very reasonable performance and always provide a full barrier."
    
    As far as I can tell, there's no code generation change here: both the __sync atomics and the android_ atomics use full memory barriers.  (And now with this all unified, it'll be easier to get the real wins by switching everything to __atomic atomics, which are like __sync atomics but allow control over memory barriers.)
    
    BUG=skia:
    R=bungeman@google.com, djsollen@google.com, mtklein@google.com, reed@google.com
    
    Author: mtklein@chromium.org
    
    Review URL: https://codereview.chromium.org/305593002
    
    git-svn-id: http://skia.googlecode.com/svn/trunk@14896 2bbb7eff-a529-9590-31e7-b0007b416f81
    64f6d154
common_conditions.gypi 21 KB