GitLab

ssh client security bug fix from
http://www.openssh.com/txt/release-7.1p2

openssh client is installed in gce instances.
although it's private key is not that much sensitive
it's better to land this security patch than not.

reported initially as cve-2016-0777 and cve-2016-0778
(January 14th, 2016)

BUG: 26587626
Change-Id: I113d576a3522ded8cb0f4a2e117999b0c51d4364

am: 7b8b4a6e

* commit '7b8b4a6e':
  Stop relying on global GCE_PLATFORM_SDK_VERSION

COMMON_GLOBAL_CFLAGS is being locked down. Instead, define it in the
LOCAL_CFLAGS where it is needed.

Bug: 26165350
Change-Id: Icd3e79c1f9439d7c32762cb51f66db5479750f40

in preparation of sandboxing.

Upstream patch is:

https://anongit.mindrot.org/openssh.git/patch/?id=07889c75926c040b8e095949c724e66af26441cb

BUG=25695426

Change-Id: I0f746c30e31e7d938c70bcebe402f472c4649919

Change-Id: I547bb616f1d1caeaf118a302fb9c8823fae1bb83

Change-Id: I5a1f2aaa9c6a7ed04b22d2a1e71c2573f324ceae

Change-Id: I01d674b9a2688f4a1d3e884c2f434bfaad06ac8b

This resolves an incompatibility with non-root adb.
BUG=22803455

Change-Id: I908923e9ddc04e0ec8de0122eb79486c8b1ae03e

am cfb649f1: remove .gce_x86 suffix from ssh output files (post_install_cmd is not supported in jb-mr1 and before).

* commit 'cfb649f1':
  remove .gce_x86 suffix from ssh output files (post_install_cmd is not supported in jb-mr1 and before).

remove .gce_x86 suffix from ssh output files (post_install_cmd is not supported in jb-mr1 and before).

Change-Id: I187386c699f22d80bac4c7f8c1e12ee5a590fb55
(cherry picked from commit 0c94e12d)

remove .gce_x86 suffix from ssh output files (post_install_cmd is not supported in jb-mr1 and before).

Change-Id: I187386c699f22d80bac4c7f8c1e12ee5a590fb55

Change-Id: Ia24dbd1b452298a3a6780b72497280ec9b912ec3

Change-Id: Ia04f3f83a237f4cbe636b14f221cffdf9460b3a4

This reverts commit b5de6ef9.

Change-Id: I3d3ac73aaee2bcc99bc8fd490588a76bd698915d

That file doesn't exist at least jb-gce-dev

Change-Id: I4a3cd97f2ee071ae74cb166baf38057671d76fef

Change-Id: I50317ca1eed43779352a44d8e02123583df6a4fd

In preparation for some updates to external/openssh to make it work with
BoringSSL, this change updates the code to a recent version. The current
version (5.9p1) is coming up on four years old now.

  * Confirmed that f5c67b47 matches
    OpenSSH 5.9p1 exactly (save for the removal of the scard
    subdirectory).

  * Downloaded openssh-6.8p1.tar.gz (SHA256:
    3ff64ce73ee124480b5bf767b9830d7d3c03bbcb6abe716b78f0192c37ce160e)
    and verified with PGP signature. (I've verified Damien's key in
    person previously.)

  * Applied changes between f5c67b47 and
    OpenSSH 5.9p1 to 6.8p1 and updated the build as best I can. The
    ugliest change is probably the duplication of umac.c to umac128.c
    because Android conditionally compiles that file twice. See the
    comment in those files.

Change-Id: I63cb07a8118afb5a377f116087a0882914cea486

Change-Id: I1cda84a412666d5123be274ee0be399d25d86164

Change-Id: I23324372188fa6ed3f93a32b84365f5df6367590

This may require changes to other code, such as fastbootd, which relies on this
service.  sshd is not currently, used, however, so this change will force any
such code to be changed.

Bug: 11594902
Change-Id: I07e52008290dab5825be2ad062cbe730fa7dff71

Previously openssh was declaring its own arc4random but accidentally picking
up a lower-quality implementation from libc.

Bug: 14499627
Change-Id: Ie0c4ddb78101a666af3ec3eb9dc03c8fb44f6c4b

This unconditionally includes RIPEMD, but it's the only place in the
Android source code base. Instead of restoring RIPEMD to OpenSSL, just
remove it here.

Change-Id: Ie949f64cef1cb7de39baae3f118f2188e663c875

Change-Id: Ia0f7247c9ed64ea846ae5b2d26054ceade5686c5

Change-Id: Ie36338f174f891dee3f531d0b261d58e211d095f

Change-Id: I61954d6a5c8d0c9b34501dcfb13ce38dc07e267a
Signed-off-by: Mike Lockwood <lockwood@google.com>

Change-Id: I4aed01758ca5589a6bf1642e9f2f2894221c82b9
Signed-off-by: Mike Lockwood <lockwood@google.com>

This allows things like logcat, reboot, internet, SD card access, etc. to
work in an ssh shell like it would in an adb shell.

Change-Id: I6c921d9900a09394250c7b1ae0512d1eef3c1187
Signed-off-by: Mike Lockwood <lockwood@google.com>

Change-Id: Ic58de0027d947e7b0535edb3fef6bd26519655a1
Signed-off-by: Mike Lockwood <lockwood@google.com>

Change-Id: I4452ad6b23b6ce5e69287b09f9e786942638256d
Signed-off-by: Mike Lockwood <lockwood@google.com>

Change-Id: I7be8ef7c0425a48500501895c5eabcebcbdf7aa1
Signed-off-by: Mike Lockwood <lockwood@google.com>

Operation instructions:
    start from init.rc using start-ssh script
    Add your public key to /data/ssh/authorized_keys
    login with "ssh shell@<ip address>" from another computer on same network

Change-Id: I1085a8b2f2766d4a2a4a70ffaf0352b07c261281
Signed-off-by: Mike Lockwood <lockwood@google.com>

Change-Id: I0a1997bfa45966f619f9ec5ffaeb8f9be9f741e9
Signed-off-by: Mike Lockwood <lockwood@google.com>

Change-Id: I991b8d22c9904ed6ced33a096776f4f342af52a8
Signed-off-by: Mike Lockwood <lockwood@google.com>