Skip to content

GitLab

Switch branch/tag
  1. 13 Nov, 2014 8 commits
    • jdduke's avatar
      Cherry-pick: Reland [Android] Mark posted UI thread tasks as asynchronous · 692aa678
      jdduke authored 
      Clean cherry-pick of chromium
crrev.com/d51117a99a4e023e791134185c6db12b28028a1d

BUG: 18283959

Original description:

Chromium shares a message loop with Android on the browser UI thread.
This can cause problems when the associated Looper has a sync barrier,
preventing posted Chromium tasks from being dispatched until the
barrier is removed. Make this sharing more fair by marking all Chromium
Message tasks as asynchronous, avoiding stalls when there is a sync
barrier.

Note: This change was originally landed in crrev.com/512333002, but was
reverted to gather more data about sync barrier impact and investigate
alternative solutions. The investigation determiend that this approach
is fine for the near future, though it will likely evolve in time.

Change-Id: I9879a9c1bdad0dcec12c2bbee62356a5b12d9596
      692aa678
    • jdduke's avatar
      Cherry-pick: Revert of [Android] Experimental sync barrier detection for... · 7a4903d2
      jdduke authored 
      Cherry-pick: Revert of [Android] Experimental sync barrier detection for tracing (patchset #6 id:100001 of https://codereview.chromium.org/575103002/)

Cherry-pick of chromium
crrev.com/adefc40cb9652a2ea046bbdbef223d881f4a7463

Conflicts:
	base/android/java/src/org/chromium/base/SystemMessageHandler.java

BUG: 18283959

Original description:

Reason for revert:
Barrier detection is no longer necessary, see crrev.com/512333002.

Original issue's description:
> [Android] Experimental sync barrier detection for tracing
>
> When an Android View is invalidated outside of frame dispatch
> (animation/input/draw), a sync barrier may be inserted into the shared
> UI thread message loop. This effectively blocks dispatch of all Chrome
> tasks posted to the browser UI thread for an entire frame (or more if
> the View is continually invalidated).
>
> There are currently no easy or even automated ways to avoid this
> untimely invalidation, and judicious coding can only take us so far. As
> an intermediate assist in debugging the issue, use reflection and a
> crude form of MessageQueue inspection to trace known cases where the
> MessageQueue is blocked by a sync barrier.
>
> Note that this detection is not perfect, neither is it exact, but it's a
> solid proxy for informing traces about such pipeline stalls.
>
> BUG=407133
>
> Committed: https://crrev.com/85bceaa6e05ee1bf42ac220ddcbb50ca268c1ea4
> Cr-Commit-Position: refs/heads/master@{#296249}

Change-Id: Ie92ab895b864bf466ac092a1a1b7fdc80a8fd3ce
      7a4903d2
    • Selim Gurun's avatar
      Merge "Clear the selection when hiding the handles" into m39 · 3eaa0a68
      Selim Gurun authored
      3eaa0a68
    • Ben Murdoch's avatar
      Merge "Implement support for SmartClip in AwContents." into m39 · 66b65590
      Ben Murdoch authored
      66b65590
    • Selim Gurun's avatar
      Clear the selection when hiding the handles · 5154ef92
      Selim Gurun authored 
      Bug: 18200283

Cherry-pick https://codereview.chromium.org/713493003.

Clear the selected text when hiding the handles and the desired
behavior is to "unselect all on dismiss".

BUG=430859
internal b/18200283

Review URL: https://codereview.chromium.org/713493003

Change-Id: Ie8d751774c6341054f0c1b8d4cca91ba6877e373
Cr-Commit-Position: refs/heads/master@{#303946}
      5154ef92
    • enne's avatar
      Cherry-pick: cc: Add invalidations when shrinking piles · 757e6d30
      enne authored 
      Cherry-pick of chromium
crrev.com/2c8b61a4db617427448947ff740ba002da1a9644

Conflicts:
	cc/resources/picture_pile_unittest.cc

BUG: 17965814

Original description:

Previously, there was a hack/optimization where when shrinking a pile,
there would be no invalidations.  Unfortunately, this hack's time has
come due.  When zooming out, recorded pixels outside of the pile's newly
shrunken bounds can get used, causing pixels from old frames to get
incorrectly sampled, causing bogus hairlines.

To fix this, issue invalidations for previously exposed content in the
same way that invalidations are currently issues for newly exposed
content.

Change-Id: I3287e7e2261328a37781bf58da97ac4b7e60cb73
      757e6d30
    • Ben Murdoch's avatar
      Merge "Cherry pick [Android] Stop temporarily hiding selection handles" into m39 · 1e9ec2c9
      Ben Murdoch authored
      1e9ec2c9
    • Ben Murdoch's avatar
      Merge "Cherry pick [Android] Support unfocusable container views." into m39 · 67ded3db
      Ben Murdoch authored
      67ded3db
  3. 12 Nov, 2014 7 commits
    • Ignacio Solla's avatar
      Merge "[WebView] Build chromium against SDK 21." into m39 · ef403747
      Ignacio Solla authored
      ef403747
    • Ben Murdoch's avatar
      Cherry pick [Android] Stop temporarily hiding selection handles · c016285e
      Ben Murdoch authored 
      Bug: 18066784

Original change description:

Previously, selection handles would be hidden when the content view
became unfocused. This approach worked fine in Chrome, where the focus
model is predictable, but led to undesirable consequences in WebView,
e.g., the handles never being shown. For now, avoid making any kind of
visibility changes to the handles when the focus changes, ensuring
handle visibility is consistent with the selection.

Also ensure timely cleanup of the PopupTouchHandleDrawable Java object
after its native counterpart has been destroyed.

BUG=430859
(internal b/18066784)

Change-Id: I1741f81c5a12f71c053796cde37989366d2fcf10
Committed: https://crrev.com/1ba4ec56cb8f8e76f5d0cd37db09ebe41129c9c8
Cr-Commit-Position: refs/heads/master@{#303728}
      c016285e
    • Ben Murdoch's avatar
      Cherry pick [Android] Support unfocusable container views. · f66cc3b6
      Ben Murdoch authored 
      Bug: 18066784

Original change description:

If the ContentViewCore container view is not focusable (which can
happen when it's emebedded in an app via android webview), we
were clearing the RWHVA notion of focus when the RenderView was
swapped out. As the view is never focusable again, chromium never
considers this view focused and as such, text selection did not
function.

We support this type of container view by always treating it focused
from Chromium's point of view.

BUG=430859
(internal b/18066784)

Change-Id: If08372c93ff0c87b483f0b408f04247764db2c56
Committed: https://crrev.com/9074d9fc9119ef4d2223f6c993d1a1b67a0bea7c
Cr-Commit-Position: refs/heads/master@{#303071}
      f66cc3b6
    • Marcin Kosiba's avatar
      Cherry-pick: Pass the size to the RenderView on creation. · e578b2d2
      Marcin Kosiba authored 
      The size update races with the page load creating the opportunity
for the page to observe the initial (0,0) renderer size. This patch
addresses the issue by sending the initial size together with the
RenderView creation request.

BUG=424205

Review URL: https://codereview.chromium.org/659093002

Cr-Commit-Position: refs/heads/master@{#303775}

Conflicts:
	chrome/test/data/extensions/platform_apps/web_view/shim/main.js
	content/browser/renderer_host/render_widget_host_unittest.cc

BUG: 17892238
Change-Id: I11dca7e962421d46734d2122ec79bc501a2db09d
      e578b2d2
    • Ben Murdoch's avatar
      Implement support for SmartClip in AwContents. · ed880373
      Ben Murdoch authored 
      Bug: 18222974
Change-Id: I42e787b6205ec3c3764ec5076e2391e4ec4e4deb

Conflicts:
	android_webview/java/src/org/chromium/android_webview/AwContents.java
      ed880373
    • Ben Murdoch's avatar
      Record Chromium merge at DEPS revision 39.0.2171.59 · 53975c7d
      Ben Murdoch authored 
      This commit was generated by merge_to_master.py.

Change-Id: Icdd8bd8652dd63d1358a2022e1567051d48f760e
      53975c7d
    • Ben Murdoch's avatar
      Merge from Chromium at DEPS revision 39.0.2171.59 · 29b820f8
      Ben Murdoch authored 
      This commit was generated by merge_to_master.py.

Change-Id: If9c0c09d8c3a3121b5e75ae9c4c446e4e4baaae6
      29b820f8
  5. 10 Nov, 2014 2 commits
  7. 06 Nov, 2014 2 commits
  9. 29 Oct, 2014 2 commits
  11. 27 Oct, 2014 2 commits
  13. 22 Oct, 2014 3 commits
  15. 21 Oct, 2014 1 commit
  17. 14 Oct, 2014 3 commits
  19. 30 Sep, 2014 2 commits
  21. 28 Aug, 2014 2 commits
  23. 19 Aug, 2014 2 commits
  25. 12 Aug, 2014 2 commits
  27. 21 Jul, 2014 2 commits