GitLab

Change-Id: I6762a3a30d01bd6eb8bb25f23f390c91147fe9b4

We miss updating the type of objects if their nullability gets updated
first.

Bug: 25008765
(cherry picked from commit 83853392e26b2aa48328bb90c9f9c57b32c280dc)

Change-Id: I81aa759d96008251d74f941494abe74aa4b52bdc

For the case where the CppDefines do not match the device the JIT is
running on.

Sample logcat output to prove it works:
JIT instruction set variant krait
JIT instruction set features default

Bug: 24982714

(cherry picked from commit 085fc87e)

Change-Id: I1f4991a5d7cdc6101d1b0ecbcb39fb26dd20180a

Add missing uses of GetInterfaceMethodIfProxy in reflection code.

Add a test case for a JNI call to a proxy method.

Bug: https://code.google.com/p/android-developer-preview/issues/detail?id=2973
Bug: 23886441

(cherry picked from commit e8067324)

Change-Id: I5b66b64b5561fcee15d0314707d67e8abc02ce5b

Keep the dex2oat watchdog timeout lower than the package manager
timeout, so that dex2oat kills itself before the system server
watchdog kills the system because of the long installation.

Bug: 23629410

(cherry picked from commit 540138ae)

Change-Id: I425b19ab305cfaa43f6bddc3a892be892acaf513

There was a race condition between VisitNativeRoots and threads which were
updating the lengths and pointers of the direct or virtual methods of classes.

For example:
The thread doing VisitNativeRoots could see a null pointer with a non 0 length if
another thread had changed the length but not the pointer.

The fix is already in master, do not merge.

Bug: 24270063
Change-Id: Id7280b9507b95703820aedb6c5fee49966dabe27

Different parts of CreatePeer may throw an exception, especially
the Thread constructor. Do not abort in such a case, but return
and report a failure to attach/create a thread.

Bug: 24200698
Change-Id: I06f2c997f0451c71f791d1f12bea6f8ee65e8ab2

This reverts commit bd7eef17.

Bug: 24467386
Bug: 20037935
Change-Id: I04d1d0ffc67661370e4c17911d3b2b105d053bc1

In non-debug builds, clean up even less. We already did not shut
down the runtime. Also skipping the compiler driver and the
verification results removes all major points of destructor
performance.

Tested with a common large app on Nexus 9. Time between dex2oat timing
message and executable exit (log from immediately-after log echo)
[w/o swap, w/ swap].
Before:  2.409s / 48.774s
After:   0.132s /  0.188s

Bug: 24199200
Change-Id: I5d8c17f8e28796545cfbb3887c07c92905f9b48d
(cherry picked from commit 3f30e121)

Dumping the heap is a two-phase process. In the first phase, all
objects are visited to fill the header tables. In the second phase,
the tables are written out and the heap is visited again to write
the object records.

Deleting global references doesn't require the mutator lock. So it
is possible to delete a global ref in-between the first and the
second phase. This leads to a smaller set of object records. The
result is still safe, as the object's class etc. is still in the
header tables, and the object won't be deleted, so will still be
dumped by itself.

Bug: 23521263
Change-Id: I019c29b13ceb9f13e362c742662f1546d52c37a0

When checking on a null array, the cases of aput and aput-wide are
shared between integral and floating point types. Be careful to not
reject a valid program.

Bug: 21867457
Bug: 23201502

(cherry picked from commit 4bf4c78a)

Change-Id: I6c54a389c06e40a2dae00995aa16ff08a089e512

Only relying on register types is error-prone. For example, we may
inadvertently reject correct code when the constructor terminates
abnormally.

Bug: 20843113

(cherry picked from commit f10b6e10)
(cherry picked from commit af31802e)

Change-Id: I8826cd167780df25a6166740f183d216483fa550

Don't use odd numbered fp registers for single precision data on
MIPS32r6 (64-bit FPU).

Bug: 23050326
Change-Id: I35cc19df091149773411e2336b01c170929376bc
(cherry picked from commit fc8156a3)

DCE_GVN does not take into account the following case:
  mov a, b
  ...
  mov c, b
when optimization tries to replace a with c it must ensure that
for all uses of a there is no new definition of c before use.
Otherwise that use will incorrectly substituted with new c instead
of original b.

Bug: 23102860
Signed-off-by: Serguei Katkov <serguei.i.katkov@intel.com>

(cherry picked from commit 2f2f1739)

Change-Id: I1f08c99cedbe4fd1b96cad11f17d60ab551c7cf7

Change to use IsUnresolvedTypes.

Bug: 22881413
Change-Id: Ic27b97b475b28a5bdf994ea5178767e0efb0e752

Squashed cherry-picks:
* 067f1ed7
* 750f7c28
* 2f90b341
* 2ea7b70b

Bug: 22881413

We may get hints that do not work with the current implementation
of register pairs, which forces the allocation of (low + 1)
for the high register. For example, if the hint is EBX, we will
allocate ESP for the high register.

bug:23043730

(cherry picked from commit f2975811)

Change-Id: Ib395e36616017a87d3055218d72417f4e9ff6501

(cherry picked from commit a215b95d
and amended)

Bug: 21868508
Change-Id: Ic83813a966cef18e59447083926bf033aa587154

Instruction simplifier for add/sub should not proceed with floats
because that might cause the incorrect behavior with signed zero.

Bug: 23001681
Signed-off-by: Serguei Katkov <serguei.i.katkov@intel.com>

(cherry picked from commit 115b53f6)

Change-Id: I9928724c4158b3961e32e376b9203fe01ba2e442

x86_64 RoundDouble intrinsic should initialize output register for the case of
"inPlusPointFive >= maxLong" as expected. The same for the RoundFloat intrinsic.
Fixed also the out register type in CreateSSE41FPToIntLocations provoking
a DCHECK failure.
Signed-off-by: Pavel Vyssotski <pavel.n.vyssotski@intel.com>

(cherry picked from commit 9ca25719)

Bug: 22973442
Change-Id: If974e79d33311587d0b541a01ca8a4c9c11b9468

Bug: 21724724
Change-Id: Ifa99df9ee9f3265038a0c0f7944e834e42c498d4

Bug: 21868508

(cherry picked and squashed from commits
ec74835a and
0941b9d4)

Change-Id: I1750e6bea20321d04680132281a6c2924531c5ae

Values that are not live in compiled code anymore may still be needed in
interpreter, due to code motion, etc.

(cherry-picked from commit 718493c6)

Bug: 22665511
Change-Id: I8b85833c5c462f8fe36f86d6026a51b07563995a

Using SetFieldBooleanVolatile() and SetFieldBoolean() happens to work
for char values that only use the lower 8 bits, but is a mistake that
was introduced by the "Add AccessibleObject and Field to mirror" commit:

https://android.googlesource.com/platform/art/+/daaf326

(cherry picked from commit 3152c82b)

Bug:22772717

Change-Id: Iec02ba3084c992ea239ecef688d7d29c7e21ae16

Make offsets 16 digits on 64-bit platforms.

Add the ability to provide the build fingerprint, and print it in
the traces output.

Bug: 22693991
Change-Id: Ibd3d3b3bd65dce84acfb97a487807d6f280a9508

Quick's SuspendCheckElimination (SCE) expects that every
method contains a suspend check and it eliminates suspend
checks in loops containing an invoke. Optimizing eliminates
the suspend check from leaf methods, so the combination of
a Quick-compiled loop calling an Optimizing-compiled leaf
method can lead to missing suspend checks and potentially
leading to ANRs.

Enable Quick's kLeafOptimization flag to remove suspend
checks from leaf methods and disable Quick's SCE. This
aligns the suspend check placement for the two backends
and avoids the broken combination.

Currently, all methods containing a try-catch are compiled
with Quick, so it's relatively easy to create a regression
test. However, this test will not be valid when Optimizing
starts supporting try-catch.

Bug: 22657404

(cherry picked from commit d29e8487)

Change-Id: I733c38bf68bfc2c618f2f2e6b59f8b0e015d7be1

(cherry picked from commit 7c0fe5e9)

Bug: 22541058

Change-Id: Id084a69ccd9835147ec71df6bb759e0f1b5e6fbf

Fixes failing DCHECK.

(cherry picked from commit ef76c3fa)

Bug: 22553459
Change-Id: I6fe1012f9a5f8d29cb98bf25e3a279da51c5e1c0

In order to get closer to our code increase limit.

Bug:21868508

(cherry picked from commit 432bf3d5)

Change-Id: Iab19fe99a8a869b0fb841bac317016e4a3dc00e2

Boolean simplifier should not remove condition instruction
if it has side effects.

(cherry picked from commit 108ceb48)

Change-Id: I00dd595da1bba0f027f5c8647035e9fd8ba62ee1

array-length can throw NPE so it should be taking into account.

Bug: 22521944
Signed-off-by: Serguei Katkov <serguei.i.katkov@intel.com>

(cherry picked from commit b016c6dd)

Change-Id: I6232430a02f9e6d156ad2aae0eb5a630118c0e79

With this change, I can now enable debug malloc fully.

Bug: 19071092
Change-Id: Iabfb18505feffb480504a8bbfbac60dd219ed48a

(cherry picked from commit c3f73f78)

Bug: 21555893
Change-Id: I92e11637cc1f8f694e4d4138512cbcf47e22a249