Commits · 004a166ad79b86e790f27fdafc64aa71afdf0f82 · scorpio / external_skia

26 Aug, 2014 2 commits

PRESUBMIT should only check owners for the top level include directory · 9407eceb

rmistry authored 10 years ago

BUG=skia:1846
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/511503002

9407eceb

Public API changes are allowed if an owner is TBR'ed. · f2d83caf

rmistry authored 10 years ago

The following TBR formats are supported:
* TBR=reed
* TBR=reed@google.com
* TBR=xyz,reed
* TBR=xyz,reed@google.com

BUG=skia:2870
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/504843003

f2d83caf

18 Jul, 2014 1 commit

Adding djsollen to list of owners · 83fab473

rmistry authored 11 years ago

(SkipBuildbotRuns)

BUG=skia:
R=djsollen@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/397813007

83fab473

25 Jun, 2014 1 commit

Use new common tools in Python scripts · bb0ef0a1

Eric Boren authored 11 years ago

BUG=skia:2682
R=rmistry@google.com

Review URL: https://codereview.chromium.org/330423004

bb0ef0a1

03 Feb, 2014 1 commit

Check if the issue owner is in the AUTHORS file in PRESUBMIT.py · 745e08ca

commit-bot@chromium.org authored 11 years ago

BUG=skia:2072
NOTRY=true
(SkipBuildbotRuns)

R=borenet@google.com, hcm@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/131293005

git-svn-id: http://skia.googlecode.com/svn/trunk@13277 2bbb7eff-a529-9590-31e7-b0007b416f81

745e08ca

31 Jan, 2014 1 commit

Do not enforce the public API presubmit check for Revert CLs. · cfdc5962

commit-bot@chromium.org authored 11 years ago

NOTRY=true

BUG=skia:2068
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/151573002

git-svn-id: http://skia.googlecode.com/svn/trunk@13270 2bbb7eff-a529-9590-31e7-b0007b416f81

cfdc5962

28 Jan, 2014 1 commit

Adding rmistry for emergency reverts. · c2490880

commit-bot@chromium.org authored 11 years ago

(SkipBuildbotRuns)

TBR=
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/148583005

git-svn-id: http://skia.googlecode.com/svn/trunk@13212 2bbb7eff-a529-9590-31e7-b0007b416f81

c2490880

12 Aug, 2013 1 commit

If any change is made to the public API then make sure there is an LGTM from an owner. · fb4a68de

rmistry@google.com authored 11 years ago

This feature has been requested by reed@.

If no LGTM is found from an owner then the following msg is displayed:

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com')

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/22453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81

fb4a68de

12 Apr, 2013 1 commit

If the tree is closed then print information about contacting the sheriff. · 547012dc

rmistry@google.com authored 12 years ago

The motivation for this CL is because it is not very obvious on how to submit when tree is closed in git.

Also added a section 'How to submit when tree is closed' in https://sites.google.com/site/skiadocs/developer-documentation/tree-sheriff

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13932026

git-svn-id: http://skia.googlecode.com/svn/trunk@8666 2bbb7eff-a529-9590-31e7-b0007b416f81

547012dc

29 Mar, 2013 1 commit

Display prompt for caution only if it is an interactive shell. · f6c5f75b

rmistry@google.com authored 12 years ago

Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution.

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13325002

git-svn-id: http://skia.googlecode.com/svn/trunk@8446 2bbb7eff-a529-9590-31e7-b0007b416f81

f6c5f75b

25 Jan, 2013 1 commit

Presubmit should check that source files end in atleast one newline · 713276b1

rmistry@google.com authored 12 years ago

Review URL: https://codereview.appspot.com/7193063

git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81

713276b1

23 Jan, 2013 1 commit

Display a warning prompt in presubmit if the tree status is in 'Caution'. · c2993448

rmistry@google.com authored 12 years ago

Example presubmit output:


Running presubmit upload checks ...

** Presubmit Warnings **
Tree state is: caution

***************
Please use caution in checkins
http://skia-tree-status-staging.appspot.com/banner-status?format=json
***************

There were presubmit warnings. Are you sure you wish to continue? (y/N):
Review URL: https://codereview.appspot.com/7200043

git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81

c2993448

17 Jan, 2013 2 commits

Adding CheckChangeHasOnlyOneEol to upload and commit presubmit checks · 6be0b4c6

rmistry@google.com authored 12 years ago

Review URL: https://codereview.appspot.com/7151043

git-svn-id: http://skia.googlecode.com/svn/trunk@7247 2bbb7eff-a529-9590-31e7-b0007b416f81

6be0b4c6

Top-level presubmit script for Skia trunk that checks... · 8e3ff8cf

rmistry@google.com authored 12 years ago

Top-level presubmit script for Skia trunk that checks https://skia-tree-status.appspot.com/banner-status?format=json before a CL is committed.

gcl and git-cl will check for and run the presubmit script before you upload and/or commit your changes.
Review URL: https://codereview.appspot.com/7138046

git-svn-id: http://skia.googlecode.com/svn/trunk@7242 2bbb7eff-a529-9590-31e7-b0007b416f81

8e3ff8cf